Re: [core] AD review of draft-ietf-core-oscore-edhoc-08

Carsten Bormann <cabo@tzi.org> Fri, 29 September 2023 05:36 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E309AC169536 for <core@ietfa.amsl.com>; Thu, 28 Sep 2023 22:36:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.909
X-Spam-Level:
X-Spam-Status: No, score=-6.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8x6Te2jGC6Vs for <core@ietfa.amsl.com>; Thu, 28 Sep 2023 22:36:11 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [134.102.50.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F00C7C15106C for <core@ietf.org>; Thu, 28 Sep 2023 22:36:08 -0700 (PDT)
Received: from smtpclient.apple (p548dc15c.dip0.t-ipconnect.de [84.141.193.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4RxfGF3YnfzDCc4; Fri, 29 Sep 2023 07:36:05 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <CAGL5yWZ2PW9ajUmdA5NDq7g2UR7DBRZruMBND-p-3wRnSH_hWg@mail.gmail.com>
Date: Fri, 29 Sep 2023 07:35:54 +0200
Cc: stefan.hristozov@eriptic.com, rikard.hoglund@ri.se, "Apple Inc." <goran.selander@ericsson.com>, Marco Tiloca <marco.tiloca@ri.se>, Francesca Palombini <francesca.palombini@ericsson.com>, core@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0AF50AEF-312E-454A-8540-1F1003CABCBA@tzi.org>
References: <CAGL5yWZ2PW9ajUmdA5NDq7g2UR7DBRZruMBND-p-3wRnSH_hWg@mail.gmail.com>
To: Paul Wouters <paul.wouters=40aiven.io@dmarc.ietf.org>
X-Mailer: Apple Mail (2.3731.700.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/LBLmCFK_lY86iwlRGfAMWwQNNOw>
Subject: Re: [core] AD review of draft-ietf-core-oscore-edhoc-08
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2023 05:36:13 -0000

On 28. Sep 2023, at 22:08, Paul Wouters <paul.wouters=40aiven.io@dmarc.ietf.org> wrote:
> 
> Personal pet peeve: I dislike using +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> and prefer +-------+---------+---+-------------+-----+ style :)
> I have also never seen the usage of open ended boxes, so I would change:
> 
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |Ver| T |  TKL  |      Code     |          Message ID           |
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> | Token (if any, TKL bytes) ...
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> | Observe Option| OSCORE Option ...
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> | EDHOC Option  | Other Options (if any) ...
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |1 1 1 1 1 1 1 1| Payload ...
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Ah, but that is the form of the diagram we have been looking at for some ten years now (Figure 7 of RFC 7252)...

Grüße, Carsten