[core] Genart last call review of draft-ietf-core-object-security-13

Joel Halpern <jmh@joelhalpern.com> Fri, 20 July 2018 02:08 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A15D6130F88; Thu, 19 Jul 2018 19:08:06 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern <jmh@joelhalpern.com>
To: gen-art@ietf.org
Cc: draft-ietf-core-object-security.all@ietf.org, ietf@ietf.org, core@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.82.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153205248660.10636.17459130896592894639@ietfa.amsl.com>
Date: Thu, 19 Jul 2018 19:08:06 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/LufWGK2Ctp5YiT9y1zjMCoGH9ig>
Subject: [core] Genart last call review of draft-ietf-core-object-security-13
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.27
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2018 02:08:07 -0000

Reviewer: Joel Halpern
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-core-object-security-13
Reviewer: Joel Halpern
Review Date: 2018-07-19
IETF LC End Date: 2018-07-30
IESG Telechat date: Not scheduled for a telechat

Summary: this document is ready for publication as a Proposed Standard RFC.
    My minor concerns from draft -08 have been addressed.

Major issues: N/A

Minor issues:
    Section 7.2 is about sequence numbers.  The first sentence in 7.2 discusses
    Nonces.  Then the discussion switches to sequence numbers?  My guess is
    that the Nonce is left over from previous text?

Nits/editorial comments:
    In the first paragraph of 3.3, the text reads:
  The requirement that Sender ID SHALL be unique in the set of all security
  contexts using the same Master Secret, Master Salt, and ID Context
  guarantees unique (key, nonce) pairs, which avoids nonce reuse.
    Unfortunately, that is not a grammatical sentence.