[core] Orie Steele's Yes on draft-ietf-core-oscore-edhoc-10: (with COMMENT)

Orie Steele via Datatracker <noreply@ietf.org> Tue, 26 March 2024 15:08 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 23B33C14CE52; Tue, 26 Mar 2024 08:08:15 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Orie Steele via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-core-oscore-edhoc@ietf.org, core-chairs@ietf.org, core@ietf.org, cabo@tzi.org, cabo@tzi.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.8.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Orie Steele <orie@transmute.industries>
Message-ID: <171146569511.45063.3853837589196779736@ietfa.amsl.com>
Date: Tue, 26 Mar 2024 08:08:15 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/U6cVVQO7dG5WgK5jZNSOX2UbrSo>
Subject: [core] Orie Steele's Yes on draft-ietf-core-oscore-edhoc-10: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Mar 2024 15:08:15 -0000

Orie Steele has entered the following ballot position for
draft-ietf-core-oscore-edhoc-10: Yes

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-core-oscore-edhoc/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks to Shuping Peng for the ART-ART review.
Thanks to Carsten Bormann for the shepherd writeup.

In Section 2

"""
The Content-Format of the request can be set to application/cid-edhoc+cbor-seq.
"""

SHOULD ? or MUST ?.. same question for the use of "can" in the following
sections.

In Section 3.2.1

"""
The application/cid-edhoc+cbor-seq media type does not apply to this message,
whose media type is unnamed. """

I think this is intending to say "application/cid-edhoc+cbor-seq" SHOULD NOT be
used for this message... but this could be clearer if a media type was named.

In Section 8.4

Please consider explicit guidance regarding if IDs meet the specification
required range criteria.