[core] Review of draft-dijk-core-groupcomm-bis-02
Jim Schaad <ietf@augustcellars.com> Mon, 11 November 2019 23:17 UTC
Return-Path: <ietf@augustcellars.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 222E41200E3; Mon, 11 Nov 2019 15:17:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k9ezinecceUw; Mon, 11 Nov 2019 15:17:43 -0800 (PST)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B1D41200B5; Mon, 11 Nov 2019 15:17:43 -0800 (PST)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Nov 2019 15:17:36 -0800
From: Jim Schaad <ietf@augustcellars.com>
To: draft-dijk-core-groupcomm-bis@ietf.org
CC: 'Core WG mailing list' <core@ietf.org>
Date: Mon, 11 Nov 2019 15:17:34 -0800
Message-ID: <004501d598e6$34bd7830$9e386890$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AdWYOY3vmCyjz4VYRmuWEjaTvSz+EA==
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/fme0kaeiiroi6ETKxD3yoD_MiyE>
Subject: [core] Review of draft-dijk-core-groupcomm-bis-02
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2019 23:17:49 -0000
Here is a fast read through of the document. Overall it looks to be a good document. Jim 1. Abstract needs to note the obsoletes and update actions someplace. Also put into the introduction ( found in section 1.1 - might need to be earlier - depends on how the IESG feels). 2. Section 2.1.1 - I like the definition of a group here in many ways. I am wondering if it needs to be extended to deal with the prospective observe protocol (which might be below where I am reading) that was discussed in the virtual. In that case we are talking about an endpoint listening on the multicast address, but not as a server but looking for responses which corollate to a request. 3. Section 2.2.1, para 4 - This criteria does not seem reasonable. If it returns an error and then would return a success this seems to say that second response ought to be suppressed. 4. Section 2.2.1 - I think that the section on freeing up a token for unicast responses should be updated to deal with the change made in the draft-ietf-core-echo-request-tag. 5. Section 2.3.2 - is the last paragraph misplaced? 6. Section 5.2.3 - I think that this section needs a new title. It does not make any sense to me when I read it. I think you mean "Countering Attacks" 7. Section 5.2.3 - You make some grandiose statements about the fact that these attacks are countered without given any idea of how or where to go to find out how. 8. Security considerations. Should there be some type of statement that since all messages are non-confirmable, there is now way for a client to know if an attacker is capturing the packets for later replay? Nits Section 2.1.4, para 3 - s/participating to group/participating in group/ Section 2.2.1 s/but it MAY suppress this response if selected so by the server application/but the server MAY suppress the response if the server chooses/ s/is not standardized yet currently/ either yet or currently but not both section 4 s/so still allowing/while still allowing/