Re: [core] πŸ”” WG Last Call of CORECONF drafts: draft-ietf-core-yang-cbor-12, -sid-11, -comi-09, -yang-library-01 / -yang-cbor-12 review

Ivaylo Petrov <ivaylo@ackl.io> Tue, 07 April 2020 13:30 UTC

Return-Path: <ivaylo@ackl.io>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B6FEF3A09C7 for <core@ietfa.amsl.com>; Tue, 7 Apr 2020 06:30:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ackl-io.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MC7bwFbYhVh9 for <core@ietfa.amsl.com>; Tue, 7 Apr 2020 06:30:06 -0700 (PDT)
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C38183A09C8 for <core@ietf.org>; Tue, 7 Apr 2020 06:30:05 -0700 (PDT)
Received: by mail-wm1-x32a.google.com with SMTP id e26so1737438wmk.5 for <core@ietf.org>; Tue, 07 Apr 2020 06:30:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ackl-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8ATMdTvYksTMevIuulVvnxv9zyxIHXOaOR4+1iaUrHA=; b=Wu9TjYqJIylMxTN3kbv4zxySFigFklVlNADHsddl3MmVlEpCxRunvvMc5WPQIhqsDh glRwzt8/Zzp9GYpTQv34/qCAX6CvUhx4YfdxK6NxSDRAV+g3uqEHYNRXJbVzBS8qoIAZ wXwlYMe6/V4dPI+sV/Y1DmvYXIGezcqJWhzFEE/aAFbmHQrXhb+sO9A/mZIV423LlzZK d4TkxQQjKK75se2vAODKbD1OkmAzKZCpbmo+3I6s6Ow+gXaNFNLnHrYufo7kOwhX4mZd 1/jCB40BHtXKCodiJn4jPa++imwpjr84wvCKQAOOSsGOktPtTYOTEAAr2kZKOVLTNHQ6 ek+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8ATMdTvYksTMevIuulVvnxv9zyxIHXOaOR4+1iaUrHA=; b=J02scgBrjiCjTnmjN2CEtJ7u7Kql7GSl5tcI5PSK7fIM61r3r2E2R9OGIYLn9QBLvd fbDlbIbS/3Jgra6TdbbEo4/zyCSZAqAGeQD0LW2FWAsjBBbRVCtOV7CkU/2FoJXUS4A7 h9JUPCKBvIT0XYSwLVoD9J0EpNcPuCZFt69nYMdtDoxWx0ncqUFUaJvk1eeiiOgd2wUY gyceuE3HMJ7Yx5dhGdA/0tShV1gw1vqXalFNjhFCMl2GYJB3aMCRLwB0wbwYVnQB3Jl5 hLwf2A9Vxzma4sZAl4y/EYQhAHIDwvzoji1rQGqil8FvhbfUIh+7ni/cmENS4O5RZlLS B2DQ==
X-Gm-Message-State: AGi0Pua3buzLGmdFQFXpD8o/a6GRKXekxbxv8CcO1l94BRxpLxvQL2FS vlvSA/qHdoZdZJDkmI+PYd5zOwnG9SopqPgpJjDMaHHy
X-Google-Smtp-Source: APiQypJ6HPkBJ53UkpFbASJXprnR2PuOhyLv8Ffip4G3QVAwU+tZihoC9lNH+Msv+NlxrUDBRyScp2uR9hvDL/yB08c=
X-Received: by 2002:a1c:32c7:: with SMTP id y190mr2545553wmy.13.1586266203831; Tue, 07 Apr 2020 06:30:03 -0700 (PDT)
MIME-Version: 1.0
References: <AM5P190MB0275E7C8F67A739DD27B3B10FDCB0@AM5P190MB0275.EURP190.PROD.OUTLOOK.COM>
In-Reply-To: <AM5P190MB0275E7C8F67A739DD27B3B10FDCB0@AM5P190MB0275.EURP190.PROD.OUTLOOK.COM>
From: Ivaylo Petrov <ivaylo@ackl.io>
Date: Tue, 7 Apr 2020 15:29:37 +0200
Message-ID: <CAJFkdRyTduyOofkjKVMLDHj_u1yMgNjCAcxh-F+J1S5hfdWPrg@mail.gmail.com>
To: Esko Dijk <esko.dijk@iotconsultancy.nl>
Cc: "core@ietf.org WG" <core@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000099510605a2b3615a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/mLUlEq3_AtAohutCYP4K5zx8f4Y>
Subject: Re: [core] =?utf-8?q?=F0=9F=94=94_WG_Last_Call_of_CORECONF_drafts=3A?= =?utf-8?q?_draft-ietf-core-yang-cbor-12=2C_-sid-11=2C_-comi-09=2C_-yang-l?= =?utf-8?q?ibrary-01_/_-yang-cbor-12_review?=
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2020 13:30:10 -0000

Hello Esko,

Thank you for your review and your comments! They truly help us improve
this document. Please find my answers below (prefixed with [IP]). Note that
the diff after handing your comments and those of Juergen Schoenwaelder can
be found at [1].

Best regards,
Ivaylo

[1]:
https://tools.ietf.org/rfcdiff?url1=draft-ietf-core-yang-cbor&url2=http://core-wg.github.io/yang-cbor/draft-ietf-core-yang-cbor-latest.txt
On Mon, Mar 30, 2020 at 2:24 PM Esko Dijk <esko.dijk@iotconsultancy.nl>
wrote:

> Hello CoRE,
>
> I did a review of draft-ietf-core-yang-cbor-12 and some comments are
> below. I do support the publication of this document but feel a few updates
> of minor items are still needed! See the items below:
>
> Section 3: "This specification supports two type of CBOR keys" -> two
> types of CBOR keys
>

[IP]: Fixed

Section 3: This root CBOR map is provided only as a typical usage example
> and is
>    not part of the present encoding rules.  Only the value within this
> CBOR map is compulsory.
> -> Not fully clear to me, how can an example be compulsory? Other values
> within the CBOR map could also be used, right? Also it wasn't fully clear
> to me how the data structure would otherwise be encoded if not with a root
> CBOR map. Maybe good to give an example of how it would otherwise be
> encoded if not with a root CBOR map!
>

[IP]: This stems from the separation between CoMI and YANG to CBOR - in
CoMI we have complete examples with the complete encoding of elements that
were requested, whereas here we provide only instructions how particular
elements need to be encoded - regardless of the fact that they might be a
part of a bigger payload or part of a protocol that handles the external
wrapping. Where this causes issues is SID deltas for example - without the
wrapping elements, it would not be clear how that would work. Please let us
know if you could think of a better way to express this.


> Section 3.1: Table 1 uses both uppercase and lowercase in the last column
> for the CBOR encoding. Best practice is to use either uppercase or
> lowercase for hexadecimal, but not mixed I think.
>

[IP]: Fixed


> Section 4.5.2: "example-port: example-port-fault" :
> -> space after ':' is to be removed. At least I think a space isn't
> allowed there.
>

[IP]: Fixed


> Section 3.3 / 4.5.1 "as follow"
> -> as follows
>

[IP]: Fixed


> Section 4.6: "data items tagged with one of the tag listed"
> -> the tags listed
>

[IP]: Fixed

Section 4.6: the "anyxml bar" definition should have "# SID 60000" comment,
> like for the other YANG definitions that have a "# SID ....." comment .
>

[IP]: Fixed


> Section 5.1: "YANG template encoded using SIDs are carried in "
> -> YANG templates ...
>

[IP]: Changed request from Juergen Schoenwaelder made this look like:

The yang-data extensions encoded using SIDs are carried in a CBOR map
containing a single item pair. The key of this item is set to the SID
assigned to the YANG template container, the value is set the CBOR encoding
of this container as defined in {{container}}.



> Section 5.2 similar sentence as 5.1 above
>

[IP]: Fixed similarly to the above one.


> Section 6.6 example:
>   type union {
>      type int32;
>      type enumeration {
>        enum "unbounded";
>      }
>    }
>
> unclear why "unbounded" is within quotes? The CBOR encoding of this
> example encodes the word 'unbounded' without the quotes, which would look
> like:
>    type enumeration {
>        enum unbounded;
>      }
> An open question to me is whether RFC 7950 section 9.12.4 has the word
> unbounded in quotes on purpose, or by mistake. None of the other examples
> of enum statements use the quotes! Why would this example suddenly use the
> quotes? In any case if quotes are used then per RFC 7950 definitions the
> quotes must also be encoded as part of the yang-string.
>

[IP]: I believe that was copied indeed from RFC 7950 as it is. I could not
find a reason why it should be with quotes, so I removed them as you
suggested.


> Section 6.6: Tag 44 use - in section 8.1, the table states that the tag
> must mark a data item of type unsigned integer. Which is not the case here,
> it marks a string.
>

[IP]: It should be a "text string" in Section 8.1. This has changed
relatively recently and obviously we overlooked the values in the table.
Fixed now


> Section 6.7: similar to section 6.6, the tag 43 mentions data item "byte
> string" in Section 8.1 while in section 6.7 it is followed by a text string.
> Just to be clear: if a 'bits' type is encoded, it looks like the tag 43 is
> only used if followed by a text string as in 43("under-repair critical") ?
> Or should a tag 43 also be used in case a CBOR byte string follows?
> E.g. 43(h'06') instead of h'06' ? That doesn't seem to be the intention in
> the current text.
>

[IP]: It should be a "text string" in Section 8.1. Fixed now. My reading of
this is that the tag 43 can only be used inside unions.

Section 8.1: could indicate here what the column 'Data Item' means. E.g.
> make clear that the CBOR data item following the tag listed in the first
> column cell must be of one of the CBOR data types listed in the second
> column cell.
>

[IP]: This is the column title used in section 7.2 of RFC7049. If you
believe that the sentence right before the table is not clear enough,
please let us know how we could improve it.

Best regards
> Esko
>
>
> IoTconsultancy.nl  |  Email/Skype: esko.dijk@iotconsultancy.nl
>
>
> -----Original Message-----
> From: core <core-bounces@ietf.org> On Behalf Of Carsten Bormann
> Sent: Monday, March 9, 2020 14:05
> To: core <core@ietf.org>
> Cc: netmod@ietf.org
> Subject: [core] πŸ”” WG Last Call of CORECONF drafts:
> draft-ietf-core-yang-cbor-12, -sid-11, -comi-09, -yang-library-01
>
> It took us a long time to get the four CORECONF drafts in sync,
> but now we are ready for WGLC.
>
> This starts a working group last call for
> β€” draft-ietf-core-yang-cbor-12
> β€” draft-ietf-core-sid-11
> β€” draft-ietf-core-comi-09
> β€” draft-ietf-core-yang-library-01
>
> ending on
>
>         24:00 UTC on Tuesday, March 31, 2020.
>
> (This includes some extra time for the IETF week and for cross-WG
> coordination.)
>
> This WGLC is copied to the netmod WG mailing list; please do have a look
> at these drafts as they are slated to become a part of the greater
> YANG/NETCONF/RESTCONF family.  We intend the discussion to be on the
> CoRE mailing list, but if you find a fundamental issue with YANG or
> RESTCONF, feel free to discuss that on netmod instead.
>
> Please start a new email thread for each major issue that will need
> discussion and make sure the subject line includes the draft name and
> some sort of name for the issue.  (Minor issues such as typos can also
> be sent to the authors.)
>
> If you read the draft and think it looks fine, please send a one line
> email to the list or to the chairs letting us know that so we can get
> a feel of how broad the review has been.
>
> (To reviewers and authors:)  If you are aware of any patent claims that
> might apply to systems that implement these drafts, please review BCP 78
> and BCP 79 and make any appropriate IPR declaration before the last-call
> ends. If you are not sure whether you need to make a declaration or not,
> please talk to the chairs and we will help.
>
> Grüße, Carsten
>
> _______________________________________________
> core mailing list
> core@ietf.org
> https://www.ietf.org/mailman/listinfo/core
> _______________________________________________
> core mailing list
> core@ietf.org
> https://www.ietf.org/mailman/listinfo/core
>