[core] Comments on draft-hartke-t2trg-coral-reef-03
Jim Schaad <ietf@augustcellars.com> Fri, 22 November 2019 23:04 UTC
Return-Path: <ietf@augustcellars.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B6F21120137; Fri, 22 Nov 2019 15:04:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6128KMNCLUhx; Fri, 22 Nov 2019 15:04:08 -0800 (PST)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 94C161200CD; Fri, 22 Nov 2019 15:04:07 -0800 (PST)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 15:04:01 -0800
From: Jim Schaad <ietf@augustcellars.com>
To: draft-hartke-t2trg-coral-reef@ietf.org
CC: core@ietf.org
Date: Fri, 22 Nov 2019 15:03:59 -0800
Message-ID: <048701d5a189$2177f9c0$6467ed40$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdWhCDKBlX3WBHGrTFWkT4O8WhwjAQ==
Content-Language: en-us
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/mXkuhS5kTbJLPm_53b2S7oMMCAM>
Subject: [core] Comments on draft-hartke-t2trg-coral-reef-03
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Nov 2019 23:04:10 -0000
I have sent this to core rather than T2TRG because I think that it is more appropriate. * It would be nice to add a note to the top of the document pointing to the repository you are using, if you are using one. * I am having a problem with you saying that you are defining a new well-known resource. "/.well-known/core" has already been defined. It would be better to say you are expanding the capabilities I think. * In the first example in the document (page 4), I believe that you should be able to return "ct TBD3" as part of the "/sensors" resource. This may or may not be covered by this document so I am not sure if you think it would be allowable or not. Specifically, I believe that any place you can currently use application/link-format you should be able to use REEF * At the end of section 2.1, second to last paragraph - The last clause in the last sentence has a problem with matching the pronoun back to the correct subject. On first read I matched one back to schema not to the details. I think that use of a semicolon would fix this problem. * In section 2.2, the registration interface is currently missing the query parameters. The big ones would be ep (endpoint name) and d (domain), you should not need base because that can be represented in the CoRAL document. About the time I got to section 5.2 on the second pass, I realized that you did not deal with endpoint registration and queries at all. This is a needed feature. * There should however be a statement that the link for an rd-item when registering MUST NOT only be a path comment. * I think there should be a statement that only the first base directive can include schema + authority information. This is because you are only supposed to register resources for one entity at a time. * Section 3 - I am not sure you want to use the word "identifier" in the description of title. That is not normally how I think of a title. I would probably also use "title" rather than "label" in both paragraphs. * Section 3 - you need to give me something to better distinguish between #type and #ct as they both seem to say the same thing to me. * Section 3 - you need to say something about how to deal with #ct for multiple values. I am not sure about #if * Section 3 - I think that you should have all of the tags in this section. For example rd-item and rd-unit. * General - I know that this is supposed to be what is going to happen, an ?rt= query option is going to be the same as reef#rt, but I don't think there is anyplace in this document that makes that statement. Jim
- [core] Comments on draft-hartke-t2trg-coral-reef-… Jim Schaad
- Re: [core] Comments on draft-hartke-t2trg-coral-r… Klaus Hartke
- Re: [core] Comments on draft-hartke-t2trg-coral-r… Jim Schaad
- Re: [core] Comments on draft-hartke-t2trg-coral-r… Klaus Hartke