[core] Iotdir early review of draft-ietf-core-conditional-attributes-06
Ines Robles via Datatracker <noreply@ietf.org> Sat, 04 February 2023 02:17 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FC55C1575B4; Fri, 3 Feb 2023 18:17:00 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ines Robles via Datatracker <noreply@ietf.org>
To: iot-directorate@ietf.org
Cc: core@ietf.org, draft-ietf-core-conditional-attributes.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.8.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <167547702031.40296.17351878084954392687@ietfa.amsl.com>
Reply-To: Ines Robles <mariainesrobles@googlemail.com>
Date: Fri, 03 Feb 2023 18:17:00 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/vSrEc-59XQeYf3V-LoMNTJ-uPs8>
Subject: [core] Iotdir early review of draft-ietf-core-conditional-attributes-06
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Feb 2023 02:17:00 -0000
Reviewer: Ines Robles Review result: Almost Ready I am the assigned IoT-Directorate reviewer for this draft. Please treat these comments just like any other last call comments. Document: draft-ietf-core-conditional-attributes-06 Reviewer: Ines Robles Summary: This specification defines Conditional Notification and Control Attributes that work with CoAP Observe. It is well written and clear to understand. Issue: 1- The draft states the Intended status as Informational, Should the Intended status be: Standards Track? Nits/Questions: 1- The IANA Considerations should reference the protocol category group (core-parameters?) [https://www.iana.org/assignments/core-parameters/core-parameters.xhtml] 2- Trying to run idnits from the URL, using https://author-tools.ietf.org/idnits I get,"{"error":"Opening and ending tag mismatch: li line 1195 and style, line 1203, column 9 (draft-ietf-core-conditional-attributes-06.html, line 1203)"}" 3- Section 3.1.3: "equal to st" --> "equal to c.st"? 4- How it is handle the case of a client wants to cancel an existing conditional attribute? 5- I understand that Multiple conditional attributes in a query component have their relationship as "AND", right? Then, is it possible to have multiple conditional attributes with "OR" relationships? Would it make sense? 6- [if applicable] should (previous work?) [https://datatracker.ietf.org/doc/html/draft-li-core-conditional-observe-05] be mentioned in the References and Introduction, or it is not at all related? Thank you for this document, Ines.
- [core] Iotdir early review of draft-ietf-core-con… Ines Robles via Datatracker