[COSE] Re: WGLC for draft-ietf-cose-dilithium
Lucas Prabel <lucas.prabel@huawei.com> Thu, 21 November 2024 10:57 UTC
Return-Path: <lucas.prabel@huawei.com>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2E76C18DB95 for <cose@ietfa.amsl.com>; Thu, 21 Nov 2024 02:57:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.645
X-Spam-Level:
X-Spam-Status: No, score=-1.645 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, HTML_OBFUSCATE_05_10=0.26, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ckqy8KEvuvHZ for <cose@ietfa.amsl.com>; Thu, 21 Nov 2024 02:57:22 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 998DFC18DB8E for <cose@ietf.org>; Thu, 21 Nov 2024 02:57:22 -0800 (PST)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XvFVs2d1Nz6K94N; Thu, 21 Nov 2024 18:55:01 +0800 (CST)
Received: from frapeml500002.china.huawei.com (unknown [7.182.85.205]) by mail.maildlp.com (Postfix) with ESMTPS id 06C5D140133; Thu, 21 Nov 2024 18:57:21 +0800 (CST)
Received: from frapeml500004.china.huawei.com (7.182.85.22) by frapeml500002.china.huawei.com (7.182.85.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 21 Nov 2024 11:57:20 +0100
Received: from frapeml500004.china.huawei.com ([7.182.85.22]) by frapeml500004.china.huawei.com ([7.182.85.22]) with mapi id 15.01.2507.039; Thu, 21 Nov 2024 11:57:20 +0100
From: Lucas Prabel <lucas.prabel@huawei.com>
To: Michael Jones <michael_b_jones@hotmail.com>
Thread-Topic: WGLC for draft-ietf-cose-dilithium
Thread-Index: Ads6oozdEnJ3zgVJRKavu1HOkrIHqwBXvCOw
Date: Thu, 21 Nov 2024 10:57:20 +0000
Message-ID: <ebf43c66724546c5919a3945001b21a4@huawei.com>
References: <PH7PR02MB929246D008043965D35090BAB7202@PH7PR02MB9292.namprd02.prod.outlook.com>
In-Reply-To: <PH7PR02MB929246D008043965D35090BAB7202@PH7PR02MB9292.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.53.28]
Content-Type: multipart/alternative; boundary="_000_ebf43c66724546c5919a3945001b21a4huaweicom_"
MIME-Version: 1.0
Message-ID-Hash: 5AE7EIMIN77RXQAFL4DJYFVJKCCCZUO7
X-Message-ID-Hash: 5AE7EIMIN77RXQAFL4DJYFVJKCCCZUO7
X-MailFrom: lucas.prabel@huawei.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-cose.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "cose@ietf.org" <cose@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [COSE] Re: WGLC for draft-ietf-cose-dilithium
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/04ROpwVJpkKbV62JJHim3eGNopo>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Owner: <mailto:cose-owner@ietf.org>
List-Post: <mailto:cose@ietf.org>
List-Subscribe: <mailto:cose-join@ietf.org>
List-Unsubscribe: <mailto:cose-leave@ietf.org>
Hello, I am pleased this document exists and think support for ML-DSA in JOSE and COSE will prove useful, especially now that ML-DSA is being specified by more and more working groups. After reviewing it, here are my comments: Section 3 - typo: “paramaterized” --> “parameterized” - In Table 2, I would call the 2nd column “value” instead of “alg”. Section 4 - I agree with Neil Madden and think this section is a bit underspecified. In particular, I think it needs precise specification of the Key Parameters associated with AKP. - In the given COSE example (Figure 2), key parameters are called “pub” and “priv”, but called “public_key” and “private_key” in Section 8.14 and 8.15. - typo “the registration of the following algorithms in [IANA.cose]” → “the registration of the following key type in [IANA.cose]” Section 5 - I think the first sentence can appear a bit confusing in its use of "private key" as the term refers to two different things in its 2 occurrences (in the 1st one, "private keys" encompasses both the seed and its expanded representation, while in the 2nd, it only refers to the full expanded key). FIPS 204 seems to be a bit clearer by using "private key" exclusively to mean the full expanded private key. Other I would like this document to clarify its stance on the use of HashML-DSA from FIPS 204. Recent IETF discussions suggest moving away from including HashML-DSA as an option, focusing instead solely on ML-DSA without pre-hashing. For this document, while I think it was agreed that any pre-hash specifications would be detailed in a separate draft if needed, I think we should add a short sentence stating that this draft doesn't include the pre-hash option. Besides, I think we should add some words about how to handle the ML-DSA context string. Thanks for your work, Best, Lucas From: Michael Jones <michael_b_jones@hotmail.com> Sent: mardi 19 novembre 2024 17:48 To: cose@ietf.org Subject: [COSE] WGLC for draft-ietf-cose-dilithium Hi all, This message starts the Working Group Last Call (WGLC) for https://www.ietf.org/archive/id/draft-ietf-cose-dilithium-04.html (ML-DSA for JOSE and COSE), as was discussed at IETF 121 in Dublin. The WGLC will run for two weeks, ending on Tuesday, December 3, 2024. Please review and send any comments or feedback to the working group. Even if your feedback is “this is ready for publication”, please let us know. Thank you, -- Mike and Ivaylo, COSE Chairs
- [COSE] WGLC for draft-ietf-cose-dilithium Michael Jones
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Michael Prorock
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Brian Campbell
- [COSE] Re: [jose] Re: WGLC for draft-ietf-cose-di… Neil Madden
- [COSE] Re: [jose] Re: WGLC for draft-ietf-cose-di… Orie Steele
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Russ Housley
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Orie Steele
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Lucas Prabel
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Orie Steele
- [COSE] Re: WGLC for draft-ietf-cose-dilithium Lucas Prabel