Re: [COSE] Benjamin Kaduk's Yes on draft-ietf-cose-rfc8152bis-struct-14: (with COMMENT)

Carsten Bormann <cabo@tzi.org> Mon, 19 October 2020 21:31 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5CCE3A0AA9; Mon, 19 Oct 2020 14:31:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.002
X-Spam-Level:
X-Spam-Status: No, score=0.002 tagged_above=-999 required=5 tests=[RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7lryDJKd_gXK; Mon, 19 Oct 2020 14:31:14 -0700 (PDT)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05DF23A0AA3; Mon, 19 Oct 2020 14:31:13 -0700 (PDT)
Received: from [192.168.217.118] (p548dcc60.dip0.t-ipconnect.de [84.141.204.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4CFVLR4V44zyVf; Mon, 19 Oct 2020 23:31:11 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <20201007161014.GP89563@kduck.mit.edu>
Date: Mon, 19 Oct 2020 23:31:11 +0200
Cc: Matthew Miller <linuxwolf+ietf@outer-planes.net>, The IESG <iesg@ietf.org>, draft-ietf-cose-rfc8152bis-struct@ietf.org, cose-chairs@ietf.org, cose <cose@ietf.org>
X-Mao-Original-Outgoing-Id: 624835871.1018341-8e6c33b87161084e77e083806ecfb386
Content-Transfer-Encoding: quoted-printable
Message-Id: <E52107DF-E107-4997-9D2B-4EEAD0B4E9F6@tzi.org>
References: <160204883573.26847.11501294022082441021@ietfa.amsl.com> <DA9F6635-5773-4921-ACCE-B0BDCB6C06FF@tzi.org> <4920FB90-3F45-4050-8205-2B09D4B84265@outer-planes.net> <20201007161014.GP89563@kduck.mit.edu>
To: Benjamin Kaduk <kaduk@MIT.EDU>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/8d-KLTiT2Yj8oSiqbmYBIy_Fumg>
Subject: Re: [COSE] Benjamin Kaduk's Yes on draft-ietf-cose-rfc8152bis-struct-14: (with COMMENT)
X-BeenThere: cose@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cose>, <mailto:cose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose/>
List-Post: <mailto:cose@ietf.org>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cose>, <mailto:cose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2020 21:31:17 -0000

One terribly niggly nit:
The examples in C.3.3 and C.5.4 say “ECHD” in a comment where they need to say “ECDH”.

(This is also a trivial errata report on the same appendixes in RFC 8152 that I haven’t written up yet.)

Grüße, Carsten