Re: [Curdle] Warren Kumari's No Objection on draft-ietf-curdle-ssh-curves-10: (with COMMENT)

[Ron Frederick <[e-mail]>]

On Sep 3, 2019, at 10:27 AM, Mark D. Baushke <mdb=[e-mail]> wrote:
> Regardin the key agreement abort. Here is the revised text...
> 
>        ...elided...
>                    Alternative implementations of these functions
>        SHOULD abort when either input forces the shared secret to one
>        of a small set of values, as described in Section 7 of
>        [RFC7748].  Clients and servers MUST fail the key exchange if
>        the length of the received public keys are not the expected
>        lengths. An abort for these purposes is defined as a
>        disconnect (SSH_MSG_DISCONNECT) of the session and SHOULD use
>        the SSH_DISCONNECT_KEY_EXCHANGE_FAILED reason for the message
>        <xref target="IANA-REASON"/>.
>        ...elided...
> 
> Where IANA-REASON is an information reference to the URL
> 
>    http://www.iana.org/assignments/ssh-parameters/ssh-parameters.xhtml#ssh-parameters-3
> 
> (which extended the RFC4250 and RFC4253 number space to include private
> values).

The middle sentence here about failing the key exchange due to the length of the public keys kind of breaks up the references to “abort” here. I think it might read better as something like:

                   Alternative implementations of these functions
       SHOULD abort when either input forces the shared secret to one
       of a small set of values, as described in Section 7 of
       [RFC7748].  Clients and servers MUST also abort if
       the length of the received public keys are not the expected
       lengths. An abort for these purposes is defined as a
       disconnect (SSH_MSG_DISCONNECT) of the session and SHOULD use
       the SSH_DISCONNECT_KEY_EXCHANGE_FAILED reason for the message
       <xref target="IANA-REASON"/>.

That way, the paragraph consistently uses the “abort” terminology for both types of failures, and then goes on to explain what “abort” means.
-- 
Ron Frederick
[e-mail]