[Curdle] Review of draft-ietf-curdle-cms-ecdh-new-curves-03
Jim Schaad <ietf@augustcellars.com> Mon, 10 April 2017 17:23 UTC
Return-Path: <ietf@augustcellars.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C86941296CD; Mon, 10 Apr 2017 10:23:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=augustcellars.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v8xWGMpZrdZ7; Mon, 10 Apr 2017 10:23:35 -0700 (PDT)
Received: from mail4.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 028BE1296B3; Mon, 10 Apr 2017 10:23:35 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: en-us
DKIM-Signature: v=1; a=rsa-sha256; d=augustcellars.com; s=winery; c=simple/simple; t=1491845011; h=from:subject:to:date:message-id; bh=SKtsACx9jZC5HEHSx5W/jNXJLbWa0mznLggpGzYuOyQ=; b=CSFBz1Tyxzwd6gNQpPPmVzkefoHPpKyWOBIhUO2/ZM1gShFhjhFNRSpDpCFhe1w+2ZN1XaKBaay qa8kJOMA5f/PeY6B+s8KaWV9EYVcn7AVWht6KFRH1L5HmutTV3LZNOBson6x/oj2FWtS1Hk/W2WvE RyR/gZDcujxWi43iQcoigBnXot3xxIJ8oJITNQiIUJb9/33IxwZ1eth835FuEoVtXah+mq3xB2YEs CiAK14NswpOnbD74r4u2f1iHgWt/Monb1bq6AicxCrkpBQedoIDSZ3XoYHKbyTUpc9btt2rnPrNHl KLf402W1V1+5skUgRwdK1A/aRL8qYxCSd3gA==
Received: from mail2.augustcellars.com (192.168.1.201) by mail4.augustcellars.com (192.168.1.153) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Mon, 10 Apr 2017 10:23:31 -0700
Received: from hebrews (192.168.0.98) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Mon, 10 Apr 2017 10:23:29 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: draft-ietf-curdle-cms-ecdh-new-curves@ietf.org
CC: 'curdle' <curdle@ietf.org>
Date: Mon, 10 Apr 2017 10:23:28 -0700
Message-ID: <002801d2b21f$2c44ea90$84cebfb0$@augustcellars.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdKyFqav7LsDTXj9QJqFe0A7HoDUag==
X-Originating-IP: [192.168.0.98]
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/LC2PBwgmG2RKlbLaeX7c2Rwg7z0>
Subject: [Curdle] Review of draft-ietf-curdle-cms-ecdh-new-curves-03
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Apr 2017 17:23:37 -0000
This draft is not ready to progress. Jim Section 3.2 - This section is wrong. It is using the wrong structure. idecPublicKey is wrong. These are all nice to haves, but I don't really care if they don't get done. I would prefer that the check of the all-zero output in section 2.0 be a SHOULD rather than a MAY. Section 2 last paragraph - add network order to the string on representing the number Section 2.1 - I don't know if you should say that the left most bits of the result are used. I know that is correct so I have a problem reading it any other way.