Re: [Curdle] Warren Kumari's No Objection on draft-ietf-curdle-ssh-curves-10: (with COMMENT)

Ron Frederick <ronf@timeheart.net> Tue, 03 September 2019 16:53 UTC

Return-Path: <ronf@timeheart.net>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3BF41208E7 for <curdle@ietfa.amsl.com>; Tue, 3 Sep 2019 09:53:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=timeheart.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KniLgXzEZePq for <curdle@ietfa.amsl.com>; Tue, 3 Sep 2019 09:53:38 -0700 (PDT)
Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71DBB120904 for <curdle@ietf.org>; Tue, 3 Sep 2019 09:53:37 -0700 (PDT)
Received: by mail-pf1-x432.google.com with SMTP id h195so4592727pfe.5 for <curdle@ietf.org>; Tue, 03 Sep 2019 09:53:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timeheart.net; s=mail; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=V5i2/gxPK0NPjAQoFxheX+2cMlSvgx2LysHnlyQ40SE=; b=Ee+rEedRDI21aIo4v9YSRnP1OwglbyrYh0n/u7MPMKheZ1nSq98IB5UTa5Z/S3MUvT OT1z41jvwgp2ST7mUZ9sjmq+i1Tt/raoieC/EWz6yuJk9U9tPyQMz985k5nv8mTE29p3 69mFJQD4sD3Rqpkf/q9QfC09rRTwDhqFexbj8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=V5i2/gxPK0NPjAQoFxheX+2cMlSvgx2LysHnlyQ40SE=; b=NlFnw61y5fJLGQmKBe9bV0n33Q31U031C81Ol5xCyYEitx5E2gJxEVVgtRQmXPRiy2 9/NFOzRWU3VJ8Bo/xtMJBQAv0j2eJjq/oe3vFybnMtpQhmUSzqQxfXMKAUt2wZ6fSTq1 48+qP5tQdgv2zkP6Z/ifgBO+iTtflTuySlsSdrm3/JPQYV1uKHNhYVO53Gijr9LkEA6N m9tR+catk3McLHDJgievZYER+WgkKc5qGAzBsD2/fxW/aWDqoFPckSeXSoZsa7+ZHZAJ LphbawzjopQg1zphkzXPh9l3Bk2ucvJm2mLS2e62VB2JmJbxmPPwjIxxTMnbs674sBvz OZ7Q==
X-Gm-Message-State: APjAAAV4Q6Ds/5Xzz7ee12gXyoW9lAoyyKLL2A+ZHgX0K1S4aOzjuJYl F2qLiwmNbRpteNTSHigMWR9KRA==
X-Google-Smtp-Source: APXvYqyHK7ZICB5RRjQK3K7mg0Xce69YDztmK6ivlkswBGMa9EVDQSV53/SpEYVmcsbAtJJ9g+oHlA==
X-Received: by 2002:a62:1810:: with SMTP id 16mr40256102pfy.171.1567529616963; Tue, 03 Sep 2019 09:53:36 -0700 (PDT)
Received: from [10.17.102.191] ([155.64.23.53]) by smtp.gmail.com with ESMTPSA id f12sm17287716pgo.85.2019.09.03.09.53.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Sep 2019 09:53:34 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Ron Frederick <ronf@timeheart.net>
In-Reply-To: <CAHw9_iJk8uMi=2iNJsyQOzixA6LjU6KvL0bs5y1qD0Frm_nxOw@mail.gmail.com>
Date: Tue, 03 Sep 2019 09:53:32 -0700
Cc: Aris Adamantiadis <aris@badcode.be>, curdle@ietf.org, draft-ietf-curdle-ssh-curves@ietf.org, curdle-chairs@ietf.org, Daniel Migault <daniel.migault@ericsson.com>, The IESG <iesg@ietf.org>, "Mark D. Baushke" <mdb@juniper.net>
Content-Transfer-Encoding: quoted-printable
Message-Id: <91350842-B654-4037-8236-707E0BAD4839@timeheart.net>
References: <156752357052.9594.7566059219592586096.idtracker@ietfa.amsl.com> <23919.1567526907@contrail-ubm16-mdb.svec1.juniper.net> <27bf18c7-7028-dc2a-54d6-2f98f98e7328@badcode.be> <CAHw9_iJk8uMi=2iNJsyQOzixA6LjU6KvL0bs5y1qD0Frm_nxOw@mail.gmail.com>
To: Warren Kumari <warren@kumari.net>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/VLP-G6u631gxThfCT44szQE2YoQ>
Subject: Re: [Curdle] Warren Kumari's No Objection on draft-ietf-curdle-ssh-curves-10: (with COMMENT)
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Sep 2019 16:53:42 -0000

On Sep 3, 2019, at 9:46 AM, Warren Kumari <warren@kumari.net> wrote:
> On Tue, Sep 3, 2019 at 12:42 PM Aris Adamantiadis <aris@badcode.be> wrote:
>> Le 03/09/2019 à 18:08, Mark D. Baushke a écrit :
>> "An abort for these purposes is defined as a disconnect of the session
>> with an appropriate SSH "protocol error" for the fault provided to or
>> by the client. "
>> 
>> Fair enough -- but would it be possible to point at where people can
>> go find out what the "appropriate SSH protocol error" is?
>> 
>> Protocol error messages to abort are in Section 11.1 of RFC4253. and the
>> most likely code would be SSH_DISCONNECT_KEY_EXCHANGE_FAILED (reason
>> code 3).
>> 
>> I was going to suggest this.
>> 
> 
> That'd work for me, or even something like "An abort for these
> purposes is defined as a disconnect of the session with an appropriate
> SSH "protocol error" (see Section 11.1 of RFC4253) for the fault
> provided to or by the client.", but I think your text is better…

One thing to keep in mind here is that the abort isn’t limited to only coming from the client. Either side could receive a public key blob from the peer that triggers an all-zeroes shared key, So, this check should be done by both the client and server, and either of them could end up triggering this abort.
-- 
Ron Frederick
ronf@timeheart.net