Re: [Curdle] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)

Magnus Nyström <magnusn@gmail.com> Sat, 17 December 2016 17:14 UTC

Return-Path: <magnusn@gmail.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92F2E129866; Sat, 17 Dec 2016 09:14:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.52
X-Spam-Level:
X-Spam-Status: No, score=-1.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xHqSxy3qylc7; Sat, 17 Dec 2016 09:14:54 -0800 (PST)
Received: from mail-yw0-f196.google.com (mail-yw0-f196.google.com [209.85.161.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42A981296D6; Sat, 17 Dec 2016 09:14:54 -0800 (PST)
Received: by mail-yw0-f196.google.com with SMTP id a10so6052839ywa.1; Sat, 17 Dec 2016 09:14:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LbAV1cxEwPPyTUwS9uuFVdb9XbKSn4yB9LbDqrvBaiM=; b=D5XZW4RCKNwNeQKomO0Fn3vq8B6ThYMPSaJqQDs0nZaRQMystwZfeOpDrwtm50tVry kaRxolf4FJvsOKz+qoj1l1EAYnAkIWjWliKUx5JkzQX8sh3YX1C9n0yyPDq0yMbVJKIw crCm4zUlzIgYtWrp++RfrTs+tXgw5qyCGjumUgz0WndCqQ6qGSOqv/ElQ1hY8zbEhBlH 5c0WZBopfZxc7lEMMjSnNs5L3jPKPFi/bHfyNuwnVOaCNzscmwZEykI1HGfBYS6f1M8N 6UalcB7qw9SPm+nOqZpvMC9u1IKjurvoOxgq7NcQzWFu0BvnMejBrDHN0uAt1hZARuvg SjrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LbAV1cxEwPPyTUwS9uuFVdb9XbKSn4yB9LbDqrvBaiM=; b=SEUM5IGQM02x4uFWWZn738es1epr6Zvupjkr5im4e4Z3vlApP585qplvKx2+QUN2Ya bmhs8fRMjv6HGzfYa2ivoZUjTYaonc1NNjHFg5+3Q6EY7ems5k1EtODYWL8ghWY16nqA YHtqkJhMjFWUchHJRAFdSFIZFDOXb9+9Q8eB2ZI8/JVDvQzux+q//kfoRtsvclsPxPPp Hu981HXPkDXG5ED7Bjc5497Iy2PtgPF2cx3SGxbp/866o1//6lbk8kMlVc9bqo7ZgHBp kD2IF4XCGp3/74QQsTpmcG5sUYslAv/SkuWb9PBByFWZAOTQqkdMZeIEwQgMTziYCCow F7Sg==
X-Gm-Message-State: AKaTC030woaZfflgUF2m2K+w/Jn8w9kDH1sIEDSxTCwAhS+ChYmaaetGbnf6EY1aOYn25UQM6Oxp6Yra9PyO+w==
X-Received: by 10.129.90.67 with SMTP id o64mr6518158ywb.188.1481994833385; Sat, 17 Dec 2016 09:13:53 -0800 (PST)
MIME-Version: 1.0
Received: by 10.37.195.195 with HTTP; Sat, 17 Dec 2016 09:13:52 -0800 (PST)
In-Reply-To: <CAFgnS4UYNSUHW-3E=oZY-p97FbgufxjCNVbTiaXt7bQOCD0-Gw@mail.gmail.com>
References: <CADajj4aOGCi1nTzTSP4zAEf-3pa0M78pFj6Tw3QBLq-XuaABbA@mail.gmail.com> <1432493802.4506.1481535515981.JavaMail.zimbra@nic.cz> <2109497203.7399.1481958107415.JavaMail.zimbra@nic.cz> <CAFgnS4UYNSUHW-3E=oZY-p97FbgufxjCNVbTiaXt7bQOCD0-Gw@mail.gmail.com>
From: =?UTF-8?Q?Magnus_Nystr=C3=B6m?= <magnusn@gmail.com>
Date: Sat, 17 Dec 2016 09:13:52 -0800
Message-ID: <CADajj4YPM5AtTR7DdYTAuK-cDxmZdA=nqA1qTzScSpFwcc8NNA@mail.gmail.com>
To: Dan Romascanu <dromasca@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/h1WvrdovODcJSHAhc02qk4RvttU>
Cc: ops-dir@ietf.org, ietf <ietf@ietf.org>, secdir <secdir@ietf.org>, gen-art <gen-art@ietf.org>, curdle <curdle@ietf.org>, Tim Chown <Tim.Chown@jisc.ac.uk>, draft-ietf-curdle-dnskey-eddsa.all@ietf.org, =?UTF-8?B?T25kxZllaiBTdXLDvQ==?= <ondrej.sury@nic.cz>
Subject: Re: [Curdle] Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was: Secdir review of draft-ietf-curdle-dnskey-eddsa-02)
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Dec 2016 17:14:55 -0000

Same here. Thank you!
/M

On Fri, Dec 16, 2016 at 11:11 PM, Dan Romascanu <dromasca@gmail.com> wrote:
> Thank you for addressing my comments.
>
> Regards,
>
> Dan
>
>
> On Sat, Dec 17, 2016 at 9:01 AM, Ondřej Surý <ondrej.sury@nic.cz> wrote:
>>
>> Hi all,
>>
>> the IETF review has ended, so I have uploaded -03 version.
>>
>> Magnus, Dan,
>>
>> the -03 version addresses all your comments.
>>
>> Tim,
>>
>> I left the irtf documents in Normative as per Stephan's comments.
>>
>> I believe that Section 8 correctly references IANA registry:
>>
>> http://www.iana.org/assignments/dns-sec-alg-numbers/dns-sec-alg-numbers.xhtml
>> by its name.
>>
>> The paragraph with nit has been removed altogether per Magnus's request.
>>
>> Thank you all very much for the reviews.
>>
>> Cheers,
>> --
>>  Ondřej Surý -- Technical Fellow
>>  --------------------------------------------
>>  CZ.NIC, z.s.p.o.    --     Laboratoře CZ.NIC
>>  Milesovska 5, 130 00 Praha 3, Czech Republic
>>  mailto:ondrej.sury@nic.cz    https://nic.cz/
>>  --------------------------------------------
>>
>> ----- Original Message -----
>> > From: "Ondřej Surý" <ondrej.sury@nic.cz>
>> > To: "Magnus Nyström" <magnusn@gmail.com>om>, "Dan Romascanu"
>> > <dromasca@gmail.com>
>> > Cc: "secdir" <secdir@ietf.org>rg>, "draft-ietf-curdle-dnskey-eddsa"
>> > <draft-ietf-curdle-dnskey-eddsa@ietf.org>rg>, "gen-art"
>> > <gen-art@ietf.org>rg>, "ietf" <ietf@ietf.org>rg>, "curdle-chairs"
>> > <curdle-chairs@ietf.org>rg>, "curdle" <curdle@ietf.org>
>> > Sent: Monday, 12 December, 2016 10:38:35
>> > Subject: Re: Review of draft-ietf-curdle-dnskey-eddsa-02 (Als was:
>> > Secdir review of draft-ietf-curdle-dnskey-eddsa-02)
>>
>> > Magnus and Dan,
>> >
>> > thanks for the review.
>> >
>> > Magnus, you are right, I have removed the first full paragraph
>> > about "security properties" from Security Considerations
>> > from my git version as the security properties of EdDSA
>> > are better described in Normative references anyway.
>> >
>> >
>> > https://gitlab.labs.nic.cz/labs/ietf/commit/7b52c8e2bbe44042a279a81b960270fdd103d9a2
>> >
>> > Dan,
>> >
>> > good catches, I fixed the nits in the git:
>> >
>> >
>> > https://gitlab.labs.nic.cz/labs/ietf/commit/bbfc7ce43fb1f46c91fb7f5de564d907d035aadf
>> >
>> > I would be happy to upload next revision after Last Call
>> > is finished or just let the RFC editors to fix it.
>> >
>> > Cheers,
>> > --
>> > Ondřej Surý -- Technical Fellow
>> > --------------------------------------------
>> > CZ.NIC, z.s.p.o.    --     Laboratoře CZ.NIC
>> > Milesovska 5, 130 00 Praha 3, Czech Republic
>> > mailto:ondrej.sury@nic.cz    https://nic.cz/
>> > --------------------------------------------
>> >
>> > ----- Original Message -----
>> >> From: "Magnus Nyström" <magnusn@gmail.com>
>> >> To: secdir@ietf.org, "draft-ietf-curdle-dnskey-eddsa"
>> >> <draft-ietf-curdle-dnskey-eddsa@ietf.org>
>> >> Sent: Monday, 12 December, 2016 02:44:18
>> >> Subject: Secdir review of draft-ietf-curdle-dnskey-eddsa-02
>> >
>> >> I have reviewed this document as part of the security directorate's
>> >> ongoing effort to review all IETF documents being processed by the
>> >> IESG. These comments were written primarily for the benefit of the
>> >> security area directors. Document editors and WG chairs should treat
>> >> these comments just like any other last call comments.
>> >>
>> >> This document describes how to use two two specific Edwards Curves
>> >> (Elliptic Curves) in conjunction with DNSSEC, namely ed25519 and
>> >> ed448.
>> >>
>> >> The only comment I have on this document is that the Security
>> >> Considerations section plainly states, without any reference or proof:
>> >>
>> >> "Ed25519 and Ed448 offers improved security properties and
>> >> implementation characteristics compared to RSA and ECDSA algorithms"
>> >>
>> >> I suggest either adding references to proofs of these statements or
>> >> alternatively just remove the sentence (since it doesn't really add
>> >> anything to the memo); the remaining paragraphs in the Security
>> >> Considerations section is what really covers what someone implementing
>> >> the memo should know or be aware of.
>> >>
>> >> -- Magnus
>> >
>> > ~~~~
>> >
>> > ----- Original Message -----
>> >> From: "Dan Romascanu" <dromasca@gmail.com>
>> >> To: gen-art@ietf.org
>> >> Cc: "draft-ietf-curdle-dnskey-eddsa all"
>> >> <draft-ietf-curdle-dnskey-eddsa.all@ietf.org>rg>, "curdle"
>> >> <curdle@ietf.org>rg>,
>> >> ietf@ietf.org
>> >> Sent: Sunday, 11 December, 2016 12:21:25
>> >> Subject: Review of draft-ietf-curdle-dnskey-eddsa-02
>> >
>> >> Reviewer: Dan Romascanu
>> >> Review result: Ready with Nits
>> >>
>> >> Summary: Ready, with nits
>> >>
>> >> I am not an expert in this field, but the document seems to meet its
>> >> goals, it's clear and precise
>> >>
>> >> Major issues:
>> >>
>> >> Minor issues:
>> >>
>> >> Nits/editorial comments:
>> >>
>> >> 1. Section 4: s/Section5.1.7/Sections 5.1.7/
>> >>
>> >> 2. Section 8: 'The following entry has been added to
>> >>   the registry' - I may be wrong, but the section seems to define two
>> > > new entries in the registry rather than one
>
>



-- 
-- Magnus