Re: [dane] AD review of draft-ietf-dane-ops-12

Stephen Farrell <stephen.farrell@cs.tcd.ie> Wed, 10 June 2015 23:59 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: dane@ietfa.amsl.com
Delivered-To: dane@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DFA641A8AD2 for <dane@ietfa.amsl.com>; Wed, 10 Jun 2015 16:59:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ijMMAzQdqVEk for <dane@ietfa.amsl.com>; Wed, 10 Jun 2015 16:59:47 -0700 (PDT)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C4781A8AC1 for <dane@ietf.org>; Wed, 10 Jun 2015 16:59:47 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id 34C4EBEE1 for <dane@ietf.org>; Thu, 11 Jun 2015 00:59:45 +0100 (IST)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hiLDiuQ5Q7B for <dane@ietf.org>; Thu, 11 Jun 2015 00:59:42 +0100 (IST)
Received: from [10.87.48.73] (unknown [86.46.23.15]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id AA920BEDF for <dane@ietf.org>; Thu, 11 Jun 2015 00:59:42 +0100 (IST)
Message-ID: <5578CF6D.9060905@cs.tcd.ie>
Date: Thu, 11 Jun 2015 00:59:41 +0100
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: dane <dane@ietf.org>
References: <556F0BDF.6090603@cs.tcd.ie>
In-Reply-To: <556F0BDF.6090603@cs.tcd.ie>
OpenPGP: id=D66EA7906F0B897FB2E97D582F3C8736805F8DA2; url=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/dane/mpiTqFLPu4Z0eVvwsIG_DzbsTzA>
Subject: Re: [dane] AD review of draft-ietf-dane-ops-12
X-BeenThere: dane@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DNS-based Authentication of Named Entities <dane.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dane>, <mailto:dane-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dane/>
List-Post: <mailto:dane@ietf.org>
List-Help: <mailto:dane-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dane>, <mailto:dane-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 23:59:52 -0000

So I didn't see a response from the shepherd and since I'm
heading off now on holiday I've asked for the IETF LC to be
started. I'd like to continue this discussion when I'm back
after IETF LC. (And yes I saw Viktor's response but haven't
had a chance to get back on that sorry)

Cheers,
S.

On 03/06/15 15:14, Stephen Farrell wrote:
> 
> Hiya,
> 
> My review of this is below. I'm fine with starting the IETF LC
> and you handling these as last call comments along with others
> but since there are a bunch of 'em (and I bet Viktor will not
> be silent anyway:-) please tell me (Warren, as shepherd) if you
> prefer me to start the IETF LC now, or wait until we've chatted
> about these a bit. (And I'm fine either way.)
> 
> Cheers and thanks for the work on this,
> S.
> 
> - general: this was a bit of a slog - the draft is
> both dense (loads of 2119 terms) and long, which
> makes it a hard read. I'm not saying it's possible
> to do better, but just noting that in case someone
> has a good idea about how to make it easier to read.
> 
> - intro, 3rd para: I don't think this is very clear
> and it'd be great if it were - isn't there a way to
> provide clarity about the name that goes with the
> TLS session in which cases?
> 
> - 1.1, I think you need to define "TLSA base domain"
> here (or is it elsewhere? I didn't find it in 6698)
> 
> - section 2: Why duplicate so much of 7218?  I think
> it'd be better not to (or to obsolete that with
> this) but I don't care that much really.
> 
> - section 2: last sentence before 2.1 - is that
> saying that the MUST applies to section 9? If not,
> I'm not sure what it means, but it's not quite
> clear.
> 
> - section 3: saying TLS1.2 is a SHOULD is fine but
> what about when TLS1.3 is done (next year).
> Wouldn't it be better to say that the latest TLS
> version is a SHOULD and is currently 1.2?
> 
> - section 4: I read this as you calling DNSSEC
> "illusory incremental security" which I don't think
> is really what you mean and which interpretation
> calls into question the strength of the
> RECOMMENDATION here.  4.1 similarly says "PKIX-TA(0)
> and PKIX-EE(1) TLSA records do not provide
> additional security" which is too definitive, where
> is the evidence? (Not opinion or argument, but
> evidence.) In the absence of evidence I think we
> should omit these (and they are not needed.)
> 
> - 4.2: Did we check that CT is unlikely to make
> sense with DANE-TA records? In principle, public
> logs could add enterprise CAs without having real
> spam issues. I agree it's unlikely to happen in
> practice, and it's probably fine to revise this if
> that starts happening a lot, but since it could in
> principle, I wondered if we'd checked with the trans
> list (and I don't recall that we have)
> 
> - 5.1, last para: that's a bit coy about the "extra
> logic" - wouldn't it be better to explain? If not,
> why not?
> 
> - 5.2.1: 2nd para says "do honour constraints" but
> earlier (for DANE-EE+Cert) you explicitly said to
> ignore validity, subject etc. I think it'd be better
> to explicitly say here whether or not validity and
> naming need to match and if they do, then how.
> As-is, I suspect developers are likely to randomly
> either ignore validity and naming here too, or
> not;-) And if enough of 'em do different things,
> then that'd be bad. (If there were a good list of
> subsections of 5280 to honor or ignore that might
> work, but would be a bit tedious to figure out and
> might not work - I've not checked.)
> 
> - 5.2.3, last para: What is "are encouraged to" in
> 2119 terms?
> 
> - 5.4: "SHOULD NOT always stop" isn't clear, and the
> next sentence seems to have the MUST that clarified,
> so maybe drop the 2119 "SHOULD NOT"?
> 
> - section 6: what is a "master" TLSA record?  Maybe
> better to not introduce a new term like that.
> 
> - section 8, 2nd para: saying "are only compatible
> with" seems like an overstatement to me
> 
> - 8.2: I think in this example you generate a new
> key pair for the TLS server at the time that your
> are transitioning from DANE-EE to DANE-TA. Saying
> that would help, as there could be another
> transition case where the same TLS server key pair
> is maintained and an x.509 certificate (issued under
> the DANE-TA) for that same key is deployed on the
> TLS server. I'm not saying that's a better
> transition but only that it could presumably be done
> and arguably easier if it worked. But the only
> change I'd suggest for now is to just point out that
> a new key pair is generated for this example.
> 
> - 8.3: lowercase "should" often confuses as to
> whether that means 2119 or not. I don't care how you
> resolve.
> 
> - 8.4, I think last sentence of 1st bullet could be
> worth a bullet of its own
> 
> - 8.4, I'm not sure the last bullet is clear enough
> to be a useful summary - its a doozy of a sentence
> in any case;-)
> 
> - section 9: your background is showing:-) "by the
> MTA administrator" should presumably be "on the TLS
> client (e.g. by an MTA administrator)" or similar.
> 
> - 10.1.1: I guess we don't consider that it'd be
> good to give a reference to the TC bit? I'm ok with
> that but someone else might like to have one.
> 
> - 10.2: "The server name used for this comparison
> SHOULD be the base domain of the TLSA RRset." I
> think that works ok, but isn't that a change in
> client behaviour compared to a non-DANE TLS client?
> If to, then don't you need to call that out much
> more clearly? Do we actually need a "differences
> between DANE TLS clients and non-DANE TLS clients"
> section?
> 
> - section 11: I think s/public CA PKI/public CA
> WebPKI/ would be more accurate
> 
> - section 11: I don't get the logic for recommending
> weekly signing - once you automate signing (which
> you have to) then daily seems like it should work
> for everyone and weekly hasn't any benefit. So I
> don't get the reasoning here. (And a week seems bad
> when I read section 13 too.)
> 
> 
> _______________________________________________
> dane mailing list
> dane@ietf.org
> https://www.ietf.org/mailman/listinfo/dane
> 
>