Re: [Detnet] WG Last Call: draft-ietf-detnet-yang-12

"Gengxuesong (Geng Xuesong)" <gengxuesong@huawei.com> Mon, 07 June 2021 07:32 UTC

Return-Path: <gengxuesong@huawei.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA3753A3AB7; Mon, 7 Jun 2021 00:32:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.888
X-Spam-Level:
X-Spam-Status: No, score=-1.888 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CxP7M3sZ0aNc; Mon, 7 Jun 2021 00:32:37 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C0CC3A3AB4; Mon, 7 Jun 2021 00:32:37 -0700 (PDT)
Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Fz4Wb3fd8z6G88V; Mon, 7 Jun 2021 15:19:55 +0800 (CST)
Received: from dggpemm100003.china.huawei.com (7.185.36.68) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 09:32:32 +0200
Received: from dggeme752-chm.china.huawei.com (10.3.19.98) by dggpemm100003.china.huawei.com (7.185.36.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 15:32:30 +0800
Received: from dggeme752-chm.china.huawei.com ([10.6.80.76]) by dggeme752-chm.china.huawei.com ([10.6.80.76]) with mapi id 15.01.2176.012; Mon, 7 Jun 2021 15:32:30 +0800
From: "Gengxuesong (Geng Xuesong)" <gengxuesong@huawei.com>
To: Don Fedyk <dfedyk@labn.net>, tom petch <ietfa@btconnect.com>, Janos Farkas <Janos.Farkas@ericsson.com>, "detnet@ietf.org" <detnet@ietf.org>
CC: DetNet Chairs <detnet-chairs@ietf.org>, "draft-ietf-detnet-yang@ietf.org" <draft-ietf-detnet-yang@ietf.org>
Thread-Topic: [Detnet] WG Last Call: draft-ietf-detnet-yang-12
Thread-Index: AQHXU7CSqDhaWVpxJkepqOZkRzeM26r+buhAgAAFm4CAAhS9gIAHrYOQ
Date: Mon, 7 Jun 2021 07:32:30 +0000
Message-ID: <3f258a92c8034e67891560f1d5ee2b6d@huawei.com>
References: <60B0CCFE.7070608@btconnect.com>, <7a17c9dd6ab44cfdadd128ab9dc2aa8e@huawei.com> <DB7PR07MB55464A86A2FCF5D51D891D5FA23E9@DB7PR07MB5546.eurprd07.prod.outlook.com> <MN2PR14MB40309E701C059029E85D94A4BB3D9@MN2PR14MB4030.namprd14.prod.outlook.com>
In-Reply-To: <MN2PR14MB40309E701C059029E85D94A4BB3D9@MN2PR14MB4030.namprd14.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.108.242.209]
Content-Type: multipart/alternative; boundary="_000_3f258a92c8034e67891560f1d5ee2b6dhuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/0BGRJkrkiyNM-e0vPyEBxYTfmsA>
Subject: Re: [Detnet] WG Last Call: draft-ietf-detnet-yang-12
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2021 07:32:43 -0000

Hi Tom,



I would like to add some information about history of the document to explain why there are 6 authors listed in the document. (This is based on my memory, please correct me if I remember anything wrong)

Mach, Zhenqiang and I have worked together to give the initial versions of the models when the document was an individual document. After the document is adopted, Yeoncheol, Mach and I have worked on modifying the model. Reshad have given lots of suggestions during the process. Based on the discussions in WG, DetNet YANG model was requested to align with DetNet information model and Don joined us. We started weekly call meetings to discuss the document which have lasted almost 1 year or more. Besides the chairs, Don, Yeoncheol, Reshad and I have attended the call meeting normally. Don and Yeoncheol have contributed a lot at this stage.



I would suggest to maintain the authors list. I would request chairs to give some suggestions about how to shape the authors list if it is necessary.



Best

Xuesong



-----Original Message-----
From: detnet [mailto:detnet-bounces@ietf.org] On Behalf Of Don Fedyk
Sent: Thursday, June 3, 2021 2:16 AM
To: tom petch <ietfa@btconnect.com>om>; Gengxuesong (Geng Xuesong) <gengxuesong@huawei.com>om>; Janos Farkas <Janos.Farkas@ericsson.com>om>; detnet@ietf.org
Subject: Re: [Detnet] WG Last Call: draft-ietf-detnet-yang-12



Thanks for the comments Tom. I have collected the comments in the GitHub directory.

https://github.com/detnet-wg/draft-ietf-detnet-yang/blob/master/TomPetchComments.txt



I numbered the comments - As we start to address them the collective changes will be in this repo.



I'm starting on the structural comments (first 13).  If anyone else is editing please let me know which number(s) you which to address.

I will push changes rather frequently over the next few days.



Number 13 is six authors - which I cannot address by myself. If any of the authors would like to be acknowledge a contributor let us know. (The document has spanned several years and I don't know the full history).



I have a couple specific questions back to Tom which I will ask on a separate thread or as other conditions arise.



Cheers

Don





-----Original Message-----

From: detnet <detnet-bounces@ietf.org<mailto:detnet-bounces@ietf.org>> On Behalf Of tom petch

Sent: Tuesday, June 1, 2021 6:29 AM

To: Gengxuesong (Geng Xuesong) <gengxuesong@huawei.com<mailto:gengxuesong@huawei.com>>; Janos Farkas <Janos.Farkas@ericsson.com<mailto:Janos.Farkas@ericsson.com>>; detnet@ietf.org<mailto:detnet@ietf.org>

Subject: Re: [Detnet] WG Last Call: draft-ietf-detnet-yang-12



From: Gengxuesong (Geng Xuesong) <gengxuesong@huawei.com<mailto:gengxuesong@huawei.com>>

Sent: 01 June 2021 03:10



Hi Tom



Thanks for reviewing the document and giving comments. We will update the document based on your suggestions.



<tp>

Good!  I hope that this first set of comments are straightforward bringing the I-D in line with YANG Guidelines,  I think that they will generate some 100 or so changes and would encourage an update sooner rather than later as fixing them makes it easier for me to see more technical issues (and were it me I would never get them all right first time:-(



I have sent two other e-mail, one about layout, moving the tree diagram to the end, and that may be not so straightforward and then this morning a list of more technical comments on the YANG module which may generate more discussion.  Again, it is a long list and it may become simpler to separate some comments out into separate threads lest they get lost in the nesting but see how it goes.



Tom Petch



Best

Xuesong



-----Original Message-----

From: detnet [mailto:detnet-bounces@ietf.org] On Behalf Of t petch

Sent: Friday, May 28, 2021 6:59 PM

To: Janos Farkas <Janos.Farkas@ericsson.com<mailto:Janos.Farkas@ericsson.com>>; detnet@ietf.org<mailto:detnet@ietf.org>

Subject: Re: [Detnet] WG Last Call: draft-ietf-detnet-yang-12



On 27/05/2021 22:34, Janos Farkas wrote:

> All,

>

> This starts Working Group Last Call on draft-ietf-detnet-yang-12

>

> https://datatracker.ietf.org/doc/draft-ietf-detnet-yang/

>

> The Working Group Last Call ends on June 11th.

>

> Please send your comments to the working group mailing list.





Looking at it from an editorial point of view, there are a significant number of defects which make it 'Not Ready'.



IANA Considerations MUST be present as per YANG Guidelines, RFC8407; no registration, no YANG module



Security Considerations MUST follow the template as per YANG Guidelines



Examples MUST use the addresses reserved for IETF documentation, not those allocated to other organisations.



Requirements Language is out of date - see RFC8174



YANG revision statement must refer to the title i.e. 'RFC XXXX; Determistic Networking (DetNet) YANG Model'



The Information Model is now an RFC



It is unfortunate that RFC9016 is Informationsl - it needs to be a Normative Reference IMO; your AD is probably familiar with this problem as it occurred as recently as last month and will doubtless occur many times again



import yang-types references an obsolete RFC



YANG prefix is cumbersome - I think 'detnet' quite long enough and likely too long - it is a shame that dtn is in use elsewhere



references in the YANG module, RFC, IEEE or ietf-draft etc.,  MUST appear in I-D References and there needs to be a good reason why they are not Normative; I rarely see such a reason.



six authors, one for the AD to reflect on



Acknowledgements

(perhaps not a coincidence:-)



I plan to look at the technical content of the YANG which may, or may not, throw up similar a number of considerations.



Tom Petch



>

> Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!

>

> This is useful and important, even from authors.

>

>

>

> Thank you,

>

> János (DetNet Co-Chair & doc Shepherd)

>

>



_______________________________________________

detnet mailing list

detnet@ietf.org<mailto:detnet@ietf.org>

https://www.ietf.org/mailman/listinfo/detnet



_______________________________________________

detnet mailing list

detnet@ietf.org<mailto:detnet@ietf.org>

https://www.ietf.org/mailman/listinfo/detnet



_______________________________________________

detnet mailing list

detnet@ietf.org<mailto:detnet@ietf.org>

https://www.ietf.org/mailman/listinfo/detnet