[Detnet] WG Last Call: draft-ietf-detnet-data-plane-framework-02 - David Black's comments

"Black, David" <David.Black@dell.com> Fri, 04 October 2019 00:49 UTC

Return-Path: <David.Black@dell.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 888B9120827 for <detnet@ietfa.amsl.com>; Thu, 3 Oct 2019 17:49:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dell.com header.b=sxPIU29f; dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=emc.com header.b=ETz7Af+1
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WT7-m7aWlErL for <detnet@ietfa.amsl.com>; Thu, 3 Oct 2019 17:48:58 -0700 (PDT)
Received: from mx0a-00154904.pphosted.com (mx0a-00154904.pphosted.com [148.163.133.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12934120814 for <detnet@ietf.org>; Thu, 3 Oct 2019 17:48:57 -0700 (PDT)
Received: from pps.filterd (m0170389.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x940TgVe025634; Thu, 3 Oct 2019 20:48:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : subject : date : message-id : content-type : mime-version; s=smtpout1; bh=1AdWhW90vlLxnYbbnOhTtlut71qFYz/cHWltJD6A85Y=; b=sxPIU29fAItIDnvRfQ4gAkTp137Plqkh/gpQy6KfHqdLR6+tTPPhHq0O5Qx5yqIM7yET LJtnFlMq3pWekS5+Se1fUBu409sbxnD9o6dbMpmpaL1BqMj5aieEAYSh8MGYmLRAN3rF KAlrVUopLV1q2OdkUGreb9hNBGdZO6jFHjS75PciTjPGz4OrychL6KOlm9CmMXWTFrdM dxnH0SFSzCxPyW/49VjahjiFVS8Qywcm5AppVbCsJyErkSjsfAc41OfvofgZf9DTpeKa giXms7gCw+TzVPOcTB1mHXZtOlU+QKQ892kDtuzgsxLFSsPcngVpUYwkzG/D0yoU1NVR wg==
Received: from mx0a-00154901.pphosted.com (mx0a-00154901.pphosted.com [67.231.149.39]) by mx0a-00154904.pphosted.com with ESMTP id 2vdq6ts5m0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Oct 2019 20:48:55 -0400
Received: from pps.filterd (m0133268.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x940mFbG091170; Thu, 3 Oct 2019 20:48:55 -0400
Received: from mailuogwdur.emc.com (mailuogwdur-nat.lss.emc.com [128.221.224.79] (may be forged)) by mx0a-00154901.pphosted.com with ESMTP id 2vamkmtpdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 03 Oct 2019 20:48:54 -0400
Received: from maildlpprd54.lss.emc.com (maildlpprd54.lss.emc.com [10.106.48.158]) by mailuogwprd54.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id x940mo68029361 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 3 Oct 2019 20:48:53 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd54.lss.emc.com x940mo68029361
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1570150133; bh=RuCLYCXkLCxXK570yLWcvBJDOlg=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=ETz7Af+1Q5WPYbPKxy6ljsTObOTD3nwdMVE9P6w5oFSfX5jMhGiPKbcZ4wLz08Icw VkEWi7Zd2a0N2XS/vujmiDhoamVjAxemr53tm4Mz2tfoJKaaFTRiFwamXgxMJdQpVS /9jhjpsoPMoyKbtapXBmiApDo+3dcLh5zBTEcHUk=
Received: from mailusrhubprd02.lss.emc.com (mailusrhubprd02.lss.emc.com [10.253.24.20]) by maildlpprd54.lss.emc.com (RSA Interceptor); Thu, 3 Oct 2019 20:48:04 -0400
Received: from MXHUB304.corp.emc.com (MXHUB304.corp.emc.com [10.146.3.30]) by mailusrhubprd02.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id x940m3sG016326 (version=TLSv1.2 cipher=AES128-SHA256 bits=128 verify=FAIL); Thu, 3 Oct 2019 20:48:04 -0400
Received: from MX307CL04.corp.emc.com ([fe80::849f:5da2:11b:4385]) by MXHUB304.corp.emc.com ([10.146.3.30]) with mapi id 14.03.0439.000; Thu, 3 Oct 2019 20:48:03 -0400
From: "Black, David" <David.Black@dell.com>
To: "Grossman, Ethan A." <eagros@dolby.com>, "detnet@ietf.org" <detnet@ietf.org>
Thread-Topic: WG Last Call: draft-ietf-detnet-data-plane-framework-02 - David Black's comments
Thread-Index: AdV6TV/A1TeGhTYmTzWjnMGYEBIxmg==
Date: Fri, 04 Oct 2019 00:48:02 +0000
Message-ID: <CE03DB3D7B45C245BCA0D24327794936307585F6@MX307CL04.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=david.black@emc.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-10-04T00:48:00.0758406Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public
x-originating-ip: [10.200.40.229]
Content-Type: multipart/alternative; boundary="_000_CE03DB3D7B45C245BCA0D24327794936307585F6MX307CL04corpem_"
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd02.lss.emc.com
X-RSA-Classifications: public
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-03_09:2019-10-03,2019-10-03 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0 clxscore=1011 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910040002
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910040001
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/OgQibHGn90tQ0qG3S3HWRsSbAHs>
Subject: [Detnet] WG Last Call: draft-ietf-detnet-data-plane-framework-02 - David Black's comments
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2019 00:49:01 -0000

Comments follow - mostly nits/editorial, a few minor issues.



-- 3.  DetNet Data Plane Overview



   The DetNet Architecture,

   [I-D.ietf-detnet-architecture<https://tools.ietf.org/html/draft-ietf-detnet-data-plane-framework-02#ref-I-D.ietf-detnet-architecture>], models the DetNet related data plane

   functions decomposed into two sub-layers:

Nit: functions decomposed -> functions as decomposed

-- 3.1.  Data Plane Characteristics

Nit: DN acronym needs to be added to the abbreviation list in Section 2.2

Editorial: Figure 2 seems pointless, could be removed, ok to keep if contrast with Figure 3 is deemed important.

-- 3.2.  Encapsulation


OLD

   The encapsulation of the DetNet flows allows them to be sent over a

   data plane technology other than their native type.

NEW

   Encapsulation of DetNet flows enables them to be sent over a

   data plane technology other than their native data plane.


-- 3.3.  DetNet Specific Metadata

Minor: Need to explain Implicit vs. Explicit inclusion of metadata before using those concepts.

Minor: Paragraph on IP options and IP extension headers seems speculative.  Suggest removal.

--  3.5.  DetNet MPLS Data Plane


   In cases where metadata is needed to process an MPLS encapsulated

   packet at the service sub-layer, a shim layer also called a control

   word (CW) [RFC4385<https://tools.ietf.org/html/rfc4385>] can be used.

Nit: Remove "also"

-- 3.6.  Further DetNet Data Plane Considerations

Editorial: Please cite a reference for Network Coding.

-- 3.6.2.  Aggregation Considerations

The notion of DetNet "service type" shows up here for the first time.  That needs to be defined/explained back in Section 3.1.

-- 5.  Security Considerations


   From a data plane perspective DetNet does not add or modify any

   header information.

Minor: That text is not correct - see all the discussion of encapsulation earlier in the draft, where DetNet is clearly adding and removing headers.

Minor: Last paragraph of the Security Considerations section discusses network attacks on DetNet service.   That should be complemented by discussion of DetNet attacks on other networks via flow escape, as we've discussed in the past with focus on the IP data plane.

Thanks, --David

From: detnet <detnet-bounces@ietf.org> On Behalf Of Grossman, Ethan A.
Sent: Monday, September 23, 2019 6:38 PM
To: detnet@ietf.org
Subject: [Detnet] WG Last Call: draft-ietf-detnet-data-plane-framework-02


[EXTERNAL EMAIL]

All,



This starts a two-week working group last call for draft-ietf-detnet-data-plane-framework-02.



The working group last call ends on Monday October 7. Please send your comments to the working group mailing list.



Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!

This is useful and important, even from authors.



Thank you,

Ethan Grossman, Document Shepherd