[dhcwg] draft-ietf-dhc-dhcpv6-vendor-message-01

Alfred Hönes <ah@TR-Sys.de> Sun, 15 November 2009 20:45 UTC

Return-Path: <A.Hoenes@TR-Sys.de>
X-Original-To: dhcwg@core3.amsl.com
Delivered-To: dhcwg@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 2D3333A68BC for <dhcwg@core3.amsl.com>; Sun, 15 Nov 2009 12:45:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.851
X-Spam-Level: ***
X-Spam-Status: No, score=3.851 tagged_above=-999 required=5 tests=[BAYES_50=0.001, CHARSET_FARAWAY_HEADER=3.2, HELO_EQ_DE=0.35, MIME_8BIT_HEADER=0.3]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TadLqjSDE2TD for <dhcwg@core3.amsl.com>; Sun, 15 Nov 2009 12:45:21 -0800 (PST)
Received: from TR-Sys.de (gateway.tr-sys.de [213.178.172.147]) by core3.amsl.com (Postfix) with ESMTP id 812373A67B0 for <dhcwg@ietf.org>; Sun, 15 Nov 2009 12:45:20 -0800 (PST)
Received: from ZEUS.TR-Sys.de by w. with ESMTP ($Revision: 1.37.109.26 $/16.3.2) id AA140107865; Sun, 15 Nov 2009 21:44:25 +0100
Received: (from ah@localhost) by z.TR-Sys.de (8.9.3 (PHNE_25183)/8.7.3) id VAA15653; Sun, 15 Nov 2009 21:44:20 +0100 (MEZ)
From: Alfred Hönes <ah@TR-Sys.de>
Message-Id: <200911152044.VAA15653@TR-Sys.de>
To: volz@cisco.com, dhcwg@ietf.org
Date: Sun, 15 Nov 2009 21:44:20 +0100
X-Mailer: ELM [$Revision: 1.17.214.3 $]
Mime-Version: 1.0
Content-Type: text/plain; charset="hp-roman8"
Content-Transfer-Encoding: 8bit
Subject: [dhcwg] draft-ietf-dhc-dhcpv6-vendor-message-01
X-BeenThere: dhcwg@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <dhcwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dhcwg>
List-Post: <mailto:dhcwg@ietf.org>
List-Help: <mailto:dhcwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dhcwg>, <mailto:dhcwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Nov 2009 20:45:22 -0000

I have reviewed draft-ietf-dhc-dhcpv6-vendor-message-01
and have only a few editorial comments.


(1)  Abstract
[[ same as for draft-ietf-dhc-dhcpv4-vendor-message-01 ]]

                 vvvvvvvv
   This document requests a vendor-specific DHCPv6 message assignment.
   [...]

This text will be OBE by the publication of the memo as an RFC
and should be replaced by words still valid then (see my notes
on dhc-dhcpv4-vendor-message-01).


(2)  Section 2  vs. Section 5

Below the first diagram in Section 2, the draft says:

      msg-type             VENDOR-SPECIFIC (TBD)
                                            ^^^

However, the IANA considerations in Section 5 say:

|  IANA is requested to assign DHCPv6 Message type 254 to the Vendor-
|  specific Message in the registry maintained in [DHCPv6Params]:
|
|     254 VENDOR-SPECIFIC
      ^^^

The draft should be made consistent, either prescribing the value to
be assigned or leaving it to the IANA.

(3)  Section 2, editorial

In the paragraph below the first diagram and the related field
explanations, the draft says:

   The options MUST be encoded as a sequence of code/length/value fields
|  of identical format to the DHCPv6 options field.  [...]
      ^^^^^^^^^^^^^^^^^^^

Again, "identical to" should be brought together:

   The options MUST be encoded as a sequence of code/length/value fields
|  of format identical to the DHCPv6 options field.  [...]
      ^^^^^^^^^^^^^^^^

(My notes on dhc-dhcpv4-vendor-message-01 contain an alternative
for a similar issue, which could be applied here as well.)


Kind regards,
  Alfred Hönes.

-- 

+------------------------+--------------------------------------------+
| TR-Sys Alfred Hoenes   |  Alfred Hoenes   Dipl.-Math., Dipl.-Phys.  |
| Gerlinger Strasse 12   |  Phone: (+49)7156/9635-0, Fax: -18         |
| D-71254  Ditzingen     |  E-Mail:  ah@TR-Sys.de                     |
+------------------------+--------------------------------------------+