[Dime] AD review of draft-ietf-dime-diameter-cc-appl-mib-03.txt
"Romascanu, Dan (Dan)" <dromasca@avaya.com> Tue, 19 January 2010 14:27 UTC
Return-Path: <dromasca@avaya.com>
X-Original-To: dime@core3.amsl.com
Delivered-To: dime@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 4813C3A67F0 for <dime@core3.amsl.com>; Tue, 19 Jan 2010 06:27:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.622
X-Spam-Level:
X-Spam-Status: No, score=-2.622 tagged_above=-999 required=5 tests=[AWL=-0.023, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xq0ISYDJ9k34 for <dime@core3.amsl.com>; Tue, 19 Jan 2010 06:27:07 -0800 (PST)
Received: from co300216-co-outbound.net.avaya.com (co300216-co-outbound.net.avaya.com [198.152.13.100]) by core3.amsl.com (Postfix) with ESMTP id 446CA3A659B for <dime@ietf.org>; Tue, 19 Jan 2010 06:27:07 -0800 (PST)
X-IronPort-AV: E=Sophos;i="4.49,303,1262581200"; d="scan'208";a="200833485"
Received: from unknown (HELO p-us1-erheast.us1.avaya.com) ([135.11.50.53]) by co300216-co-outbound.net.avaya.com with ESMTP; 19 Jan 2010 09:26:48 -0500
Received: from unknown (HELO 307622ANEX5.global.avaya.com) ([135.64.140.11]) by p-us1-erheast-out.us1.avaya.com with ESMTP; 19 Jan 2010 09:26:17 -0500
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Jan 2010 15:26:00 +0100
Message-ID: <EDC652A26FB23C4EB6384A4584434A0401E0B33F@307622ANEX5.global.avaya.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: AD review of draft-ietf-dime-diameter-cc-appl-mib-03.txt
Thread-Index: AcqZE1Ks17Q8/tOnT7mdBuHxgVghvQ==
From: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
To: dime@ietf.org
Subject: [Dime] AD review of draft-ietf-dime-diameter-cc-appl-mib-03.txt
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2010 14:27:08 -0000
Please find below the AD review of draft-ietf-dime-diameter-cc-appl-mib-03.txt. This document is in pretty good shape, however, there are a number of issues that need to be clarified and answered before it is sent for IETF Last Call. Please consider the comments below and address them or clarify the questions that I have misunderstood. Regards, Dan Technical Issues T1. In Section 3: -- The MIB specification for the Diameter base protocol [I-D.ietf-dime-diameter-base-protocol-mib] SHOULD be implemented prior to the implementation of this MIB. Why is this a SHOULD and not a MUST? Also, as an editorial observation around the same phrase, probably 'prior' is not the right term. What is meant is I think that it is assumed that an agent implementing the CC-application MIB also implements the base DIAMETER MIB., T2. diameterCcAppMIB OBJECT IDENTIFIER ::= { diameterCCAMIB 2 } I do not see the reason for two nested OIDs diameterCcAppMIB and diameterCCAMIB T3. dccaHostID - the definition is similar with dbpLocalId in the DIAMETER-BASE-PROTOCOL-MIB - why duplicate the object? T4. How does dccaHostIpAddrTable differ from dbpLocalIpAddrTable? And if we are already here, the same question that I asked in the base MIB review applies here: why a new table instead of using information from the ipAddressTable in RFC 4293? T5. dccaPeerFirmwareRevision - the SYNTAX of this object should be consistent with the entPhysicalFirmwareRev object in RFC 4133 which is an SnmpAdminString. Actually the DESCRIPTION clause should mention that if the Entity MIB is supported on the peer, than the two objects must have identical contents. T6. dccaPeerStorageType and dccaPeerVendorStorageType - the fact that none of the writeable objects cannot be changed - does this include the RowStatus object itself? This would mean that rows can be created by never deleted. T7. The Security Considerations section does not follow the guidelines listed at http://www.ops.ietf.org/mib-security.html Editorial Issues: E1. RFC 4181 section 3.2 recommends that the narrative sections of MIB documents 'include one or more sections to briefly describe the structure of the MIB modules defined in the specification'. I see no reason for an exception here. E2. Running id-nits results in a comment / question: -- The document has a disclaimer for pre-RFC5378 work, but was first submitted on or after 10 November 2008. Does it really need the disclaimer? E3. Adding REFERENCE clauses to the definitions in RFC 4006 and other places would be very useful and improve the readability of the document. E4. Even if not used by now it's better to use the name diameterCcAppNotifications rather than diameterCcAppTraps E5. Adding UNITS clauses to the counter objects definitions would be very useful
- [Dime] AD review of draft-ietf-dime-diameter-cc-a… Romascanu, Dan (Dan)