[Dime] AD-review of draft-ietf-dime-ikev2-psk-diameter-05.txt

["Romascanu, Dan (Dan)" <[e-mail]>]

Hi, 

Please find below the AD review of
draft-ietf-dime-ikev2-psk-diameter-05.txt. While the document is in
pretty good shape, there are a few key technical and editorial issues
that need to be addressed before we can send the document to IETF Last
Call. 

See below. Technical requirements are marked Tx and Editorial
requirements are marked Ex. 

Thanks and Regards,

Dan 


T1. In the Abstract section I find the following: 

> This document therefore extends
   the functionality offered by [RFC 5778] with pre-shared key based
   authentication offered by IKEv2 when no EAP is used.

Would not this imply that the document should have the note 'Updates RFC
5779 - when approved' in the header? 

T2. In any case it seems to me that RFC 5778 should rather be a
Normative Reference rather than an Informative reference. 




E1. [RFC5778] is the correct label for the reference and not [RFC 5778]

E2. In Section 1 s/IKEv2 protocol allows/The IKEv2 protocol allows/

E3. Expand HAAA at the first occurrence which is in Section 1

E4. Section 4.2 - s/IKE_SA correspond/IKE_SA corresponds/

E5. Section 9 IANA Considerations needs a serious re-write. The first
paragraph should not use verbs at past time as we are describing here
codes and values defined in this specification. All the other sections
need to be explicit about what allocations are required from IANA. For
example it would be good to use the format 'IANA is required to allocate
the following AVP Codes: IKEv2 Nonces - TBD5, Ni - TBD5, etc.'