Re: [Dime] Review of draft-ietf-dime-diameter-cmd-iana

"Hannes Tschofenig" <Hannes.Tschofenig@gmx.net> Sun, 12 July 2009 08:18 UTC

Return-Path: <Hannes.Tschofenig@gmx.net>
X-Original-To: dime@core3.amsl.com
Delivered-To: dime@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 003253A6A25 for <dime@core3.amsl.com>; Sun, 12 Jul 2009 01:18:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.872
X-Spam-Level:
X-Spam-Status: No, score=-0.872 tagged_above=-999 required=5 tests=[AWL=-0.873, BAYES_50=0.001]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TVPzbdReN9gW for <dime@core3.amsl.com>; Sun, 12 Jul 2009 01:18:03 -0700 (PDT)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by core3.amsl.com (Postfix) with SMTP id 949B53A683D for <dime@ietf.org>; Sun, 12 Jul 2009 01:18:02 -0700 (PDT)
Received: (qmail invoked by alias); 12 Jul 2009 08:18:30 -0000
Received: from a91-154-108-144.elisa-laajakaista.fi (EHLO 4FIL42860) [91.154.108.144] by mail.gmx.net (mp009) with SMTP; 12 Jul 2009 10:18:30 +0200
X-Authenticated: #29516787
X-Provags-ID: V01U2FsdGVkX18sUdRkrdgsXQ7hkV2bxLonGWH/Wbjb8LyKMDmP+p ethLztmR97XKoP
From: Hannes Tschofenig <Hannes.Tschofenig@gmx.net>
To: 'Mark Jones' <Mark.Jones@bridgewatersystems.com>, dime@ietf.org
References: <4E0F60BAF2FA7C46BBB5474DF8A89BCD022F034C95@m679t05.fpmis.bridgewatersys.com>
Date: Sun, 12 Jul 2009 11:20:48 +0300
Message-ID: <186801ca02c9$aa058150$501ca20a@nsnintra.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
In-Reply-To: <4E0F60BAF2FA7C46BBB5474DF8A89BCD022F034C95@m679t05.fpmis.bridgewatersys.com>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350
Thread-Index: Acn4zMguFnarNKd4QT6lWGKyxVbNXQJ+baWw
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.5600000000000001
Subject: Re: [Dime] Review of draft-ietf-dime-diameter-cmd-iana
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Jul 2009 08:18:04 -0000

Hi Mark, 

Thanks for the review.  

>-----Original Message-----
>From: dime-bounces@ietf.org [mailto:dime-bounces@ietf.org] On 
>Behalf Of Mark Jones
>Sent: 29 June, 2009 18:18
>To: dime@ietf.org
>Subject: [Dime] Review of draft-ietf-dime-diameter-cmd-iana
>
>I realize that this is past the review deadline but hope it is 
>not too late for consideration. My comments on the Abstract 
>and Introduction are editorial but the meat of it (the IANA 
>considerations) looks fine to me.
>
>Abstract:
>---
>Suggest rewording:
>   RFC 3588 illustrates the conditions that
>   lead to the need to define a new Diameter application or a new
>   command code.  
>To:
>   RFC3588 illustrates the conditions which require the definition of 
>   a new Diameter application or a new ommand.

Fixed. 


>---
>Suggest rewording:
>   This document aligns the extensibility rules of Diameter application
>   with the Diameter commands offering ways to
>To:
>   This document aligns the extensibility rules for Diameter 
>command codes 
>   with those defined for Diameter application identifiers and offers a
>   consistent way to

Fixed. 


>===
>
>1. Introduction
>
>Suggest rewording:
>   This is achieved by splitting the command code space into an IANA
>   administered code space, and a vendors-specific code space with
>   different rules of allocation as per [RFC5226].
>To:
>   This is achieved by splitting the command code space into an IETF
>   code space, and a vendors-specific code space with different rules 
>   of allocation as per [RFC5226].
>
Fixed. 

>The whole command code space is still under IANA administration, right?

Yes. I changed the wording to make it more clear. 

>
>---
>
>Typo:
>	s/[I-D.ietf-dime-rfc3588bis]./[I-D.ietf-dime-rfc3588bis]



Update here: 
http://www.tschofenig.priv.at/svn/draft-romascanu-diameter-cmd-iana/draft-ie
tf-dime-diameter-cmd-iana-01.txt


Ciao
Hannes

>
>---
>
>Regards
>Mark
>_______________________________________________
>DiME mailing list
>DiME@ietf.org
>https://www.ietf.org/mailman/listinfo/dime
>