Re: [Dime] Barry Leiba's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)

Mark Jones <mark@azu.ca> Tue, 23 February 2021 18:19 UTC

Return-Path: <mark@azu.ca>
X-Original-To: dime@ietfa.amsl.com
Delivered-To: dime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 199483A0D4E; Tue, 23 Feb 2021 10:19:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oO3VZ7yItNp8; Tue, 23 Feb 2021 10:19:43 -0800 (PST)
Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E9BF3A0D4A; Tue, 23 Feb 2021 10:19:38 -0800 (PST)
X-Originating-IP: 45.72.253.70
Received: from [172.18.10.17] (unknown [45.72.253.70]) (Authenticated sender: mark@azu.ca) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 80A3B1BF206; Tue, 23 Feb 2021 18:19:32 +0000 (UTC)
To: Barry Leiba <barryleiba@computer.org>, The IESG <iesg@ietf.org>
Cc: draft-ietf-dime-group-signaling@ietf.org, dime-chairs@ietf.org, dime@ietf.org, jounikor@gmail.com
References: <161212305848.21181.8553749177220111509@ietfa.amsl.com>
From: Mark Jones <mark@azu.ca>
Autocrypt: addr=mark@azu.ca; keydata= mQINBFTO24IBEACzeJfqz82LIhLROAV6w/i63OZrPluFNnT0EVzQWILiu73h+B5owgdLl3T7 dSng+E+5rRYU4Zk/Oj6+r6bJv0YOjBYPJ27NP9wGWnfjQPi61rmbEvjyxZXIXX6NpP+V/B0Z l5ibCyCj2nOEvXeBsBQbQ0VrVULoeIS2hTrbY4TlAW7WeSNn3bNYDxxcJRTD6oWb6/1jGHK1 5nRR3p1RqJSyPu/I3KVyWxAy9/cXwMj7z+0WzitdNfDEbnqH9/9wlDqDS1vRRR3G/ip3BMwm 4FgtS2MjnrdrLy7pPXomkeIt0nNkR6S2ugt/1E/yPjTjZW/B/+ixQMS5nJZj8TIHSt+lkmjs JS0dgNSjenBfx3rUgkPuDtxOI1p9/EwVXsQ5O64bb+MbUQRwVicsfaqHz9FwZ/qOvl0e4EPg AKY4PjTvQIa71uAsPjRuWmUKnQgt4pGnm055V/W7rEieCLdW6qFZ8HBMjw3NjVjyu42R0kAO 60xRGudL4/i4S/pxdvcbgT5gVq9RF9+rDHEDRh8w27qEhuc0a+BfNzkzNsfO/Gj4xBui1nIY 31RnFTeOCYe1EWxmxBRMvMegl0Cu+cppeX3Ld/kkLiIJH4tCi7tWfaHowdBXttJX5sZ3TZTo RD4ggxW9oiGtbcGbzWqyHrbOH5OD6eiajgPt5qy304gQagvo3QARAQABtBhNYXJrIEpvbmVz IDxtYXJrQGF6dS5jYT6JAlQEEwEIAD4CGwMFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AWIQSF HeiT2i4Rm9Bf7QE5eUOf0oV44QUCX+9hwAUJDQG5vQAKCRA5eUOf0oV44S6/EACZNfF50jq1 jQv/Jdd6UC8PAq4tWWrE+rG33mtolrZknEc/i2AhjwOu/Qu7zTDD4W8QtZyohj7gSec6g0pu zBtNI4+sHWBilTuorwSSFCKInp0YiPNPkrPKRmtE299I/9GPR8vAu/q5/EmCnv3LuRfgWq3L S32Hf9xY519uEdDgwSSuFLJbk20Vv7PnwTDNZu+ivV05zvOn70hu1+mK5VnvuHSjfdiJZg7e I3cAApJAVW3ccrSU82qS4cvzi4SteCIFjFVY9m2sfXBySFrMrQQvkkWpxMtDqEC6kKZgMS4A WoSWqAUG3m1tW7IC99l5IpDJbP6VZrVQ0n5uBAgGTi97aQSn3wF4KC86T73KHXITthaZOMYF I4NT9+xagnRd3PSvFwtEQevE7jCoOGqZm7sh4nY6lSqlc/OX/LkWPgEqu6dT9omekOQUsBNL 3GU/i1iik31IM9k2CQd7CwuhWyuzbkIN+7IRpleyX39OoFiLYISSPE1mwwxniohGXMVUcD0n MhggQAGg4nv1cWsF9g2P+xlCXAhPtxMUUs/y2FKZK5+LOIR5oC+1zw7TThijEZaPYFiN8dP6 B109ZWVxBDpFw02XPj9+TYAFSE/pTBW+TKwt+S8vvkZMTmFu0ynAvcxednUzdWuinaD3ZvQp KUUGCdu449H4npf0qUHjsGzkybkCDQRUztuCARAA5iMJ2k+GnSQbxEYq9FckNB72a1To1eye L1X9qefIIFdm+oaw69LlZAtwoVsF3BP5N/LYxusL37vMLOg2RGvU+DU4Cdnv2BW31BVfjNNe ts21CytmOyiemJ6uG2uO6gLBJ7K5GVoqg3dh9sGSUGP4kS2j+D+t/wWemOjb0wS5j4FHWXur 4cG4YTlhpBY1/okWYxuLsLiybUJSSwoqKmJGKILAgKk3JeoqGXXwNr7r3AvppwJ8FNZSSxvm qDFIQ7A+KNB6B/RxlKJNSPl5OjGIOCTA+HVKbJn2d+yhczZKl406tY0yH2JVTPBXDAmCStP0 RPaKdxAooQ/PheTo8vmonj98CBLcs4oYi30xhtLbOm9udd1co4TIEspSct+fXISvsutk21nx PSfUEP6fjdMCXOm2lM4r4kCaPMpVnI4B6nN819KD0AbMbeaO4c1fv9+2lLoGy0CPekEOP6MC BmIatT8w7rKFDZQLQE8WWQcaTmmNGAooxFQnAucOZSHmVvk6PFALImuIan4qH6M20hlE2F7q gU1YmcNFc4BRkXmOmvTCpSDUo72r09s10Xf7wvJh8vGkXKdWmASsXcG5kmCFIHCYADvrznvc K8id2t/r2+excjv91k4M7evU8zxZhvD7s/hRBFdF8CqHiC27XPb5j/PGdg/oHkwBmWyN7stE OmMAEQEAAYkCPAQYAQgAJgIbDBYhBIUd6JPaLhGb0F/tATl5Q5/ShXjhBQJf72HABQkNAbm+ AAoJEDl5Q5/ShXjh2GAP/RfCihJ8lLIGbUNP0059YRF0Qshk53d9FQdz9nEthRcb2rygyHOL 8nuU16emb2USYPtQpEwVBpl98YvkccWlQCW57Ex+6UTzfSF5rMLZFdtMcbE+CgjvZg6qm0US 7cvlBk9ablPR8VSuzj2xKPlLVliTBFZYPy/rXVRntedjdRlzZi20bki3rXnnlVSXq07i4AOA zaQN6sirkFkkjtL1pd0+Jb62gC/meY5osLH+uPLhDO41np9yLaUyv6gzj++0NBR6JKwuGDSr mgTBOaMwb5PoBayBQHfcA7LRFhvDjoImgHLJv4gwlHSV6/5uYynCXt4Lq6LMjT+E4WXzFJAm /fYGf3JwrUV4lIvY5IiuQWbPnxRUsFRfFvorUbCQHw8/es6NGSsXj5vDMW5/qAcM4qbak0bP V6YdkWnkU44GglJdOeWujqLaLiv3CkfoakhDRtHDGU8VvTTSJGHs+FX5Jne1YHZbQPTUQgEq 89YSQEIBJkkuO2yZqQCZM8h6n2iPgD3zwcI2P26GeraCL1fueJlNUH5MG5Pm0LLMQeePwG5m tFZFY8olZYT9EeP9lU/AOnUQdtQtykqTVmcYkHxGTufcFEhkDUNWZVN8PwqE7M3DZgF6nwAX rmcXpup8RFrFDMdP2vPl9MJ3pOl64rFBV/qYszF/UxkA47BBQIs23uZxuQINBFTO3HUBEADh 4iYII/xish1C2ZCX42r+fFlrUg4HLRTXKq7tZZ1ZCMumka2G8T3WUJptC+YiZZeMUjelJQ9f LHo0BJ6OA442DIobSSwliQ7xjm7XZKsDgVfm8d8PJrtjQZYjLQ+KV2PELLUgGzoCPh0xUq3x YuAlvx/bpIFD/RxDkdhYBaudCC228pchGKOf00CMmYnjUWd7/uneAjpY2gkBIHY5NXB5la+G aqakRqAzlxjsO9gtu8p/lr3AjGnUHnYjZYFqZx2dGzLL1u3DFnge2Lsblc4MitUfmnLGj3tt 9ylEw6ZVncRd8sssPAEsUEfJ5cVerrzwm1/jcGSohY9czEHPxkkaIWyPGqSTfQKxqE6kYNye lst75vaqewJ1Ydv6iR1xBmv+ll1BHXuprQdGFUZfwIFY03ZdRbgmE4WQV4FaWYE5tCJup2n4 r655tUB2nccnyS4KC5ATrR6DZlNj6wMqEwmD8uK5pqHmGt64wELKBP8584jvUkYSpE2HfY3c 0C6D/aXL38BY7YEqOrbBPSBCSmJMuFJLWeU172AbSGWdpnNaPzGpucXwhcJzTpcAIEg91toN PUJe54QL2iyKtuV+0bFbO1uxLPDPRlaULVouF3diNkefMrMnode9r7v9vKx9a6rxXNb7baTM GpWliG0a3Z9Jsytb91V7iX/Iks8JT3iD9wARAQABiQRbBBgBCAAmAhsCFiEEhR3ok9ouEZvQ X+0BOXlDn9KFeOEFAl/vYcEFCQ0BuMwCKcFdIAQZAQoABgUCVM7cdQAKCRCAeMBSpt+65B64 EADYAlu0heeyz7rEPvFoHuxyZtH5abrGfT14YD042AvL/mXelWnUcpQNRhP4UayrKzyPZyiJ wZ5jQgvuWjRiIIGRng9IAKsd3uc89V2PO8rzIwfXcL0nK0+tDdJWnPUfsCv2RrnOUYHVsfHS OcwW88ReIzLsSLrCiWCo5hYsaxN7khodMzNXWMMc7p+ODRpumO7SUdS84iATygh4IsY/VC2J tgO9Ex0YjjE56anjXKHhoIZl/40qyz7sjSrl3snn/AzTs61WjlGvUyemjYv5sN/Bdf1l6PPS bCKNJ2jfTu/6BTCM82zJrVxJEG/fcXo9R5WMPmo4Vfu22rcu9s+W8CjawlmQbd5C3/IgM0rv icBzZ2d3sMFm3NDfzI8RYBEkC82CvNACRA6HIJqjrLzoRebNq6JgxA8uz7dK7atZhk0C+Ui2 +duc3ke1XdKbX0d5bXfPmLhZ8H8HMPPlh40RS9ogcQEBagk/lI+Q2iBnEGsYbXK7OaT5cDVS y/gu2HJnJhe734527u4FiwtQ5KhRNEpDGfRATIlqojUoO7rf7kf5HxvK8wP1cpCjoV6tW5f5 SVL9VuNYIoE6ATGlSNaN4j+/kA9LewhLuQpoBeGqUZpKC9a8BuYwBwR9PsH5g44X5TIqcXXV lrbIOBAqZ6X3znUXdtQj/rzmCqkqNTSH0nFXmAkQOXlDn9KFeOF9ug/+IRW15fJjTPYgpKVO LmdRmp09CTI64gv6YOzohMddPp32zeY9x+MUpBGO0fRMnK4e5SmUvsRDyAgDQZKBpBNluTkT r9VH/GnTJtmljp/XaZsdaHnZNcXgG2W6Z6LjK9I9cdJhyU3bU0luePDIWVNR62QADJbS4nJS wL0VRQz1ZXu6Qmf6p3+J0hdlWZLbrO7Jw3hCUg8WSwQ1KEom/U0BLbn1X3qqtnlFW7nFOzZi GBUcDRxSzdxLziB+cELK2Mb/udU7x3OD27j37qQYLIkx/yw4YHrPfDQP36VwLpw0jWHpGPGk 5s3is6KuWjWtZ+JAZ/BYY2rcf2JPnLWwI0voUwBaheD/LM+eCHP2VwkKq19d7GFiKNxRd5km 6vE2tnc0g+cIOb8BvqykljfXmJTlz6eShEVtoZD3fXEQQECFVEqF7biF37MZgO7xUfvIc/D0 zOs5w1vfYMM3lhtUPztsPV1okCuhvQzf5DBJkCXl/He92AbzNfThGODD10izICYVXXvFHZe/ b3mAvaGvpQc4m7mhKcrQV/MFyYXJvUYQqNRIgajhSxN7mbN/sIQYqIMxszophMuFENpT6f+C nX0CMvs+ZSb5fNHZHsZCfGWzXdjq4UgBpvdaspx7Wor/WYDskHFCzJtUwAvG8zxFW64LHQNJ g0tx5RXZpetL0Lum5+E=
Message-ID: <38aacde1-aa19-c193-23e1-c71a14173e06@azu.ca>
Date: Tue, 23 Feb 2021 13:19:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <161212305848.21181.8553749177220111509@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/dime/l462G0k3r-nv60JleGpGu2W2YZM>
Subject: Re: [Dime] Barry Leiba's No Objection on draft-ietf-dime-group-signaling-13: (with COMMENT)
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dime/>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2021 18:19:46 -0000

Appreciate the thorough review, Barry. Comments inline below.

On 2021-01-31 2:57 p.m., Barry Leiba via Datatracker wrote:
> Barry Leiba has entered the following ballot position for
> draft-ietf-dime-group-signaling-13: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-dime-group-signaling/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> I have to say that I found this to be challenging to read: much of it is very
> dense, with paragraphs giving sometimes-subtly-different conditions, and I
> would be reading it thinking, “Does this paragraph apply to my situation?  I
> don’t think so, but what about the next one?  Wait, maybe it was the other one
> after all.”  I just have to assume that someon actually implementing Diameter
> would have an easier time following it.
> 
> I have some editorial comments that won’t help with that aspect, but that I
> hope will help with clarity in general:
> 
> — Section 3.1 —
> 
>    A session group, which has sessions assigned, can be deleted, e.g.,
>    due to a change in multiple users' subscription profile so that the
>    group's assigned sessions do not share certain characteristics
> 
> It appears that “has sessions assigned” is restrictive (it’s a required
> description, not just extra information).  If so, it should say, “A session
> group that has sessions assigned can be deleted, e.g., due to...” without the
> internal commas.
> 
> Another way to put it might be, “A session group can be deleted even if it has
> sessions assigned, e.g., due to...”
> 

We intended to say that a session group can be deleted and provide an example.
The concept of "group" is clearly introduced in the paragraph just above and the
details are provided in the subsequent sections. We propose the following
rephrasing:

"It may be required to delete a session group, e.g. at the expiry of a
promotional period that applied to multiple subscriber profiles".


> — Section 3.3 —
> 
>    This specification follows the most flexible model where both, a
>    Diameter client and a Diameter server can create a new group and
> 
> Nit: no comma here
> 
>    Either the client and the server
>    can assign a session to a group.
> 
> Nit: “Either the client or the server can”, or “Both the client and the server
> can”.
> 

Suggested wording:
"This specification allows a permissive model where either Diameter client or
Diameter server can create a new group. The creator of the group becomes the
group owner and assigns a new identifier to the group according to the rules in
Section 7.3."


>    Details about
>    enforcing a more constraint permission model
> 
> I think the word you want is “constrained”.
> 

Agreed. Addressed in the next revision.

> — Section 4.2 —
> 
>    Diameter AAA
>    applications typically assign client and server roles to the Diameter
>    nodes, which are referred to as relevant Diameter nodes to utilize
>    session grouping and issue group commands.
> 
> I’m having trouble parsing this sentence and determining what you’re trying to
> tell me.  Can you please rephrase or repunctuate it to make it clearer?  What
> are referred to as “relevant Diameter nodes”?  What goes with “to utilize
> session grouping”?
> 

We agree that it needs rephrasing and propose:
"Although Diameter is a peer-to-peer protocol, Diameter AAA applications
typically assign the role of "Diameter client" to the Diameter node initiating
the Diameter session and the role of "Diameter server" to the Diameter
node authorizing the Diameter session. This specification does not restrict
group creation, assignment or deletion actions to a specific role. In the
following sections, Diameter node is used to refer to either role."


>    Diameter nodes, which are group-aware, MUST store and maintain an
>    entry about the group assignment together with a session's state.
> 
> Similar to earlier: is “are group aware” meant to be restrictive (there are
> Diameter nodes that are group aware and those that are not, and you’re talking
> about the former), or non-restrictive (all Diameter nodes are group aware, and
> you’re just pointing that fact out).  It is currently written as
> non-restrictive, but I think you mean it to be restrictive.  If that is
> correct, remove both commas and change “which” to “that”.
> 

We propose rephrasing to:
"Any Diameter node that has advertised support of session grouping and group
operations MUST store and maintain the group assignment as part of the session's
state."


>    A Diameter node MUST also keep a record about sessions, which
>    have been assigned to a session group by itself.
> 
> The comma shouldn’t be there, and “which” should be “that”.  But it’s a bit
> awkward anyway: may I suggest rephrasing in active voice as, “Each Diameter
> node MUST also keep a record about sessions that it has assigned to a session
> group.”
> 

Agree with suggested rephrasing. Will implement in the next revision.

> — Section 4.2.1 —
> 
>    If the
>    response from the server indicates success in the result code but
>    solely the assignment of the session to a session group has been
>    rejected by the server, the client treats the session as single
>    session without group assignment.
> 
> What does “solely” mean in this sentence?
> 

It should have been "only". However, we believe this sentence has been made
redundant by previous edits and can now be removed. The previous sentence
already states that the client MUST remove the session from the group if the
server rejects the proposed assignment. The session then proceeds as if it were
not assigned to the group.

>    A Diameter client, which sent a request for session initiation
> 
> Please remove the comma (and change “which” to “that”).
> 

We propose the following rephrasing:

"If a Diameter client sends a request for session initiation containing one or
more Session-Group-Info AVPs but the response from the Diameter server does not
contain a Session-Group-Info AVP, the Diameter client MUST proceed as if the
request was processed without group assignments."


> — Section 4.2.2 —
> 
>    The session, which is to be removed from a group, is
> 
> Make it, “The session that is to be removed from the group is”
> 
>    When a Diameter client decides to remove a session from all session
>    groups, to which the session has been previously assigned,
> 
> Remove the comma after “groups”.
> 

Agreed. Fixed in next revision.


>    The session, which is to be removed from all groups, to
>    which the session has been previously assigned, is identified in the
>    Session-Id AVP of the command request.
> 
> Make it, “The session that is to be removed from all groups to which it had
> been previously assigned is identified in the Session-Id AVP of the command
> request.”
> 

We came up with the following rephrasing to improve the readability:
"The Session-Id AVP in the re-authorization request identifies the session that
is to be removed from all groups to which it had been previously assigned."

> — Section 7.3 —
> 
>    The
>    <DiameterIdentity> portion of the Session-Group-Id MUST identify the
>    Diameter node, which owns the session group.
> 
> Please remove the comma and change “which” to “that”.
> 

Agreed. Will be fixed in next revision.


./Mark