Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-routing-02
"McCann Peter-A001034" <pete.mccann@motorola.com> Thu, 27 August 2009 15:51 UTC
Return-Path: <pete.mccann@motorola.com>
X-Original-To: dime@core3.amsl.com
Delivered-To: dime@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 287C83A707D; Thu, 27 Aug 2009 08:51:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.411
X-Spam-Level:
X-Spam-Status: No, score=-6.411 tagged_above=-999 required=5 tests=[AWL=0.188, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bLIU+4fc-48h; Thu, 27 Aug 2009 08:51:03 -0700 (PDT)
Received: from mail128.messagelabs.com (mail128.messagelabs.com [216.82.250.131]) by core3.amsl.com (Postfix) with ESMTP id 0CA4A3A7014; Thu, 27 Aug 2009 08:51:03 -0700 (PDT)
X-VirusChecked: Checked
X-Env-Sender: pete.mccann@motorola.com
X-Msg-Ref: server-5.tower-128.messagelabs.com!1251388263!7876443!1
X-StarScan-Version: 6.1.3; banners=-,-,-
X-Originating-IP: [129.188.136.8]
Received: (qmail 28674 invoked from network); 27 Aug 2009 15:51:04 -0000
Received: from motgate8.mot.com (HELO motgate8.mot.com) (129.188.136.8) by server-5.tower-128.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 27 Aug 2009 15:51:04 -0000
Received: from il06exr04.mot.com (il06exr04.mot.com [129.188.137.134]) by motgate8.mot.com (8.14.3/8.14.3) with ESMTP id n7RFp3I6011009; Thu, 27 Aug 2009 08:51:03 -0700 (MST)
Received: from il06vts02.mot.com (il06vts02.mot.com [129.188.137.142]) by il06exr04.mot.com (8.13.1/Vontu) with SMTP id n7RFp3Ms017805; Thu, 27 Aug 2009 10:51:03 -0500 (CDT)
Received: from de01exm70.ds.mot.com (de01exm70.am.mot.com [10.176.8.26]) by il06exr04.mot.com (8.13.1/8.13.0) with ESMTP id n7RFp2ec017799; Thu, 27 Aug 2009 10:51:02 -0500 (CDT)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 27 Aug 2009 11:50:41 -0400
Message-ID: <274D46DDEB9F2244B2F1EA66B3FF54BC0582E7AC@de01exm70.ds.mot.com>
In-Reply-To: <1A12DEAF-C84D-4789-B9DB-F1D2CDA98474@gmail.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: Gen-ART Review of draft-ietf-dime-nai-routing-02
Thread-Index: Acogpb4UXI0SvO6TRfyd7KrEE6AtKQGiFa4w
References: <274D46DDEB9F2244B2F1EA66B3FF54BC05685EA8@de01exm70.ds.mot.com> <4C124F82-50C8-4520-B3FE-7A4420C4DFDB@gmail.com> <274D46DDEB9F2244B2F1EA66B3FF54BC05686338@de01exm70.ds.mot.com> <1A12DEAF-C84D-4789-B9DB-F1D2CDA98474@gmail.com>
From: McCann Peter-A001034 <pete.mccann@motorola.com>
To: jouni korhonen <jouni.nospam@gmail.com>, "Dan (Dan) Romascanu" <dromasca@avaya.com>
X-CFilter-Loop: Reflected
Cc: dime@ietf.org, gen-art@ietf.org, draft-ietf-dime-nai-routing.all@tools.ietf.org
Subject: Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-routing-02
X-BeenThere: dime@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Diameter Maintanence and Extentions Working Group <dime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dime>
List-Post: <mailto:dime@ietf.org>
List-Help: <mailto:dime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dime>, <mailto:dime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Aug 2009 15:51:04 -0000
Thanks, Jouni. This version addresses all my comments. -Pete jouni korhonen wrote: > Hi Pete, > > I have updated the I-D based on your comments. The -03 version should > be available readily in draft repositories. > > Cheers, > Jouni > > > > On Aug 4, 2009, at 8:41 PM, McCann Peter-A001034 wrote: > >> Hi, Jouni, >> >> Thanks, I went back and re-read Section 2.8 of RFC 3588 and refreshed >> my understanding of Diameter Answer routing. You are correct that >> the reverse path routing is taken care of by the transaction state. >> Perhaps you could add one sentence about the Answer routing with a >> reference to Section 2.8 of RFC 3588? >> >> I suppose using the Application ID for expressing support for the >> feature is ok if that is the will of the working group. >> >> -Pete >> >> jouni korhonen wrote: >>> Hi Peter, >>> >>> Thanks for the review. See my comments inline. >>> >>> >>> On Aug 3, 2009, at 9:17 PM, McCann Peter-A001034 wrote: >>> >>>> I have been selected as the General Area Review Team (Gen-ART) >>>> reviewer for this draft (for background on Gen-ART, please see >>>> http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html). >>>> >>>> Please resolve these comments along with any other Last Call >>>> comments you may receive. >>>> >>>> Document: draft-ietf-dime-nai-routing-02 >>>> Reviewer: Pete McCann >>>> Review Date: 2009-08-03 >>>> IETF LC End Date: 2009-08-04 >>>> IESG Telechat date: unknown >>>> >>>> Summary: Two major issues need discussion >>>> >>>> >>>> Major issues: >>>> >>>> The draft seems to address only routing of Request commands. What >>>> about Answers? Are Diameter proxies required to re-write the >>> >>> Answers follow the reverse path the request traversed. The answers >>> are processed according to base RFC3588. >>> >>>> Origin-Realm and Origin-Host AVPs as the request gets routed? >>> >>> No. Both Origin-Realm and Origin-Host correspond to the entity that >>> originated the request. >>> >>>> Are they required then to maintain state to map the responses back >>>> to the originating realm? The processing rules seem to strip off >>> >>> Not really. Intermediating agents only need to maintain a >>> transaction state. This is the same as required for normal RFC3588 >>> request-answer processing. >>> >>>> the decoration from the NAI; there might be a need for the home AAA >>>> server to know the path that was taken through the network (routing >>>> the Answer commands is only one possible reason). Maybe the >>>> solution is to provide a decorated Origin-Realm that is recomputed >>>> by each hop. >>> >>> RFC3588 Route-Record AVP already provides this information. I see no >>> reason to go any further here regarding to changes/enhancements to >>> RFC3588 answer processing. >>> >>> >>>>> >>>>> 4.2. Ensuring Backwards Compatibility >>>>> >>>>> Implementations compliant to this specification MUST define a new >>>>> Diameter application. This requirement is set to guarantee >>>>> backwards compatibility with existing Diameter implementations, >>>>> applications and deployments. Diameter agents not compliant with >>>>> this specification will not advertise support for these new >>>>> applications that implement the enhanced routing solution based on >>>>> Decorated NAIs and will therefore be bypassed. >>>> >>>> This requirement troubles me; does this mean that every Diameter >>>> application will need to define a whole set of Application-IDs, >>>> based on the cross-product of every feature that gets introduced? >>>> Maybe this is a general problem with Diameter application >>>> versioning, and it's too late to fix it. Is there a better way to >>>> somehow indicate support for this feature? >>> >>> It indeed is a general issue with Diameter application versioning >>> (some SDOs have introduced their own versioning schemes to avoid >>> defining new applications for e.g. every new release). There was >>> lengthy discussion of possible choices how to solve it for this I-D. >>> Requiring a new application seemed to be the easiest way to get >>> forward. Generally, one application can/should include several "new >>> features" so the explosion on applications should not become a >>> problem.. >>> >>>> >>>> Minor issues: >>>> >>>> >>>> Nits/editorial comments: >>>> >>>> End of Section 3: >>>> >>>>> [RFC5113] Section 2.3. also discusses NAI decoration related >>>>> issues with EAP [RFC3748] in general. >>>> Seems there is an extra period after "Section 2.3". Suggest >>>> changing the reference pointer to text, i.e., >>>>> Section 2.3 of RFC5113 also discusses NAI decoration related >>>>> issues with EAP [RFC3748] in general. >>>> >>>> Section 4.1: >>>> >>>>> an uniform >>>> SHOULD BE: >>>>> a uniform >>>> >>>> Section 6: >>>>> In this case the NAS to the Diameter server AAA communication rely >>>> on >>>> SHOULD BE: >>>>> In this case the NAS to Diameter server AAA communication relies >>>>> on >>> >>> Thanks. Will fix these. >>> >>> Cheers, >>> Jouni
- [Dime] Gen-ART Review of draft-ietf-dime-nai-rout… McCann Peter-A001034
- Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-… jouni korhonen
- Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-… McCann Peter-A001034
- Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-… jouni korhonen
- Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-… jouni korhonen
- Re: [Dime] Gen-ART Review of draft-ietf-dime-nai-… McCann Peter-A001034