Re: [dispatch] AD Evaluation of draft-pd-dispatch-msrp-websocket

"Ben Campbell" <ben@nostrum.com> Fri, 10 June 2016 22:52 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: dispatch@ietfa.amsl.com
Delivered-To: dispatch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90E9712D9BC for <dispatch@ietfa.amsl.com>; Fri, 10 Jun 2016 15:52:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.326
X-Spam-Level:
X-Spam-Status: No, score=-3.326 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.426] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j6FZ5aa-IIXN for <dispatch@ietfa.amsl.com>; Fri, 10 Jun 2016 15:52:09 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 451E012D7E2 for <dispatch@ietf.org>; Fri, 10 Jun 2016 15:52:09 -0700 (PDT)
Received: from [10.0.1.4] (cpe-66-25-7-22.tx.res.rr.com [66.25.7.22]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id u5AMq8AZ035311 (version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Jun 2016 17:52:08 -0500 (CDT) (envelope-from ben@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host cpe-66-25-7-22.tx.res.rr.com [66.25.7.22] claimed to be [10.0.1.4]
From: Ben Campbell <ben@nostrum.com>
To: draft-pd-dispatch-msrp-websocket.all@tools.ietf.org
Date: Fri, 10 Jun 2016 17:52:08 -0500
Message-ID: <C1ACBCEA-BC77-4409-8BD7-D7C39CE9ECA4@nostrum.com>
In-Reply-To: <9957D411-C669-4490-9198-18F27A5650A7@nostrum.com>
References: <9957D411-C669-4490-9198-18F27A5650A7@nostrum.com>
MIME-Version: 1.0
Content-Type: text/plain; format="flowed"
X-Mailer: MailMate (1.9.4r5234)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/CQYAcptdAA09TpF9UnodCcDz03o>
Cc: DISPATCH <dispatch@ietf.org>
Subject: Re: [dispatch] AD Evaluation of draft-pd-dispatch-msrp-websocket
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch/>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jun 2016 22:52:11 -0000

One more thing: IDNits emits the following:

  -- The document seems to contain a disclaimer for pre-RFC5378 work, 
and may
      have content which was first submitted before 10 November 2008.  
The
      disclaimer is necessary when there are original authors that you 
have
      been unable to contact, or if some do not wish to grant the BCP78 
rights
      to the IETF Trust.  If you are able to get all authors (current 
and
      original) to grant those rights, you can and should remove the
      disclaimer; otherwise, the disclaimer is needed and you can ignore 
this
      comment. (See the Legal Provisions document at
      http://trustee.ietf.org/license-info for more information.)


. Is any part of the document that old? I suspect this is due to the 
update of 4975 and 4976. Do you incorporate substantial text or examples 
from those RFCs? If not, I'm not sure we need the disclaimer.

(I vaguely recall discussing this before, but maybe that was for a 
different MSRP related draft.)


Ben.

On 10 Jun 2016, at 17:41, Ben Campbell wrote:

> Hi,
>
> This is my AD Evaluation of draft-pd-dispatch-msrp-websocket. I have a 
> few editorial comments, but nothing that should block going to IETF 
> last call. I will request the last call shortly.
>
> Thanks!
>
> Ben.
>
> -----------------------
>
> -1, last paragraph: Consider citing RFC4976 for "MSRP relay". (I also 
> suggest citations to 4975 and 4976 when you talk about "normal" 
> clients and relays.
>
> -5.1, first paragraph: "...messages MUST be routed
>    via an MSRP WebSocket Server"
>
> This seems more a statement of fact than a normative requirement. That 
> is, it is an implication of the fact that websocket clients cannot 
> directly connect to other websocket clients. Please consider removing 
> the upper-case MUST.
>
> - 5.3.1. 4th paragraph (1st after numbered list): s/event/even