Re: [dispatch] SIP-CLF: text versus binary

Adam Roach <adam@nostrum.com> Fri, 01 May 2009 15:22 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: dispatch@core3.amsl.com
Delivered-To: dispatch@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id C8E863A708B for <dispatch@core3.amsl.com>; Fri, 1 May 2009 08:22:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.562
X-Spam-Level:
X-Spam-Status: No, score=-2.562 tagged_above=-999 required=5 tests=[AWL=0.038, BAYES_00=-2.599, SPF_PASS=-0.001]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ee7pcLuv1jwp for <dispatch@core3.amsl.com>; Fri, 1 May 2009 08:21:59 -0700 (PDT)
Received: from nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by core3.amsl.com (Postfix) with ESMTP id 2F2C33A6FA9 for <dispatch@ietf.org>; Fri, 1 May 2009 08:21:58 -0700 (PDT)
Received: from [172.16.3.231] (vicuna-alt.estacado.net [75.53.54.121]) (authenticated bits=0) by nostrum.com (8.14.3/8.14.3) with ESMTP id n41FNK50023379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 May 2009 10:23:21 -0500 (CDT) (envelope-from adam@nostrum.com)
Message-ID: <49FB13E8.2070108@nostrum.com>
Date: Fri, 01 May 2009 10:23:20 -0500
From: Adam Roach <adam@nostrum.com>
User-Agent: Postbox 1.0b11 (Macintosh/2009041623)
MIME-Version: 1.0
To: Eric Burger <eburger@standardstrack.com>
References: <AF689C4E-9D79-4C82-87D5-7623D7A08007@standardstrack.com>
In-Reply-To: <AF689C4E-9D79-4C82-87D5-7623D7A08007@standardstrack.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Received-SPF: pass (nostrum.com: 75.53.54.121 is authenticated by a trusted mechanism)
Cc: dispatch@ietf.org
Subject: Re: [dispatch] SIP-CLF: text versus binary
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dispatch>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 May 2009 15:22:01 -0000

Eric Burger wrote:
> I would humbly offer that the number of iterations it took for Theo
> (super awesome coder), Adam (truly awesome coder), and Vijay (above
> average coder) to get a half decent binary implementation of a CLF
> writer and reader highlights the argument for a text-based LOG file.

Vijay's initial implementation was pretty much spot-on, with one easily 
fixed exception. Improvements past that point were pretty much 
incremental, minor, and inconsequential in the grand order of things 
(except for Theo's last change, which is really just Theo working some 
deep voodoo magic that would apply equally to text and binary).

In either case, the speed of processing one versus the other stands at 
5x to 10x by any reasonable metric.

> Imagine what an average coder would do.

Any coder sufficiently competent to get a SIP parser even halfway right 
should be able to code this in their sleep.


Bob Penfield wrote:
 > We could eliminate the implementation issues by including the code in 
 > the RFC.

I like that idea. I'll adapt my perl script to a library and add it as 
an appendix to the next version of the binary CLF document (presuming 
there's any reason to produce a "next version").

/a