Re: [DMM] Review of draft-ietf-dmm-lma-controlled-mag-params-02
"Dhananjay Patki (dhpatki)" <dhpatki@cisco.com> Thu, 22 December 2016 09:35 UTC
Return-Path: <dhpatki@cisco.com>
X-Original-To: dmm@ietfa.amsl.com
Delivered-To: dmm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CD4C12973D; Thu, 22 Dec 2016 01:35:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.622
X-Spam-Level:
X-Spam-Status: No, score=-17.622 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-3.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84own4RuHbCw; Thu, 22 Dec 2016 01:35:17 -0800 (PST)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E123B1293E4; Thu, 22 Dec 2016 01:35:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3728; q=dns/txt; s=iport; t=1482399316; x=1483608916; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=sD7nLBzMinGFHjrCes6pY4+PQs0A+7WUAKpmN+C/59E=; b=MQPeJ4M52aLEj1McTU6SXrzUziTpUE7Jhb8lZAHloKAQD3XkCSbleSwf Ed1I2dhp1poUeSl0HPLZpy3vA2uX5gS0yclgwqiHpozoy5KOeCGWvP723 jJ5zZX818xMymcUtVCM5Ana+bLs2L9wrKz0+1J4/jH9IszG+ofo1Qgb9w U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DOAgATnltY/5hdJa1eGQEBAQEBAQEBAQEBBwEBAQEBgzUBAQEBAR+BZAekGod3jR2CCYYiAhqBTUATAQIBAQEBAQEBYiiEaAEBAQQjEUUMBAIBCA4DAwECAwImAgICHxEVCAgCBAENBYhRAxipH4IohzgNC4MyAQEBAQEBAQEBAQEBAQEBAQEBAQEBHYELhSuBfQiCVIJIgXiDBC2CMAWIbIYYhgOFOzUBjUGDd4NNjQSJbIQ4hA4BIAE1gSo8AYVScgGHTIENAQEB
X-IronPort-AV: E=Sophos;i="5.33,387,1477958400"; d="scan'208";a="188421166"
Received: from rcdn-core-1.cisco.com ([173.37.93.152]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2016 09:35:09 +0000
Received: from XCH-RTP-017.cisco.com (xch-rtp-017.cisco.com [64.101.220.157]) by rcdn-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id uBM9Z9vw030894 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 22 Dec 2016 09:35:09 GMT
Received: from xch-rtp-018.cisco.com (64.101.220.158) by XCH-RTP-017.cisco.com (64.101.220.157) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 22 Dec 2016 04:35:08 -0500
Received: from xch-rtp-018.cisco.com ([64.101.220.158]) by XCH-RTP-018.cisco.com ([64.101.220.158]) with mapi id 15.00.1210.000; Thu, 22 Dec 2016 04:35:08 -0500
From: "Dhananjay Patki (dhpatki)" <dhpatki@cisco.com>
To: Ralph Droms <rdroms.ietf@gmail.com>, "int-dir@ietf.org" <int-dir@ietf.org>
Thread-Topic: Review of draft-ietf-dmm-lma-controlled-mag-params-02
Thread-Index: AQHSW7cfUHCsrEmlcU+8RySvIxIQxqEUZe8A
Date: Thu, 22 Dec 2016 09:35:08 +0000
Message-ID: <41861300-B1A7-4901-824F-6FBF49911948@cisco.com>
References: <148234451761.12610.14633531491990867033.idtracker@ietfa.amsl.com>
In-Reply-To: <148234451761.12610.14633531491990867033.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.65.93.179]
Content-Type: text/plain; charset="utf-8"
Content-ID: <467743A20C6DF847BCB94641A0AF2D53@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dmm/siq1aQ7C1RnyJxKMJOWOycFtx1k>
Cc: "draft-ietf-dmm-lma-controlled-mag-params.all@ietf.org" <draft-ietf-dmm-lma-controlled-mag-params.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "dmm@ietf.org" <dmm@ietf.org>
Subject: Re: [DMM] Review of draft-ietf-dmm-lma-controlled-mag-params-02
X-BeenThere: dmm@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Distributed Mobility Management Working Group <dmm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dmm>, <mailto:dmm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dmm/>
List-Post: <mailto:dmm@ietf.org>
List-Help: <mailto:dmm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dmm>, <mailto:dmm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Dec 2016 09:35:20 -0000
Hello, Thanks for the review. We will address the comments and get back with a new version of the draft. -- Regards, Dhananjay -----Original Message----- From: Ralph Droms <rdroms.ietf@gmail.com> Date: Wednesday, 21 December 2016 at 11:51 PM To: "int-dir@ietf.org" <int-dir@ietf.org> Cc: "dmm@ietf.org" <dmm@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-dmm-lma-controlled-mag-params.all@ietf.org" <draft-ietf-dmm-lma-controlled-mag-params.all@ietf.org> Subject: Review of draft-ietf-dmm-lma-controlled-mag-params-02 Resent-From: <alias-bounces@ietf.org> Resent-To: <dhpatki@cisco.com>, <sgundave@cisco.com>, <jonghyouk@smu.ac.kr>, <fuqiao1@outlook.com>, <lyle.t.bertz@sprint.com>, <jouni.nospam@gmail.com>, <maxpassion@gmail.com>, <suresh.krishnan@ericsson.com>, <terry.manderson@icann.org>, Dapeng Liu <max.ldp@alibaba-inc.com>, <max.ldp@alibaba-inc.com> Resent-Date: Wednesday, 21 December 2016 at 11:51 PM Reviewer: Ralph Droms Review result: Ready with Issues Major issues: None Minor issues: The mechanism described in this document is fairly simple. I recommend that the specific semantics of the use of the parameter options should be explained with greater clarity to ensure correct and interoperable implementations. For example, I found the description of LMA behavior in section 5.1 to be quite convoluted and confusing. Putting the "if...then...else" construct in two bullets seemed obtuse. In the first bullet, the LMA "SHOULD include" the sub-option. Are there circumstances under which the LMA would not include the sub-option and, if so, what are those circumstances? Can the LMA decide, perhaps for efficiency, to return the sub-option in only, say, one of ten responses to the MAG? Is there a specific reason for encoding the LAM Controlled MAG Session Parameters as sub-options under the LAM-Controlled-MAG-Parameters option? Will additional sub-options be defined in the future? Editorial issues. For clarity, the document should use acronyms and names for system components in a consistent way: use acronyms throughout and expand the acronym on first use. For example, LMA and "local mobility anchor" are used interchangeably throughout the document, which this reviewer found to be distracting. What is the expansion for "PBU"? The use of the "Configuration Variables" defined in section 4 is repeated in section 5.1. To avoid internal inconsistency, I recommend that the use of the variable be described only once, with internal pointers to that text from other places in the document. In section 6, it would help the reader to include the name of the registry to be modified in the first bullet.
- [DMM] Review of draft-ietf-dmm-lma-controlled-mag… Ralph Droms
- Re: [DMM] Review of draft-ietf-dmm-lma-controlled… Dhananjay Patki (dhpatki)
- Re: [DMM] [Int-dir] Review of draft-ietf-dmm-lma-… Suresh Krishnan
- Re: [DMM] [Int-dir] Review of draft-ietf-dmm-lma-… Sri Gundavelli (sgundave)