Re: [DNSOP] [Ext] Dnsdir early review of draft-ietf-dnsop-rfc7958bis-00

[Paul Hoffman <[e-mail]>]

On Feb 6, 2024, at 07:17, Florian Obser via Datatracker <[e-mail]> wrote:
> 
> Reviewer: Florian Obser
> Review result: Ready with Nits
> 
> I have been selected as the DNS Directorate reviewer for this draft. The
> DNS Directorate seeks to review all DNS or DNS-related drafts as
> they pass through IETF last call and IESG review, and sometimes on special
> request. The purpose of the review is to provide assistance to the ADs.
> For more information about the DNS Directorate, please see
> https://urldefense.com/v3/__https://wiki.ietf.org/en/group/dnsdir__;!!PtGJab4!6S9q28SHczOYdpnCKXaXJu1oilTfH7vLs0xQf_RWxiIQcNuTmGpm3Twl69l62UsGqODyeK6cR8oBuSNSRi3HNmvz$ [wiki[.]ietf[.]org]
> 
> I think the document is basically ready. I spotted a few nits, feel free to
> ignore as many as you like.
> 
> * Abstract
> 
>> This document describes the format and publication mechanisms IANA
>> intends to use to distribute the DNSSEC trust anchors.
> 
> while in "1. Introduction" we have:
> 
>> This document describes the formats and distribution methods of DNSSEC
>> trust anchors that have been used by IANA for the root zone of the DNS
>> since 2010.
> 
> Which one is it? Maybe this would be better:
> 
>> This document describes the format and publication mechanisms IANA
>> uses to distribute the DNSSEC trust anchors.

Yep, that's better for the abstract.

> 
> * 1.  Introduction
> 
>> A detailed description of corresponding
>> key management practices can be found in [DPS], which can be
>> retrieved from the IANA Repository at <https://www.iana.org/dnssec/>.
> 
> It seems redundant to add a reference as [DPS] and then provide a link
> in-line. Additionally the reference and in-line link are different:
> https://www.iana.org/dnssec/
> vs.
> https://www.iana.org/dnssec/procedures
> 
> Maybe just shorten it to
> 
>> A detailed description of corresponding key management practices can
>> be found in [DPS].

Fair point.

> 
> * 2. IANA DNSSEC Root Zone Trust Anchor Formats and Semantics
> 
>> IANA publishes trust anchors for the root zone as an XML document
>> that contains the hashes of the DNSKEY records.
> 
> since IANA wishes to also publish the DNSKEY itself, maybe this is better:
> 
>> IANA publishes trust anchors for the root zone as an XML document
>> that contains the hashes of the DNSKEY records and optionally the keys
>> from the DNSKEY records.

Good catch!

> 
> * Appendix A.  Historical Note
> 
> Missing text:
>> The second KSK for use in the root zone of the DNS was [ MORE GOES
>> HERE ].
> 

Yep, still TBD. Will fix.

Thanks!

--Paul Hoffman