[DNSOP] Dnsdir early review of draft-ietf-dnsop-structured-dns-error-03

Di Ma via Datatracker <noreply@ietf.org> Mon, 26 June 2023 05:58 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dnsop@ietf.org
Delivered-To: dnsop@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 06066C1575BD; Sun, 25 Jun 2023 22:58:57 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Di Ma via Datatracker <noreply@ietf.org>
To: dnsdir@ietf.org
Cc: dnsop@ietf.org, draft-ietf-dnsop-structured-dns-error.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.3.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168775913699.55897.2271126507895695243@ietfa.amsl.com>
Reply-To: Di Ma <madi@juicybun.cn>
Date: Sun, 25 Jun 2023 22:58:57 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/OhEHkM-UGfIwuiUw2EHVlFsKmZM>
Subject: [DNSOP] Dnsdir early review of draft-ietf-dnsop-structured-dns-error-03
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2023 05:58:57 -0000

Reviewer: Di Ma
Review result: Ready with Nits

Generally speaking, I think the extension to DNS proposed by this document will
not affect DNS operations adversely since it is common and mature to extend
EDNS0 to carry DNS signaling information as far as I observed.

I have got several technical comments for the authors to consider:

As stated in section 5.2 “If EDE support is signaled in the query the
server MUST NOT return the "Forged Answer" extended error code...”, is “Forged
Answer” the only code that is not allowed? I suggest authors articulate the
rule not just an instance, in order to facilitate the consistency among
different implementations.

As in section 5.3, “On receipt of a DNS response with an EDE option from a DNS
responder, the following actions are performed on the EXTRA-TEXT field”, are
all those “actions” ordered or unordered? I think it needs to be specified.

In section 6, RPZ is not standardized by IETF. I suggest removing
“Interoperation with RPZ Servers” or moving it to appendix since this draft is
intended to be a standards track RFC.

And I also have some editorial comments:

In section 4, “The contact details of the IT/InfoSec team to report
mis-classified DNS filtering. This field is structured as an array of contact
URIs (e.g., tel, sips, https). At least one contact URI MUST be included. This
field is mandatory.” It is necessary to reference RFCs to “tel, sips, https”.

In section 5.3, there is an in-paragraph long space breaking “If a DNS client
has enabled opportunistic privacy profile (Section 5 of [RFC8310]) for DoT, the
DNS client will either fall back to an...” ...and “encrypted connection without
authenticating the DNS server...”.

In section 5.3, the first action is described as “Verify the field contains
valid JSON.” which is the only segment using a verb to describe the very
action. I think it would be better to align all the action description wording.