Re: [DNSOP] SVCB ALPN value presentation format

Mark Andrews <marka@isc.org> Tue, 16 June 2020 02:04 UTC

Return-Path: <marka@isc.org>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60E0C3A0F8E for <dnsop@ietfa.amsl.com>; Mon, 15 Jun 2020 19:04:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T_rdUVhawBP9 for <dnsop@ietfa.amsl.com>; Mon, 15 Jun 2020 19:04:48 -0700 (PDT)
Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC5963A0F87 for <dnsop@ietf.org>; Mon, 15 Jun 2020 19:04:48 -0700 (PDT)
Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id E48F53AB007; Tue, 16 Jun 2020 02:04:47 +0000 (UTC)
Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id D7552160072; Tue, 16 Jun 2020 02:04:47 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id C5E95160073; Tue, 16 Jun 2020 02:04:47 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0pjewBt0jIbm; Tue, 16 Jun 2020 02:04:47 +0000 (UTC)
Received: from [172.30.42.68] (unknown [49.2.101.160]) by zmx1.isc.org (Postfix) with ESMTPSA id CA398160072; Tue, 16 Jun 2020 02:04:46 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
From: Mark Andrews <marka@isc.org>
In-Reply-To: <7172A73F-DF24-4375-A4DF-F13426A7C96C@akamai.com>
Date: Tue, 16 Jun 2020 12:04:43 +1000
Cc: Ben Schwartz <bemasc=40google.com@dmarc.ietf.org>, dnsop <dnsop@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <CDC48C93-8634-489F-A0A7-A4D79CE1170E@isc.org>
References: <80758944-FC52-4349-9C8B-EF4083C62F1B@akamai.com> <CAHbrMsDcvJnij9UmxJ_JBMCCxYUzq=YcG+YEd5JHVyB_H3g6Rw@mail.gmail.com> <7172A73F-DF24-4375-A4DF-F13426A7C96C@akamai.com>
To: Larry Campbell <lcampbel=40akamai.com@dmarc.ietf.org>
X-Mailer: Apple Mail (2.3445.9.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/heQkpK0r5WPKrwYhS1HcuUDj-bc>
Subject: Re: [DNSOP] SVCB ALPN value presentation format
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2020 02:04:50 -0000


> On 14 Jun 2020, at 05:01, Larry Campbell <lcampbel=40akamai.com@dmarc.ietf.org> wrote:
> 
> I think there's an implementation difficulty. Consider:
> 
> 1.  alpn=h2		; clear enough
> 2.  alpn="h2"		; should be equivalent
> 3.  alpn=\h\2		; should also be equivalent
> 4.  alpn=h2,h3		; ok (two values)
> 5.  alpn="h2","h3"	; should be equivalent

No, as it is key=quoted-string as per 2.1.1 not key=quoted-string(,quoted-string\)*

> 6.  alpn="h2,h3"	; malformed? or a single alpn value of h2,h3? or two three-character values, "h2 and h3”?

this is correct

> 7.  alpn=h2\,h3,h4	; how should this be parsed?

0x05 0x68 0x32 0xc2 0x68 0x33 0x02 0x68 0x34

> Section 2.1.1 tempts one to build the obvious implementation of using one's existing character-string parser, and then passing the parsed character-string to the individual handler for each key type. The alpn and ipv*hint handlers are going to want to split that character-string on comma. That would treat #6 as two two-character values (h2,h3). But #7 is problematic: the generic character-string parser would remove the backslash, and then the alpn handler would treat this as three alpn values when you probably wanted just two

When you are also parsing domain names you have to deal with \. being a literal period not a domain separator.
exa\.mple.com and “exa\.mple.com” aree being two labels ‘exa.mple’ and ‘com’.  This is not really different.

That said we do need to address this issue.

In BIND we extract quoted-string preserving the escapes (except for ‘\”’) then pass the token to a domain name parser or a text parser. Having ‘key=‘ preceding the quoted-string is more of a issue and we have to shift modes mid-token.

> We could make a special character-string parser for alpn and ipv*hint, that handles commas, but it feels odd to have to use a special parser just for certain key types. However, if we must allow commas in alpn names, then we have no choice.

You need to reparse value for port, alpn, ipv*hint,

> Perhaps it would be clearer to simply remove the three paragraphs of section 2.1.1 beginning with "The presentation for for SvcFieldValue is..." and ending with "...not limited to 255 characters.)". Since the previous paragraph says "Values are in a format specific to the SvcParamKey", perhaps it would be best to leave the description of each value format in the appropriate part of section 6 and for section 2.1.1 to discuss only how to represent and parse unrecognized keys.


> 
> To keep the implementation simple, the alpn value could be defined as a comma-separated list of sequences of printing ASCII characters, with embedded comma represented as \, backslash as \\, and all nonprinting and non-ASCII characters reprsented as \nnn. (In other words, the full generality of character-string, particularly double-quotes, is not needed here.
> 
> The other comma-separated value types -- ipv4hint and ipv6hint -- do not have this difficulty; they also don't need the full generality of character-string handling, because the individual values can contain only hex digits, periods, and colons, so their specification and implementation can be much simpler.
> 
> And I think section 2.1.1 would be clearer if
> 
>    using decimal escape codes (e.g. \255) when necessary
> 
> were replaced by
> 
>    using decimal escape codes (e.g. \255) for all nonprinting and non-ASCII characters, and using \\ to represent backslash
> 
> - lc
> 
> 
>> On Jun 13, 2020, at 11:25, Ben Schwartz <bemasc=40google.com@dmarc.ietf.org> wrote:
>> 
>> Larry,
>> 
>> I think that's the intent of the current text, especially the ABNF for "element".  If you think it's unclear, we should adjust it.  Please suggest text!
>> 
>> --Ben Schwartz
>> 
>> On Sat, Jun 13, 2020, 10:53 AM Larry Campbell <lcampbel=40akamai.com@dmarc..ietf.org> wrote:
>> Seciont 6.1 says:
>> 
>>> The presentation value of "alpn" is a comma-separated list of one or more "alpn-id"s. Any commas present in the protocol-id are escaped by a backslash:
>>> 
>>>    escaped-octet = %x00-2b / "\," / %x2d-5b / "\\" / %x5D-FF
>>>    escaped-id = 1*(escaped-octet)
>>>    alpn-value = escaped-id *("," escaped-id)
>> 
>> If I read this correctly, the presentation value is allowed to contain nulls and control characters. This seems likely to make such records very difficult to edit. Wouldn't it be better to require these to be encoded as \nnn?
>> 
>> - lc
>> 
>> _______________________________________________
>> DNSOP mailing list
>> DNSOP@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnsop
> 
> _______________________________________________
> DNSOP mailing list
> DNSOP@ietf.org
> https://www.ietf.org/mailman/listinfo/dnsop

-- 
Mark Andrews, ISC
1 Seymour St., Dundas Valley, NSW 2117, Australia
PHONE: +61 2 9871 4742              INTERNET: marka@isc.org