[DNSOP] Tsvart last call review of draft-ietf-dnsop-dns-tcp-requirements-12

[Mirja Kühlewind via Datatracker <[e-mail]>]

Reviewer: Mirja Kühlewind
Review result: Ready with Issues

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
[e-mail] if you reply to or forward this review.

Thanks for the well-written document! I have a couple of points below regarding
the recommend TCP tuning in section 4. Other parts of the document don't seem
to have any transport issues and are clear to me.

First a minor comment here:
"TCP connection timeout, which is often around 60-120 seconds."
I guess this value relates to an RTO of 1s and 6 SYN retries which is the
default in Linux. Maybe say that...? I also recommend to add a link to RFC6298.

And a more general comment on section 4.2: this section takes about various
limits but doesn't recommend any values. I understand that there is not a
one-fits-all solution here but not knowing how to set these values correctly
might scared people aways from supporting TCP. So I think having a discussion
either of default values or how to derives these values based on a certain
configuration would be a very valuable contribution in this document.

Similarly section 4.3 talks about tuning net.ipv4.tcp_fin_timeout, however, it
doesn't provide any guidance on how to tune it; Linux recommend a value of
15-30 seconds. Also setting net.ipv4.tcp_fin_timeout to a too low value and
net.ipv4.tcp_tw_reuse to 1 can cause trouble and should not be done for the
general case. So I don't think that guidance is appropriate without further
discussion of the risks. Please reconsider this part of the document!

On section 4.4, maybe mention TCP fast open here again as well?