Re: [dnssd] Review of draft-ietf-dnssd-srp-05

Ted Lemon <mellon@fugue.com> Wed, 18 November 2020 21:39 UTC

Return-Path: <mellon@fugue.com>
X-Original-To: dnssd@ietfa.amsl.com
Delivered-To: dnssd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21DDB3A0D2C for <dnssd@ietfa.amsl.com>; Wed, 18 Nov 2020 13:39:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.887
X-Spam-Level:
X-Spam-Status: No, score=-1.887 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, NO_DNS_FOR_FROM=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fugue-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hB2a2f5BjPTJ for <dnssd@ietfa.amsl.com>; Wed, 18 Nov 2020 13:39:43 -0800 (PST)
Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 415593A0D2B for <dnssd@ietf.org>; Wed, 18 Nov 2020 13:39:42 -0800 (PST)
Received: by mail-qv1-xf35.google.com with SMTP id v20so1838982qvx.4 for <dnssd@ietf.org>; Wed, 18 Nov 2020 13:39:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fugue-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=NDu6IAOMZXCFOrqW9PlVNQ1zmHzZAQCYk/t9Cua3oAg=; b=AeUUhqprknHsuNJI9gJ8l+3ET362YD7TEWGHUPG5AVHkuwsFV3b6HbEgbV5dzvxda7 PKbO/wGDCz8fjK282wJwyGDcjmx86hv/chfgfa5PwQrNkISbLvJCMKJAY+yOjtvfnxzp tNFAatvm5tis4Nc2yhadRimPCXqu6dOu1Na/eYXloyCJSCWr5ur3pqoyUjpPxLat+6w0 gY9wv/k0/duK31wMFqLRORFBiErQIEvvsW7op9JhdJazu1qHTxXkGfohJEVLvUNiTwLx jp+t7Yjh0eGocMQZyelxlr0SXviO13U66YhJscB4o29UYkxJ04O0gesBvK6lAaUlmcdW EEQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=NDu6IAOMZXCFOrqW9PlVNQ1zmHzZAQCYk/t9Cua3oAg=; b=MqXGObLmIRq3AyVsMYBAAV/1+WoF3LtcNF/JcHYS18r3cX7VRTNi7MruwtY6EwKrbE GAou4UuJZSle4pHclqgFp0eyyhnicED/ZlqDTuA9l5Hg6ywYe9kVuFaq/xzUXiGHO3pa 6ETjqCAibkSYw6PwnyWBV4vClWymrinRE741p5yz2L+NnUdeWEGpJnMubf/69TAFlXCJ pNkBI2v4NEnqnpJ4Ou8fFhbIQgG/FAc+5bRQmmWWEwNGRI4l1oKN25XAoWBxm/I6Xg1Z v8H8IqaSEw9wB3j0WPhCaK3H6hEPrRMK2+FBUzb/GofIkToAFo+fNMZ7xV0Dvox1Qe4t pq7A==
X-Gm-Message-State: AOAM532G77gOv32aYRtU5CwCyIrocJAaPeFnYjZXLFS+YLj3Qw848iUZ FAayLQFxYAS8VZxcs4QdJ3nzCxEg8NTz8/WA
X-Google-Smtp-Source: ABdhPJy/f58BlXjlkMSAADth7+d89lc+yV2XuMFXaPLttzIuDot3h4AdNnIB1uTHfNRdgQo7N19wXw==
X-Received: by 2002:a05:6214:32f:: with SMTP id j15mr7441614qvu.35.1605735582033; Wed, 18 Nov 2020 13:39:42 -0800 (PST)
Received: from mithrandir.lan (c-24-91-177-160.hsd1.nh.comcast.net. [24.91.177.160]) by smtp.gmail.com with ESMTPSA id t205sm7379116qke.35.2020.11.18.13.39.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2020 13:39:40 -0800 (PST)
From: Ted Lemon <mellon@fugue.com>
Message-Id: <843154D5-2D1A-4CD6-9922-64B01FA2DC1A@fugue.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_CBBF5A56-D901-4E8E-8372-7027D8ECB1B3"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.21\))
Date: Wed, 18 Nov 2020 16:39:39 -0500
In-Reply-To: <CABXuWKtbNjwtVtiRjQwFrF=1WJ6fEUpQaUZz7iNkL4TG260MoA@mail.gmail.com>
Cc: dnssd@ietf.org
To: Manuel Amutio <mamutio@kirale.com>
References: <CABXuWKtbNjwtVtiRjQwFrF=1WJ6fEUpQaUZz7iNkL4TG260MoA@mail.gmail.com>
X-Mailer: Apple Mail (2.3654.40.0.2.21)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/pRKuhlKAuSuGB4rk65ZGBdP1NW0>
Subject: Re: [dnssd] Review of draft-ietf-dnssd-srp-05
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2020 21:39:45 -0000

Thank you for the comments, Manuel!

> /------------- Typos --------------/
> Page 9, first paragraph:
> "This key pair MUST be unique to the device" is repeated twice.
> "+" symbol appears twice.

What I get for manually applying a diff—thanks for catching it! :)

> Page 12, second paragraph:
> "Instrructions"

Got it.

> /------------- Doubts -------------/
> Page 9, section 2.4.1.1 Service Behavior:
> "the key MAY be overwritten as a result of a full reset of the device (e.g., a "factory reset")"
> 
> What happens then?

Good question. I’ve clarified:

When the device changes ownership, it may be appropriate to erase the old key and install a new one. Therefore the key MAY be overwritten as a result of a full reset of the device (e.g., a "factory reset”)

> 
> Page 10, section 2.4.2 Removing published services:
> "To remove a service registration, the client retransmits its most recent update..." 
> "However, in some cases a client may not have retained sufficient state to know that some service instance is pointing to a host that it is removing."
> 
> Then, how is it able to retransmit an update of something that no longer knows? 

The notion is that an SRP update with just the host information, and with a lease time of zero, will remove all services advertised by that host, even if the SRP client doesn’t enumerate them in the update.

I’ve re-written the text in this paragraph as follows:

SRP clients are normally expected to remove all service instances when removing a host.  However, in some cases a SRP client may not have retained sufficient state to know that some service instance is pointing to a host that it is removing.  An SRP server can assume that all service instances pointing to a host entry that's being removed are no longer valid.  Therefore, SRP servers MAY remove all service instances pointing to a host when a host is removed, even if the SRP client doesn't remove them explicitly.

> Page 15, section 2.6.2. Sleep Proxy:
> This feature conditions the location of SRP Server, right?
> If we thought in a Border Router, it would only be useful for external traffic going through BR, but not for traffic initiated in the mesh network. 
> Maybe I have misunderstood it.

Bear in mind that SRP is a general protocol specification, and stub routers, like the Thread border router, are individual use cases. I don’t think there’s any value in implementing sleep proxy service for a Thread border router—Thread already has its own way of handling sleepy end devices.

> Regarding the protocol used, I don't see a clear drawback to not allow using UDP for the constrained devices. If the DNS service allows it, I believe that this new protocol should support it too.

I also think it makes sense to use UDP for SRP registrations.

Anyway, thanks for the comments, I will be updating the draft to address your and Esko’s comments, as well as Jonathan’s comments that followed my previous update, shortly. :)