[dnssd] Lars Eggert's No Objection on draft-ietf-dnssd-srp-22: (with COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Fri, 04 August 2023 14:17 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dnssd@ietf.org
Delivered-To: dnssd@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 67076C15108A; Fri, 4 Aug 2023 07:17:30 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-dnssd-srp@ietf.org, dnssd-chairs@ietf.org, dnssd@ietf.org, dschinazi.ietf@gmail.com, dschinazi.ietf@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 11.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <169115865040.64860.17100101887405393901@ietfa.amsl.com>
Date: Fri, 04 Aug 2023 07:17:30 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/rzc7lKJv1r8TCKrO-24x9z72uJA>
Subject: [dnssd] Lars Eggert's No Objection on draft-ietf-dnssd-srp-22: (with COMMENT)
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2023 14:17:30 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-dnssd-srp-22: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dnssd-srp/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-dnssd-srp-22

CC @larseggert

## Comments

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Term `master`; alternatives might be `active`, `central`, `initiator`,
   `leader`, `main`, `orchestrator`, `parent`, `primary`, `server` (matched
   `master` rule, pattern ((\bmaster\w*\b)\w*))
 * Term `traditional`; alternatives might be `classic`, `classical`, `common`,
   `conventional`, `customary`, `fixed`, `habitual`, `historic`,
   `long-established`, `popular`, `prescribed`, `regular`, `rooted`,
   `time-honored`, `universal`, `widely used`, `widespread` (matched
   `tradition` rule, pattern ((\btradition\w*\b)\w*))

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Outdated references

Document references `draft-ietf-dnssd-advertising-proxy-02`, but `-03` is the
latest available revision.

### Grammar/style

#### Section 3.2.5.3, paragraph 1
```
the SRP server will handle this. Therefore SRP registrars MUST support compr
                                 ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Therefore".

#### Section 3.2.5.3, paragraph 3
```
oving a host. However, in some cases a SRP requestor may not have retained s
                                     ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 3.3.1.1, paragraph 3
```
A and/or AAAA records that are not of of sufficient scope to be validly publ
                                   ^^^^^
```
Possible typo: you repeated a word.

#### Section 8.4, paragraph 2
```
cally-Served Zones" subregistry of the the "Locally-Served DNS Zones" registr
                                   ^^^^^^^
```
Possible typo: you repeated a word.

#### Section 10.5, paragraph 1
```
mental edit, Tim Wattenberg for doing a SRP requestor proof-of-concept implem
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool