Re: [Doh] draft-ietf-doh-dns-over-https-04 feedback

Patrick McManus <pmcmanus@mozilla.com> Thu, 22 March 2018 11:08 UTC

Return-Path: <pmcmanus@mozilla.com>
X-Original-To: doh@ietfa.amsl.com
Delivered-To: doh@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 039501200C5 for <doh@ietfa.amsl.com>; Thu, 22 Mar 2018 04:08:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 2.101
X-Spam-Level: **
X-Spam-Status: No, score=2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_SBL_CSS=3.335, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g-uA-rENiQEB for <doh@ietfa.amsl.com>; Thu, 22 Mar 2018 04:08:24 -0700 (PDT)
Received: from linode64.ducksong.com (linode6only.ducksong.com [IPv6:2600:3c02::f03c:91ff:fe6e:e8da]) by ietfa.amsl.com (Postfix) with ESMTP id DBE901200C1 for <doh@ietf.org>; Thu, 22 Mar 2018 04:08:23 -0700 (PDT)
Received: from mail-ot0-f173.google.com (mail-ot0-f173.google.com [74.125.82.173]) by linode64.ducksong.com (Postfix) with ESMTPSA id 991593A04F for <doh@ietf.org>; Thu, 22 Mar 2018 07:08:22 -0400 (EDT)
Received: by mail-ot0-f173.google.com with SMTP id i28-v6so8974822otf.8 for <doh@ietf.org>; Thu, 22 Mar 2018 04:08:22 -0700 (PDT)
X-Gm-Message-State: AElRT7FW7bgkUpcdEyJ5kC+713R4fkHEUkdqR03AYq2IR1FUobl0ZU1L td+DN13Tg8CTo5bupeunHlGZnToZ1OIl9EELaqc=
X-Google-Smtp-Source: AG47ELuvqtJtaIuQt+Kkh/j6mX5St06ZHP6qK68zMUYh6xAamYwPw5pGM0h0I/dMcmczGZqkWHf8XiVmlz2pE5b/52k=
X-Received: by 2002:a9d:213c:: with SMTP id i57-v6mr14083214otb.85.1521716902332; Thu, 22 Mar 2018 04:08:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.74.70.143 with HTTP; Thu, 22 Mar 2018 04:08:21 -0700 (PDT)
In-Reply-To: <257cc9e5-d4f2-71df-5798-56445e189043@bellis.me.uk>
References: <96afa3b5-2925-8276-9374-082b491f4216@bellis.me.uk> <23219.34384.67213.938078@gro.dd.org> <257cc9e5-d4f2-71df-5798-56445e189043@bellis.me.uk>
From: Patrick McManus <pmcmanus@mozilla.com>
Date: Thu, 22 Mar 2018 11:08:21 +0000
X-Gmail-Original-Message-ID: <CAOdDvNrtDpxoymZLou-BGXukKMkegtP4sT=fbW2xayh0b1P8fQ@mail.gmail.com>
Message-ID: <CAOdDvNrtDpxoymZLou-BGXukKMkegtP4sT=fbW2xayh0b1P8fQ@mail.gmail.com>
To: Ray Bellis <ray@bellis.me.uk>
Cc: DoH WG <doh@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000006990ac0567fe5361"
Archived-At: <https://mailarchive.ietf.org/arch/msg/doh/jY8Ot6nmvRuXdKhUQiFL_Z_FPlI>
Subject: Re: [Doh] draft-ietf-doh-dns-over-https-04 feedback
X-BeenThere: doh@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: DNS Over HTTPS <doh.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/doh>, <mailto:doh-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/doh/>
List-Post: <mailto:doh@ietf.org>
List-Help: <mailto:doh-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/doh>, <mailto:doh-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Mar 2018 11:08:26 -0000

Thanks Ray,

imo pretty much this is what SHOULD already signals - I would phrase it as:
that's the expected behavior unless you have a really good reason you
cannot (Dave points out one really good reason - conflicting non-successful
states). Its also plausible an HTTP gateway would not have enough
information to determine more than "failure" and would want to fallback on
400 which would be less than optimal but ok. This is sort of a general
problem and I don't think the draft is overall advantaged by doing this
case by case.

on the other hand we did add some similar text around success/non-success
and how dns and http interact. That's also not strictly necessary but I
think it has a broad enough impact that it is worth doing. I would hope to
avoid doing that with a laundry list of codes (my approach is consistent
with BCP56bis )


On Thu, Mar 22, 2018 at 10:47 AM, Ray Bellis <ray@bellis.me.uk> wrote:

> On 22/03/2018 10:32, Dave Lawrence wrote:
>
> > Because it might have good reasons for replying with some other code,
> > if multiple issues exist with the request?
>
> OK, so you need to allow for HTTP protocol layer errors such as 401, etc
> which happen earlier in the stream's processing.
>
> But if it gets that far, is there any other possible response than 415?
>
> I'm not sure how to phrase it, but I think it MUST be 415 *unless* some
> other error was *already* detected (at which point I'd expect request
> processing to have been aborted anyway).
>
> Ray
>
> _______________________________________________
> Doh mailing list
> Doh@ietf.org
> https://www.ietf.org/mailman/listinfo/doh
>