Re: [Dots] Alexey Melnikov's Discuss on draft-ietf-dots-signal-channel-31: (with DISCUSS and COMMENT)

Adam Roach <adam@nostrum.com> Thu, 02 May 2019 06:59 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B2B71202F9 for <dots@ietfa.amsl.com>; Wed, 1 May 2019 23:59:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.678
X-Spam-Level:
X-Spam-Status: No, score=-1.678 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9DenNb2kVvqV for <dots@ietfa.amsl.com>; Wed, 1 May 2019 23:59:26 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88098120052 for <dots@ietf.org>; Wed, 1 May 2019 23:59:26 -0700 (PDT)
Received: from MacBook-Pro.roach.at (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x426xM2U022286 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 2 May 2019 01:59:24 -0500 (CDT) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1556780365; bh=BfZg9j9zy8Z1BoIiOdef/rBpaRi1lzpXBXzz8j7Nd2g=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=KQTMEdo6voZ7vR8bWX/uENJwHbPjQsXFVNKHCV/JVcEr4R+hKdcbEstHahvE879oc QnAZn7w/HWtReHcObHGCxKLOsCcv5L94BucOyUGBut2ePO/xv2JKW7fly86FZAuOZ3 CMBaqb7+QefXpluQBSeVij3BHdYWBjWaQ1EL90jQ=
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be MacBook-Pro.roach.at
To: mohamed.boucadair@orange.com, Alexey Melnikov <aamelnikov@fastmail.fm>, The IESG <iesg@ietf.org>
Cc: "draft-ietf-dots-signal-channel@ietf.org" <draft-ietf-dots-signal-channel@ietf.org>, Liang Xia <frank.xialiang@huawei.com>, "dots@ietf.org" <dots@ietf.org>, "dots-chairs@ietf.org" <dots-chairs@ietf.org>
References: <155672115649.991.301467308616633255.idtracker@ietfa.amsl.com> <787AE7BB302AE849A7480A190F8B93302EA68A2C@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
From: Adam Roach <adam@nostrum.com>
Message-ID: <58350da3-33fa-fc78-2338-4e104baa1725@nostrum.com>
Date: Thu, 02 May 2019 01:59:17 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <787AE7BB302AE849A7480A190F8B93302EA68A2C@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
Content-Type: multipart/alternative; boundary="------------C657DBEA5498882C43B4230C"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/ODHWWdf0mDxnZA8_3A0wklHC76Q>
Subject: Re: [Dots] Alexey Melnikov's Discuss on draft-ietf-dots-signal-channel-31: (with DISCUSS and COMMENT)
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 May 2019 06:59:28 -0000

On 5/2/19 1:54 AM, mohamed.boucadair@orange.com wrote:
>> 6) In 4.4.3:
>>
>>        {
>>         "ietf-dots-signal-channel:mitigation-scope": {
>>           "scope": [
>>             {
>>               "target-prefix": [
>>                  "2001:db8:6401::1/128",
>>                  "2001:db8:6401::2/128"
>>                ],
>>               "target-port-range": [
>>                 {
>>                   "lower-port": 80
>>                 },
>>                 {
>>                   "lower-port": 443
>>                 },
>>                 {
>>                    "lower-port": 8080
>>                 }
>>               ],
>>               "target-protocol": [
>>                  6
>>               ],
>>               "attack-status": "under-attack"
>>
>> This value is invalid, as you define this attribute as numeric on the next
>> page.
> [Med] The example is correct because the JSON encoding is as follows:
>
>     +----------------------+-------------+-----+---------------+--------+
>     | Parameter Name       | YANG        | CBOR| CBOR Major    | JSON   |
>     |                      | Type        | Key |    Type &     | Type   |
>     |                      |             |     | Information   |        |
>     +----------------------+-------------+-----+---------------+--------+
>     | attack-status        | enumeration |  29 | 0 unsigned    | String |
>

The example is incorrect because it is, as described at the end of 
section 4.4, the "JSON diagnostic notation" of CBOR, not JSON.

/a