[Dots] Lars Eggert's Discuss on draft-ietf-dots-telemetry-21: (with DISCUSS and COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Thu, 03 February 2022 09:58 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dots@ietf.org
Delivered-To: dots@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 78D743A0CD8; Thu, 3 Feb 2022 01:58:32 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-dots-telemetry@ietf.org, dots-chairs@ietf.org, dots@ietf.org, valery@smyslov.net, valery@smyslov.net
X-Test-IDTracker: no
X-IETF-IDTracker: 7.44.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <164388231173.21772.6648033844075031865@ietfa.amsl.com>
Date: Thu, 03 Feb 2022 01:58:32 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/txto64XbTMDPESHyc0-kWjuxVT4>
Subject: [Dots] Lars Eggert's Discuss on draft-ietf-dots-telemetry-21: (with DISCUSS and COMMENT)
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 09:58:33 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-dots-telemetry-21: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/blog/handling-iesg-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dots-telemetry/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

The protocol uses traffic capacities in various ways (for pipe, baseline and
connection capacity, etc.) but doesn't indicate at what layer these capacities
are to be interpreted? L2? L3? (L1??) Would the difference in header overhead
cause issues when senders and receivers use different interpretations here?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks to Robert Sparks for their General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/hTMaURDAcbvHbR1TQ52GA_fJOzk).

-------------------------------------------------------------------------------
All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

Section 2. , paragraph 10, nit:
> igation service effectiveness. Bi-directional feedback between DOTS agents i
>                                ^^^^^^^^^^^^^^^
This word is normally spelled as one.

Section 2. , paragraph 13, nit:
> ents as hints and cannot completely rely or trust the attack details conveye
>                                     ^^^^
The verb "rely" requires the preposition "on" (or "upon").

Section 3.1. , paragraph 4, nit:
> sides, can use DOTS telemetry as a feedback to automate various control and
>                                  ^^^^^^^^^^
The noun "feedback" is uncountable and doesn't require an article.

Section 3.1. , paragraph 7, nit:
> raffic from attacker traffic on a per packet basis is complex. For example, a
>                                   ^^^^^^^^^^
In this context, "per-packet" forms an adjective and is spelled with a hyphen.

Section 4.3. , paragraph 2, nit:
> son for not including these keys is because they are not included in the mes
>                                  ^^^^^^^^^^
The word "because" means "for the reason that" and thus introduces redundancy.

Section 7.1.2. , paragraph 1, nit:
>  percentile (10th percentile), mid percentile (50th percentile), high percen
>                                ^^^^^^^^^^^^^^
This word is normally spelled with a hyphen.

Section 7.2.1. , paragraph 12, nit:
>  appropriate unit is used. Total connections capacity: If the target is susce
>                                  ^^^^^^^^^^^
An apostrophe may be missing.

Section 8.1.5. , paragraph 17, nit:
> lue of the 'target-fqdn' parameter in an Uri-Query option. DOTS clients may a
>                                       ^^
Use "a" instead of "an" if the following word doesn't start with a vowel sound,
e.g. "a sentence", "a university".

Section 9. , paragraph 7, nit:
>  default "50.00"; description "Mid percentile. If set to the same value as l
>                                ^^^^^^^^^^^^^^
This word is normally spelled with a hyphen.

Section 9. , paragraph 7, nit:
> ype yang:gauge64; description "Mid percentile value."; } leaf high-percentil
>                                ^^^^^^^^^^^^^^
This word is normally spelled with a hyphen.

Section 9. , paragraph 20, nit:
> ty-protocol { description "Total connections capacity per protocol. These dat
>                                  ^^^^^^^^^^^
An apostrophe may be missing.

Section 9. , paragraph 22, nit:
> Various details that describe the on-going attacks that need to be mitigated
>                                   ^^^^^^^^
Did you mean "ongoing"?

Section 11.1. , paragraph 6, nit:
>  an IP resource. An IP resource can be be a router, a host, an IoT object, a
>                                     ^^^^^
Possible typo: you repeated a word.

Section 11.1. , paragraph 46, nit:
>  DOTS telemetry for its IP addresses but a DDoS mitigator can exchange DOTS
>                                     ^^^^
Use a comma before "but" if it connects two independent clauses (unless they
are closely connected and short).