[dtn] Robert Wilton's No Objection on draft-ietf-dtn-bpbis-29: (with COMMENT)

Robert Wilton via Datatracker <noreply@ietf.org> Tue, 01 December 2020 16:43 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dtn@ietf.org
Delivered-To: dtn@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id F07653A13B9; Tue, 1 Dec 2020 08:43:27 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Wilton via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-dtn-bpbis@ietf.org, dtn-chairs@ietf.org, dtn@ietf.org, Fred Templin <fred.l.templin@boeing.com>, fred.l.templin@boeing.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.23.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Robert Wilton <rwilton@cisco.com>
Message-ID: <160684100797.16113.13314073120352910049@ietfa.amsl.com>
Date: Tue, 01 Dec 2020 08:43:27 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/dtn/wOyF-nAkcwRNsDAp9A6K-_qqnR4>
Subject: [dtn] Robert Wilton's No Objection on draft-ietf-dtn-bpbis-29: (with COMMENT)
X-BeenThere: dtn@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Delay Tolerant Networking \(DTN\) discussion list at the IETF." <dtn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dtn>, <mailto:dtn-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dtn/>
List-Post: <mailto:dtn@ietf.org>
List-Help: <mailto:dtn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dtn>, <mailto:dtn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2020 16:43:28 -0000

Robert Wilton has entered the following ballot position for
draft-ietf-dtn-bpbis-29: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-dtn-bpbis/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Hi,

Thank you for this document.

Just a few minor observations/comments.  Quite possibly only the last comment
is actionable, and the rest are just observations.

1) Figure 2: Components of a Bundle Node

It would be nice if this diagram is not split across page boundaries, hopefully
the RFC editor can sort this out.

2) 4. Bundle Format

   Each bundle SHALL be a concatenated sequence of at least two blocks,
   represented as a CBOR indefinite-length array

It wasn't immediate obvious why this restriction was here, I presume that this
is to ensure that there is a canonical representation?

4.1.1. CRC Type
I was surprised to see that CRC-16 is also supported.  I presume that reasoning
for this is because blocks could be small, and hence the overhead from always
using CRC32 was regarded as being too much?

4.1.2. CRC
I was also slightly surprised that these are encoded as fixed length byte
strings rather than as unsigned integers.  I presume that this is done to make
them fixed length and also easier to zero out when performing the CRC
calculation?

It looks like RFC 2119 language used to define the bundle format both in
section 4 and 4.2.1.  Possibly it would be better to not use RFC 2119 language
in the intro of section 4, and instead refer to 4.2.1 for the normative
definition?

Regards,
Rob