Re: [Emu] draft-urien-eap-smartcard-20.txt

Pascal Urien <pascal.urien@gmail.com> Tue, 02 August 2011 17:09 UTC

Return-Path: <pascal.urien@gmail.com>
X-Original-To: emu@ietfa.amsl.com
Delivered-To: emu@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12AF721F86DF for <emu@ietfa.amsl.com>; Tue, 2 Aug 2011 10:09:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.173
X-Spam-Level:
X-Spam-Status: No, score=-3.173 tagged_above=-999 required=5 tests=[AWL=0.425, BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVn4RQxDiruk for <emu@ietfa.amsl.com>; Tue, 2 Aug 2011 10:09:07 -0700 (PDT)
Received: from mail-qy0-f179.google.com (mail-qy0-f179.google.com [209.85.216.179]) by ietfa.amsl.com (Postfix) with ESMTP id 27C0F21F86DC for <emu@ietf.org>; Tue, 2 Aug 2011 10:09:07 -0700 (PDT)
Received: by qyk29 with SMTP id 29so4365748qyk.10 for <emu@ietf.org>; Tue, 02 Aug 2011 10:09:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ga3+8Ks6dnLtyp6ozFQvmiTul2FDUyzhwITY7ViYGIg=; b=JYQ5jk8lrQU2DG739DiKAEtPQ0tdPCyDu79hvgMc8mUdUSDfrd9y8h/KRwa4YaPfQ5 WoaTHRUu5ItmspH69H/2Dkrp6v02bIlootGjuIqtlalVn4KnY13t+DU9A/oP1VeoXQz0 F7Jt5DLRRc4P7TBQ2Fqh7/RTRCYtRcj0qiLBQ=
MIME-Version: 1.0
Received: by 10.229.233.74 with SMTP id jx10mr673240qcb.262.1312304954775; Tue, 02 Aug 2011 10:09:14 -0700 (PDT)
Received: by 10.229.50.66 with HTTP; Tue, 2 Aug 2011 10:09:14 -0700 (PDT)
In-Reply-To: <1595-1307461282-359547@sneakemail.com>
References: <1595-1307461282-359547@sneakemail.com>
Date: Tue, 02 Aug 2011 19:09:14 +0200
Message-ID: <CAEQGKXT7wFxoe9Oztvp51td8C_7Xw1ctPcAo_8rs6Ytnx4rKFQ@mail.gmail.com>
From: Pascal Urien <pascal.urien@gmail.com>
To: Michael Thomsen <ietf-denmike@snkmail.com>
Content-Type: multipart/alternative; boundary="00163630fb8daa999604a988ce02"
Cc: emu@ietf.org
Subject: Re: [Emu] draft-urien-eap-smartcard-20.txt
X-BeenThere: emu@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "EAP Methods Update \(EMU\)" <emu.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/emu>, <mailto:emu-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/emu>
List-Post: <mailto:emu@ietf.org>
List-Help: <mailto:emu-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/emu>, <mailto:emu-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2011 17:09:08 -0000

Hi Michael,

That you very much for this review.

 The new draft, http://tools.ietf.org/html/draft-urien-eap-smartcard-21  has
been updated with the corrected value

1: Corrected

In test #2 (Wrong SQN) you're calculating MAC-S with a non-zero AMF giving
7CD924E739F12369. According to 3GPP TS 33.102 AMF is set to zeros when
calculating AUTS. When doing that I get 0010C1DA38A75A31 instead.

2: Corrected

>>In test #6 (Reauth, Good Counter) the counter value is 0000, whereas
RFC4187 specifies that the minimum counter value of the first packet should
be 0001. Also, you use the 64-byte MSK value generated in test #1 instead of
MK, whereas RFC4187 specifies XKEY'=SHA1(Identity|counter|NONCE_S|MK). This
obviously gives a quite different result than what you get.

3:To be Corrected

In the "Get MSK" commands in test #1 and test #6 the first 32 bytes of MSK
are switched with the last 32 bytes of MSK. I don't see anything in your
document stating that this should be the behaviour.

The order is switched on supllicant side. To be documented

4: Corrected

In test #6 and test #7 the MAC is not calculated over (EAP-packet |
Nounce-S), as specified in RFC4187.


Best Regards

Pascal

2011/6/7 Michael Thomsen <ietf-denmike@snkmail.com>

> Hi Pascal,
>
> sorry, I don't quite understand what you mean by "former EAP-AKA version",
> but I've stumpled upon a few things I don't quite understand:
>
> 1:
> --
> In test #2 (Wrong SQN) you're calculating MAC-S with a non-zero AMF giving
> 7CD924E739F12369. According to 3GPP TS 33.102 AMF is set to zeros when
> calculating AUTS. When doing that I get 0010C1DA38A75A31 instead.
>
> According to RFC4187 AT_AUTS should include "the AKA AUTS parameter, 112
> bits" I don't see anything about the AMF field not being zeroed, as it is
> per usual.
>
> 2:
> --
> In test #6 (Reauth, Good Counter) the counter value is 0000, whereas
> RFC4187 specifies that the minimum counter value of the first packet should
> be 0001. Also, you use the 64-byte MSK value generated in test #1 instead of
> MK, whereas RFC4187 specifies XKEY'=SHA1(Identity|counter|NONCE_S|MK). This
> obviously gives a quite different result than what you get.
>
> 3:
> --
> In the "Get MSK" commands in test #1 and test #6 the first 32 bytes of MSK
> are switched with the last 32 bytes of MSK. I don't see anything in your
> document stating that this should be the behaviour.
>
> 4:
> --
> In test #6 and test #7 the MAC is not calculated over (EAP-packet |
> Nounce-S), as specified in RFC4187.
>
> Kind regards,
>  Michael Thomsen
> _______________________________________________
> Emu mailing list
> Emu@ietf.org
> https://www.ietf.org/mailman/listinfo/emu
>