[Emu] AD review of draft-ietf-emu-rfc5448bis-06

Roman Danyliw <rdd@cert.org> Wed, 15 January 2020 22:24 UTC

Return-Path: <rdd@cert.org>
X-Original-To: emu@ietfa.amsl.com
Delivered-To: emu@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE89D1209C9 for <emu@ietfa.amsl.com>; Wed, 15 Jan 2020 14:24:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pozEoBGBU1fZ for <emu@ietfa.amsl.com>; Wed, 15 Jan 2020 14:24:00 -0800 (PST)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B1A2120992 for <emu@ietf.org>; Wed, 15 Jan 2020 14:24:00 -0800 (PST)
Received: from delp.sei.cmu.edu (delp.sei.cmu.edu [10.64.21.31]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 00FMNxK8020504 for <emu@ietf.org>; Wed, 15 Jan 2020 17:23:59 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu 00FMNxK8020504
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1579127039; bh=iTyct0944TRAbo/NHAwMRx1cKkstviGOmn5PNJ0/XwM=; h=From:To:Subject:Date:From; b=Nbvz85rdFlEyznt7LYAZ0opQ6zyDduV/3of/UHxjjxVw5C4MYLVErM5o2BILR3mKW SN2SDPTkFFh0C0vKGfU+VGfUCJaCLFKlYB+MC9OxGUj86IXy01Ccz+ABzD+n+h1dsa a3i7ETZA4a35+/ZXZ51UuNB8W+TrOANL4kPWbOS4=
Received: from CASCADE.ad.sei.cmu.edu (cascade.ad.sei.cmu.edu [10.64.28.248]) by delp.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 00FMNwci016024 for <emu@ietf.org>; Wed, 15 Jan 2020 17:23:58 -0500
Received: from MARCHAND.ad.sei.cmu.edu ([10.64.28.251]) by CASCADE.ad.sei.cmu.edu ([10.64.28.248]) with mapi id 14.03.0468.000; Wed, 15 Jan 2020 17:23:58 -0500
From: Roman Danyliw <rdd@cert.org>
To: "emu@ietf.org" <emu@ietf.org>
Thread-Topic: AD review of draft-ietf-emu-rfc5448bis-06
Thread-Index: AdXL4fHY6Uv9HY4UQIemTX77qdoTSw==
Date: Wed, 15 Jan 2020 22:23:57 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC0216EF8F6F@marchand>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/emu/L06wb8jiwA5ahuSxU-_3bYbWcd8>
Subject: [Emu] AD review of draft-ietf-emu-rfc5448bis-06
X-BeenThere: emu@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "EAP Methods Update \(EMU\)" <emu.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/emu>, <mailto:emu-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/emu/>
List-Post: <mailto:emu@ietf.org>
List-Help: <mailto:emu-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/emu>, <mailto:emu-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 22:24:02 -0000

Hello!

I conducted an AD review of draft-ietf-emu-rfc5448bis-06 and this document is in good shape.  Thanks for all of the work on it.  I have minor questions and editorial nits which can be addressed with the IETF Last Call feedback.

Minor:
-- Can you revisit the history -- why was RFC4187 informational?  I'm guessing this draft is informational because it updates RFC4187, right?

-- Section 7.1.  Per "The use of pseudonyms in this situation is at best limited" - unclear to me what this means?  Is this say that pseudonyms is not recommended because the re-use is creates a tracking opportunity (per the next sentence)?

-- Section 7.1.  Per "Outside 5G, there is a full choice to use ...", what is a "full choice"?

Editorial Nits:

-- Section 1.  s/EAP-AKA' is also an algorithm update for the used hash functions./EAP-AKA' also updates the algorithm used in the hash functions./

-- Section 1.  s/The update ensures/This update ensures/

-- Section 1.  Typo. s/how how/how/

-- Section 3.5.  Consider giving the table an explicit number (e.g., Table 1) and s/The attribute table is shown below/The attribute table is shown in Table 1./

-- Section 5.2.  s/However, to ensure privacy/However, to enhance privacy/ -- there is no "absolute privacy".

-- Section 5.2. s/for at attacker/for an attacker/

-- Section 7.3.  s/an backwards/a backwards/

Regards,
Roman