[forces] AD review of draft-ietf-forces-interop
"Adrian Farrel" <adrian@olddog.co.uk> Thu, 11 April 2013 21:26 UTC
Return-Path: <adrian@olddog.co.uk>
X-Original-To: forces@ietfa.amsl.com
Delivered-To: forces@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A622021F907E for <forces@ietfa.amsl.com>; Thu, 11 Apr 2013 14:26:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.39
X-Spam-Level:
X-Spam-Status: No, score=-2.39 tagged_above=-999 required=5 tests=[AWL=0.209, BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vvx5ppNcnCxp for <forces@ietfa.amsl.com>; Thu, 11 Apr 2013 14:26:52 -0700 (PDT)
Received: from asmtp3.iomartmail.com (asmtp3.iomartmail.com [62.128.201.159]) by ietfa.amsl.com (Postfix) with ESMTP id BC97821F8A0B for <forces@ietf.org>; Thu, 11 Apr 2013 14:26:51 -0700 (PDT)
Received: from asmtp3.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp3.iomartmail.com (8.13.8/8.13.8) with ESMTP id r3BLQoY4017027; Thu, 11 Apr 2013 22:26:50 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp3.iomartmail.com (8.13.8/8.13.8) with ESMTP id r3BLQnxF017005 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 11 Apr 2013 22:26:49 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: draft-ietf-forces-interop@tools.ietf.org
Date: Thu, 11 Apr 2013 22:26:48 +0100
Message-ID: <048e01ce36fb$46d1d150$d47573f0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Content-Language: en-gb
Thread-Index: Ac42+x5wLxpL/Mi4TIqpPBt+iiI+Yw==
Cc: forces@ietf.org
Subject: [forces] AD review of draft-ietf-forces-interop
X-BeenThere: forces@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: ForCES WG mailing list <forces.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/forces>, <mailto:forces-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/forces>
List-Post: <mailto:forces@ietf.org>
List-Help: <mailto:forces-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/forces>, <mailto:forces-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2013 21:26:52 -0000
Hi authors of draft-ietf-forces-interop, I have done my usual AD review of your document as part of processing the publication request. The intention of the review is to catch issues that might show up in IETF last call or IESG review and thereby improve the efficiency of those review stages. There are a few small issues that I would like you to address with a new revision. As always, my comments are open for discussion and disagreement. I have placed the document into "Revised I-D Needed" state in the datatracker until we resolve these small points. Thanks for the work, Adrian --- I believe the intention of this work is to provide supplementary information on top of that already contained in RFC 6053. In view of that, you are correct to state that this document updates RFC 6053. To achieve that smoothly you need to: - Add a piece of metadata to the top of the file to read: Updates: 6053 (if approved) (see http://datatracker.ietf.org/doc/draft-ietf-mpls-ldp-ipv6/ for an example) - Explain the update in the Abstract. I'd suggest... RFC 6053 reported the results of the first ForCES interoperability test, and this document updates RFC 6053 by providing further interoperability results. The additional context to the update that you give in the Introduction is perfect. --- I am worried by the references to two I-Ds. [I-D.ietf-forces-lfb-lib] and [I-D.ietf-forces-ceha] were I-Ds at the time of testing. There is no law against this, but it gives us a problem: The versions tested need to be pinned in time. For example, draft-ietf-forces-lfb-lib will probably be published as an RFC before your document becomes an RFC, but it would not be correct to say that you tested that RFC. So, I think you need some text talking about the draft versions tested and giving specific name to the drafts rather than just pointing at the citation. I can probably help you draft some text here, but I think that it would be quickest for you to try to write down what you tested, and then I can polish it. --- The references are all to pot! idnits shows this up clearly and you need to fix this before the draft can go forward. (The uses of IP addresses flagged by idnits are OK and do not need to be changed.) --- The use of RFC 2119 language is a problem and needs to be fixed. You are not defining protocol behavior in this document and do not need section 2.1 at all. Then you need to go through the document and clean up the upper case. If you are making a direct quote from another RFC, then please make it much clearer using indentation, quote marks, and by saying "As stated in [RFC1234]:" If you are not quoting, then you really can use lower case. But please be careful even then. What would it mean to say "An implementation must do this"? Would it really be the case that you mean: "We tested to see whether an implementation does this as required in section 1.2 or [RFC1234]"? --- I have a personal dislike of repeated definitions copied from other documents. They can cause all sorts of fun if you make a mistake when you copy the text! So I would prefer section 2.2. simply to point at the definitions from other RFCs. However, I think this is a matter of style, and I do not insist that you make this change. --- Section 3.1 says: Some errata related to ForCES document were found by the interoperability test. The errata has been reported to related IETF RFCs. This is great. IMHO it is a more valuable outcome than the rest of the work :-) If you can find a way to briefly list these or provide pointers to the errata reports, I think this would be really nice and would help validate all your hard work.
- [forces] AD review of draft-ietf-forces-interop Adrian Farrel
- Re: [forces] AD review of draft-ietf-forces-inter… Wang,Weiming
- Re: [forces] AD review of draft-ietf-forces-inter… Jamal Hadi Salim
- Re: [forces] AD review of draft-ietf-forces-inter… Joel
- Re: [forces] AD review of draft-ietf-forces-inter… Adrian Farrel
- Re: [forces] AD review of draft-ietf-forces-inter… Wang,Weiming
- Re: [forces] AD review of draft-ietf-forces-inter… Wang,Weiming
- Re: [forces] AD review of draft-ietf-forces-inter… Weiming Wang