Re: Protocol Draft - KEYINFO-TLV

"Joel M. Halpern" <joel@stevecrocker.com> Tue, 01 April 2008 01:04 UTC

Message-Id: <MON.31.MAR.2008.210436.0400.>
Date: Mon, 31 Mar 2008 21:04:36 -0400
From: "Joel M. Halpern" <joel@stevecrocker.com>
Subject: Re: Protocol Draft - KEYINFO-TLV
Comments: To: Evangelos Haleplidis <ehalep@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-7"; format="flowed"
Content-Transfer-Encoding: 7bit

The KeyData is, I believe a FULLDATA TLV, as it can be any form of data,
and may need its own length.

The KeyID is an ID, as defined in the model.  There can be multiple
keys, each made up of multiple values.  The keyid tells you wha tkey is
being used.  Please look at the model and let us know if there is a need
for more text on that.

Yours,
Joel M. Halpern

Evangelos Haleplidis wrote:
> Greetings again to the list,
>
> I have some comment regarding the KEYINFO-TLV.
>
> 1. As with the PathData TLV there was no Graph, so I made up one. I include
> it in the end of the mail.
> 2. About the KeyID, it is not specified specific in the document what the
> size is. I guess it is an integer, shouldn't it be specified for clarity?
> How many Keys may exist for a specific table? Could/Should the KeyID be
> limited to less than 4 bytes?
> 3. In Page 45 it is written:
>        KEYINFO-TLV := KeyID FULLDATA-TLV
> Shouldn't it be changed to:
>        KEYINFO-TLV := KeyID KEYDATA
>        KEYDATA := FULLDATA-TLV
> Or
>        KEYINFO-TLV := KeyID KeyData
> This would be in accordance with the examples also in the appendix.
>
> Regards,
> Evangelos Haleplidis.
>
> ===============================
> KeyInfo-TLV Graph
>
>      0                   1                   2                   3
>      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |        Type = KeyInfo         |               Length          |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                             KeyID                             |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                            KeyData                            |
>     .                                                               .
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>