[Gen-art] Review: draft-ietf-krb-wg-camellia-cts-01

"Joel M. Halpern" <jmh@joelhalpern.com> Fri, 14 September 2012 02:46 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 868F221F8606 for <gen-art@ietfa.amsl.com>; Thu, 13 Sep 2012 19:46:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.159
X-Spam-Level:
X-Spam-Status: No, score=-102.159 tagged_above=-999 required=5 tests=[AWL=0.106, BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T6ZuMnRx1WR9 for <gen-art@ietfa.amsl.com>; Thu, 13 Sep 2012 19:46:59 -0700 (PDT)
Received: from morbo.mail.tigertech.net (morbo.mail.tigertech.net [67.131.251.54]) by ietfa.amsl.com (Postfix) with ESMTP id 3010921F85F4 for <gen-art@ietf.org>; Thu, 13 Sep 2012 19:46:59 -0700 (PDT)
Received: from mailc2.tigertech.net (mailc2.tigertech.net [208.80.4.156]) by morbo.tigertech.net (Postfix) with ESMTP id C4784A564B for <gen-art@ietf.org>; Thu, 13 Sep 2012 19:46:57 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailc2.tigertech.net (Postfix) with ESMTP id 12E622A1FFD; Thu, 13 Sep 2012 19:46:57 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at c2.tigertech.net
Received: from [10.10.10.104] (pool-71-161-52-249.clppva.btas.verizon.net [71.161.52.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailc2.tigertech.net (Postfix) with ESMTPSA id 3F8252A2000; Thu, 13 Sep 2012 19:46:56 -0700 (PDT)
Message-ID: <50529A96.2020802@joelhalpern.com>
Date: Thu, 13 Sep 2012 22:46:46 -0400
From: "Joel M. Halpern" <jmh@joelhalpern.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: "A. Jean Mahoney" <mahoney@nostrum.com>
References: <505259E8.6020407@nostrum.com>
In-Reply-To: <505259E8.6020407@nostrum.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: gen-art@ietf.org, ghudson@mit.edu, Jeffrey Hutzelman <jhutz@cmu.edu>
Subject: [Gen-art] Review: draft-ietf-krb-wg-camellia-cts-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Sep 2012 02:46:59 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> .

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-krb-wg-camellia-cts-01
     Camellia Encryption for Kerberos 5
Reviewer: Joel M. Halpern
Review Date:13-Sept-2012
IETF LC End Date: 26-Sept-2012
IESG Telechat date: N/A

Summary: This document is ready for publication as an Informational RFC.

Major issues:

Minor issues:
	The document seems to use "random2key" (in section 3) and 
"random-to-key" (in section 4) to represent the same thing, apparently 
meaning the "random-to-key" identity function of section 6.
	Section 6 defines Ki in a different way than section 4.  Section 4 
apparently uses K0 and Ki to mean K(0) and K(i) for the iteration.  (And 
then in the next line uses K1, K2, ... Kn for these, without parens.) 
But section 6 Ki is for a specific value in the encrypt/decrypt 
functions.  The simple solution would seem to be to consistently use 
parenthesis in section 4.

Nits/editorial comments: