[Gen-art] Re: [lamps] draft-ietf-lamps-pq-composite-kem-18 ietf last call Genart review

Behcet Sarikaya <sarikaya2012@gmail.com> Tue, 11 August 2026 19:15 UTC

Return-Path: <sarikaya2012@gmail.com>
X-Original-To: gen-art@mail2.ietf.org
Delivered-To: gen-art@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 3125C1280923C for <gen-art@mail2.ietf.org>; Tue, 11 Aug 2026 12:15:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1786475757; bh=UqRnuDVZo1fmeBUBtt27EQIuyhg8CkvBgR0Kf2DP/uk=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc; b=r8n8soWejd+Pzw9x8o6qsMhakGg1dGzTHtlvWJk6mbGql8iTUMpVT8AcNzuaimjjx N8ZyR1RaNuLhfzSbW57Rj4asr23TPEZx6U7mFxGVpmhd+0ZHOqpXg2RvuzI7KhJFv6 0fPUypPdlD7g3Tl8wVYiJxOAzLo6RJkDdegHcMXI=
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.848
X-Spam-Level:
X-Spam-Status: No, score=-1.848 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mtzxiKimI3hG for <gen-art@mail2.ietf.org>; Tue, 11 Aug 2026 12:15:56 -0700 (PDT)
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 6370012809221 for <gen-art@ietf.org>; Tue, 11 Aug 2026 12:15:56 -0700 (PDT)
Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5aec201b582so231649e87.1 for <gen-art@ietf.org>; Tue, 11 Aug 2026 12:15:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1786475755; cv=none; d=google.com; s=arc-20260327; b=UjAkkPjgpZYXublwVX+ZN9i+44NSx2lcGTyQoiVz2Qrxz/AbfbCCt2OTBWO1wi+yFe oGDC+t1fbYc/UIP/kbnXB46Y26G/QJ3cpJM4wB5Z/D+6Sop9mGUHraLWmIIporgtiRKf 5ZSln7Nkgt5y4wlymO4UwE7UESs7vVBTLUK21FuDejm7oCkjV/P2fHoQhg/Tf4GksFgU btm2smVgHqIhT5h8VRQfDFCmL+nXF148lEc4TkNLpH5FOUZdW8D3KEynwg6LsZ66MN+r I2ktZQ1ZH/YJnY2X4phiJj8rbwID6Zh0E200mZIH2nEmjbX0ue7zVmMo8uEE5ZfSOcAn 5ZpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:dkim-signature; bh=Tx6tfgaAaUbYr8sBFHD4N6aBd0Es5h9Rf2nviuU3hn0=; fh=eps4h7n8ikfx2Qar2b5lChkGo0Mg6q2l2ZH5cy/nxfY=; b=LHG0eueYOOjATs9cWHIH9sZuaS9sdAIWj/I48E1gP07LK2lkbNkUlCnhmX2TbvA0Ft FPTZnQWlSoCx4jazatEmQmNs+w9hmHfUlN/ODJWVSkERsTiImRIAJ4wdol3TmhCGgxDz TqXf7T3l2K8kU2J7pYt7EqseqxQpMym98FPueRx7QGjbG21tguIN/DDUgEZMXAv/Vqs/ TbEebtb3HZyMZy+nU/Zv1k5fymgJJe+wGtQrbThI46oJBsYeIQk+HpnzffMgBXtSx5bx jJ4QeGMfKrjPgFpXVEO5G6WebU8+Jm+OHROxvmhjpJgUCs3tJQ6BXbOsCcgcDWNS4N5Y 59FQ==; darn=ietf.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786475755; x=1787080555; darn=ietf.org; h=content-type:cc:to:subject:message-id:date:from:reply-to :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Tx6tfgaAaUbYr8sBFHD4N6aBd0Es5h9Rf2nviuU3hn0=; b=ChBPUJKJuG3F4NJrER3SpHUfRSr7NqQH5o28z+FgxnXlB4he0z+qO7FzfICeBmkGtV SrXeO+f/kxz/wb6t1XZ5c3kju+QoQHne3e3h5pygosH9U5z6VnknzMj+I8wTHgE9J0am oauvgPvyn1UWF5EdyJx8Kg5wvNV86hotwoF2i+yGJuSGqufyMaV3UxTpWb+oMrDwGuNR 0d2boMbmjRkEm1o93W/ihhUOpNkpf9OQanMU51MWFaVGu2a1shn1pMc6JUL0GUZcl5DX fqNGPSXo0OqJQZb3jXHrgSq3TVbQW7cYKFTBE8N/ADizupF9yb50SLwy91ye9YeAzk49 Zf2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786475755; x=1787080555; h=content-type:cc:to:subject:message-id:date:from:reply-to :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Tx6tfgaAaUbYr8sBFHD4N6aBd0Es5h9Rf2nviuU3hn0=; b=Yg4RnKb9cwZJHzBRWlBJJlUWKsATyJu5JSHq1+uX04sHG+6Z+hqmTXIO6MmaTa2Hc/ IHZe+ACOvR0By6so1YZrxm5BtTukyfexq22ClBKU20UqNsav25msevuIhDHGhJIlQQoC deA5IrNFXOzMlTeFfE8bj7nhwoAcotQkWsGAMU6rAi3CpM7kUWvXbvpS5gzXWz/wET+l sPG/rk8BbfHE+tYMVaUHhY5ZmLWcMDf2KhAqcwB3M0W+KVCxAx9HdMiOQyDbeDIuLyHQ sk+sgZytvYD/xN9xvWMjpcgTxSiKhKQGZdlUmZJdX6zUn++1Pp0Asr/955daa/yGECNS bGjg==
X-Gm-Message-State: AOJu0YxwK2weOJ6hsS87qEw+vAi0oDvh17JSDeo51IXATrRIEgOQdvjq 1wp85XQfPCWskerHj4UEipSYnr6VFq3uJKR7urta+b/60XGJv4aOMaxzVJLNnEX352kg9t82t3F lMMH/j6pLRoGYrDRvmFu+pgs76rhDZpc=
X-Gm-Gg: AR+sD126MkGjzJIgFl59uci5mVovCq3EgSttgB0KGYWaaWnZfBNl6lUHLm00RwG0cnK MHseRe+E5XSF/JvcJFIUvRyPWYr/QgwAGrAEhpQGmgzurhQXKMmiCPEMV/eBlorANUaazMT/Gol EeWyzKgK9AuyeoU8PTEvQvPAApl79+7uUXmZAzqpu6qxRa1a9bNatninYwueYUU13p9Ub21YhJj XqwfwaQE/L2B3+nDa6agBqx/4VIWP6KC+bmNcEjsMXeettoEruH4Yl1bs9lkkCNvd6qufoKxaKN tkD/IHER2F7BhJkOpVQomNCXFxAbfXIWaZbsw0TYN5skES5Qxzx0L63ZcPZHxRY/s5ms/DzsfOk l6R4=
X-Received: by 2002:a05:6512:104f:b0:5ae:bb31:4b98 with SMTP id 2adb3069b0e04-5b44860c68dmr869756e87.20.1786475754819; Tue, 11 Aug 2026 12:15:54 -0700 (PDT)
MIME-Version: 1.0
References: <178517046122.1199998.12607390288355121397@dt-datatracker-d4d6ff9d9-fsx7d> <CAKZgXHpnspEp=K2cKKniNwTZfxH=bbSKzqehec9jUQ=1xED7Sg@mail.gmail.com>
In-Reply-To: <CAKZgXHpnspEp=K2cKKniNwTZfxH=bbSKzqehec9jUQ=1xED7Sg@mail.gmail.com>
From: Behcet Sarikaya <sarikaya2012@gmail.com>
Date: Tue, 11 Aug 2026 14:15:42 -0500
X-Gm-Features: AUfX_mz7JpgghIfdf-VypluVjrk0BQ4iAnJmOgZjSHEqgGBcsiLGqRnL1VSCCt0
Message-ID: <CAC8QAcd-XCHX-az1nS-XWDyPPRNqdsx8PtPXkx8orShv2M-d0g@mail.gmail.com>
To: Mike Ounsworth <ounsworth+ietf@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000c414c70658ca4c77"
Message-ID-Hash: KZCYZCBMBCYXHINNSVNJWQMY2YFC6BSX
X-Message-ID-Hash: KZCYZCBMBCYXHINNSVNJWQMY2YFC6BSX
X-MailFrom: sarikaya2012@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-gen-art.ietf.org-0; header-match-gen-art.ietf.org-1; header-match-gen-art.ietf.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: gen-art@ietf.org, draft-ietf-lamps-pq-composite-kem.all@ietf.org, last-call@ietf.org, spasm@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Reply-To: sarikaya@ieee.org
Subject: [Gen-art] Re: [lamps] draft-ietf-lamps-pq-composite-kem-18 ietf last call Genart review
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/35-JbXwg36N98Ba4YdkbNbApmmE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Owner: <mailto:gen-art-owner@ietf.org>
List-Post: <mailto:gen-art@ietf.org>
List-Subscribe: <mailto:gen-art-join@ietf.org>
List-Unsubscribe: <mailto:gen-art-leave@ietf.org>

Hi Mike,


On Tue, Aug 11, 2026 at 10:01 AM Mike Ounsworth <ounsworth+ietf@gmail.com>
wrote:

>
> Hi Behcet Sarikaya, thank you for the review.
>
> I have made some fixes to address these comments here:
>
> https://github.com/lamps-wg/draft-composite-kem/commit/c70e297a2c2458415388e00308e9cf0b8fa59753
> but I will hold pushing to datatracker because I have a few clarifying
> questions back to you below.
>
>
>
> Section 1
> RSA vs RSA-OAEP is not explained at all
>
> [MikeO]: This spec references a pile of cryptographic algorithms,
> including ML-KEM, RSA-OAEP, ECDH, X25519, X448, and SHA3. We don't really
> "explain" any of them, but references to their specifications are included
> in Appendix B.
> The opining sentence of Section 1 does at least expand the acronym "OAEP"
> and mention that this is a mode of RSA:
> "traditional cryptographic key establishment algorithms in common use --
> namely the Rivest–Shamir–Adleman cryptosystem in the Optimal Asymmetric
> Encryption Padding mode (RSA-OAEP), and elliptic curve Diffie-Hellman
> (ECDH) -- will become vulnerable to quantum attacks."
>
> [MikeO]: If that's not sufficient, then maybe you could explain further
> what level of explanation you feel is missing?
>
>
> Fine.

>
> expand at first use: PQC post quantum cryptography  (PQC)
>
> [MikeO]: Good catch.
>
>
>
> in in this
>    specification; this is discussed further
>
> Here there were two "in" s.

PKIX-related Public Key Infrastructure X.509
>
> Fine

> [MikeO]: I don't understand these comments. Can you explain further what
> change you are looking for here?
>
>
>
> Post-Quantum / Traditional (PQ/T) Hybrids
> combined
> idea seems to be central to this document
> this gives stronger algorithms since
> an attacker would need to break all of them
>    simultaneously to compromise the protected data
>
> [MikeO]: I added a forward link to the Security Considerations that
> discuss the properties of PQ/T hybrids in more detail.
>
> Fine


> 1.1
> pramater sets
>
> [MikeO]: Good catch.
>
> 2.2
>
> KEM Encaps(pk) -> (ss, ct)  "." missing?
>
> [MikeO]: Fixed.
>
> Added complete test vectors in Version -07 of this document
> contributing almost 60 pages
>
> [MikeO]: This is true, are you asking for some kind of change here?
>
> No.

>
> 9. Security Considerations
> dual algorithm security
>
> [MikeO]: I don't understand these comments. Can you explain further what
> change you are looking for here?
>
> Fine

>
> In Section 10 there is
> 10. Operational Considerations
>
>
> calling for an Ops area review?
>
> [MikeO]: These Operational Considerations are really quite
> cryptography-specific, so I'm not sure that an OPS Dir review would add
> much, but of course I would welcome more eyes.
>
>
So your fixes above are OK, just add one more and then publish it.

Behcet

> On Mon, 27 Jul 2026 at 11:43, Behcet Sarikaya via Datatracker <
> noreply@ietf.org> wrote:
>
>> Document: draft-ietf-lamps-pq-composite-kem
>> Title: Composite ML-KEM for use in X.509 Public Key Infrastructure
>> Reviewer: Behcet Sarikaya
>> Review result: Almost Ready
>>
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>>
>> For more information, please see the FAQ at
>>
>> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>>
>> Document: draft-ietf-lamps-pq-composite-kem-18
>> Reviewer: Behcet Sarikaya
>> Review Date: 2026-07-27
>> IETF LC End Date: 2026-07-27
>> IESG Telechat date: Not scheduled for a telechat
>>
>> Summary:
>> This document defines combinations
>> of US NIST Module-Lattice-based Key Encapsulation Mechanism i.e. ML-KEM
>> in hybrid with
>>    traditional algorithms RSA-OAEP, ECDH, X25519, and X448
>> Major issues:
>> None
>> Minor issues:
>>
>> Nits/editorial comments:
>>
>> Section 1
>> RSA vs RSA-OAEP is not explained at all
>>
>> expand at first use: PQC post quantum cryptography  (PQC)
>>
>> in in this
>>    specification; this is discussed further
>>
>> PKIX-related Public Key Infrastructure X.509
>>
>>
>> Post-Quantum / Traditional (PQ/T) Hybrids
>> combined
>> idea seems to be central to this document
>> this gives stronger algorithms since
>> an attacker would need to break all of them
>>    simultaneously to compromise the protected data
>>
>> 1.1
>> pramater sets
>>
>> 2.2
>>
>> KEM Encaps(pk) -> (ss, ct)  "." missing?
>>
>> Added complete test vectors in Version -07 of this document
>> contributing almost 60 pages
>>
>>
>> 9. Security Considerations
>> dual algorithm security
>>
>> In Section 10 there is
>> 10. Operational Considerations
>>
>>
>> calling for an Ops area review?
>>
>>
>>
>> _______________________________________________
>> Spasm mailing list -- spasm@ietf.org
>> To unsubscribe send an email to spasm-leave@ietf.org
>>
>