[Gen-art] Genart last call review of draft-ietf-lamps-rfc5990bis-05

Christer Holmberg via Datatracker <noreply@ietf.org> Thu, 18 April 2024 08:03 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CB782C1516E1; Thu, 18 Apr 2024 01:03:17 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-lamps-rfc5990bis.all@ietf.org, last-call@ietf.org, spasm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.10.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171342739782.23304.18096860172537207625@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Thu, 18 Apr 2024 01:03:17 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5F4cEEHuVio4fwRCvj_9QvFVUPo>
Subject: [Gen-art] Genart last call review of draft-ietf-lamps-rfc5990bis-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2024 08:03:17 -0000

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-lamps-rfc5990bis-05
Reviewer: Christer Holmberg
Review Date: 2024-04-18
IETF LC End Date: 2024-04-23
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well written, and easy to read. As I am not familiar
with RSA-KEM, I don't have comments regarding the changes compared to RFC 5990.
However, I do have an editorial comment that I would like the authors to
address.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

Section 1.6 describes the changes from RFC 5990.

Q1: The text mixes between past tense (e.g., "required") and present tense
(e.g., "includes"). Please use consistent grammar.

Q2: It is unclear what "RFC 5990 includes" means. Does it mean that the usage
of something was defined? Was support of something required? etc.

Q3: Similar to the above question, it is unclear what "discussion of this"
means.

Q4: I think it would be useful to include a few words about WHY a change has
been done. If described elsewhere in the document, a reference could be added.