Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-open-policy-18
Lars Eggert <lars@eggert.org> Thu, 20 January 2022 12:03 UTC
Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5D2093A0A26; Thu, 20 Jan 2022 04:03:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ukU5-ESBbAuK; Thu, 20 Jan 2022 04:03:45 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 706823A0A22; Thu, 20 Jan 2022 04:03:34 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:acdb:18e0:9d80:8cc4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 176001D2991; Thu, 20 Jan 2022 14:03:26 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1642680206; bh=gNBOreBq/f2z8Qisgg7OwWirJrYP3953kBUDonICqx8=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=tUzhsfJs17lYDt01glFoVSEwR2sUZS85aC3l5pEUViQLFuwaQs+wqWr9lMi13Twun V5Ibw00pIdyP21pxywqWUbD0AG3KIxZHmaZxwu2bOPzuXCup2PrX651JJHbWgnTJU2 K0qVuUzRYx8dP7roPnmTpzxojyqjJdM8RGhJlGfE=
Content-Type: multipart/signed; boundary="Apple-Mail=_1224D918-05B5-4C08-B6F1-02AE15D8EBF1"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164013488006.27197.13873644386825552452@ietfa.amsl.com>
Date: Thu, 20 Jan 2022 14:03:25 +0200
Cc: gen-art@ietf.org, draft-ietf-idr-bgp-open-policy.all@ietf.org, idr@ietf.org, last-call@ietf.org
Message-Id: <E0758E8D-EBCF-4E37-AAF7-A4F600089A9F@eggert.org>
References: <164013488006.27197.13873644386825552452@ietfa.amsl.com>
To: Gyan Mishra <hayabusagsm@gmail.com>
X-MailScanner-ID: 176001D2991.A2740
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5d_8oyZq2T8Pt0Yzt3KaiLJeA_4>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-open-policy-18
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jan 2022 12:03:51 -0000
Gyan, thank you for your review and everyone else on the follow-on discussion. I have entered a No Objection ballot for this document. Lars > On 2021-12-22, at 3:01, Gyan Mishra via Datatracker <noreply@ietf.org> wrote: > > Reviewer: Gyan Mishra > Review result: Ready with Nits > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-idr-bgp-open-policy-?? > Reviewer: Gyan Mishra > Review Date: 2021-12-21 > IETF LC End Date: 2021-12-17 > IESG Telechat date: Not scheduled for a telechat > > Summary: This draft provides a new BGP open role capability and OTC path > attribute to detect and mitigate route leaks automatically. I have been > following this draft on IDR and supported through Adoption and WGLC. This > document has matured and is ready for publication. The new BGP role > capabilities mismatch code 2 subcode 8 discussed on ML seems to have multiple > implementations deployed and one confined by Cisco. I agree that the authors > should request a new subcode for the role mismatch notification. > > Major issues: > None > > Minor issues: > None > > Nits/editorial comments: > Comment related to Gao-Rexford model. The Gao-Rexford Model only has 3 peer > types North bound upstream Provider, Southbound Customer and lateral same tier > level peer. With the role capabilities, RS and RS-Client is added which makes > it slightly different but almost identical. In describing the role types would > it make sense to have a graphical depiction of Gao-Redford model with the role > capabilities on adjacent peers to help explain the role relationship for local > and remote-as. Just an idea to help explain the role capabilities. In the > role correctness section scenario where the peer receives multiple role > capabilities to send role mismatch notification. What if there is a timing > issue and the multiple are received after the BGP open and peer is established > possible sequence of events issue. Is it possible the peer may not get a > mismatch notification if the peer establishes prior to getting a different > capabilities where a mismatch or problem exists that is missed that could > result in a route leak. I am thinking of possibly false positive or negative or > negative during BGP open capabilities exchange > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-ietf-i… Gyan Mishra via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Alvaro Retana
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Alvaro Retana
- Re: [Gen-art] Genart last call review of draft-ie… Sriram, Kotikalapudi (Fed)
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Sriram, Kotikalapudi (Fed)
- Re: [Gen-art] [Idr] Genart last call review of dr… Brian Dickson
- Re: [Gen-art] Genart last call review of draft-ie… Alexander Azimov
- Re: [Gen-art] Genart last call review of draft-ie… Alvaro Retana
- Re: [Gen-art] [Idr] Genart last call review of dr… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Alexander Azimov
- Re: [Gen-art] Genart last call review of draft-ie… Alvaro Retana
- Re: [Gen-art] Genart last call review of draft-ie… Sriram, Kotikalapudi (Fed)
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Lars Eggert