[Gen-art] Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13

Brian Carpenter <brian.e.carpenter@gmail.com> Tue, 06 February 2018 22:32 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F12212D967; Tue, 6 Feb 2018 14:32:08 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Brian Carpenter <brian.e.carpenter@gmail.com>
To: gen-art@ietf.org
Cc: nvo3@ietf.org, draft-ietf-nvo3-hpvr2nve-cp-req.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.72.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151795632835.25952.6168100923198993264@ietfa.amsl.com>
Date: Tue, 06 Feb 2018 14:32:08 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5ju1CJJsFD0zr6e4ctDaPipk6oE>
Subject: [Gen-art] Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Feb 2018 22:32:08 -0000

Reviewer: Brian Carpenter
Review result: Ready with Issues

Gen-ART Last Call review of draft-ietf-pce-pcep-exp-codepoints-04

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-nvo3-hpvr2nve-cp-req-13.txt
Reviewer: Brian Carpenter
Review Date: 2018-02-07
IETF LC End Date: 2018-02-20
IESG Telechat date: 2018-02-22

Summary: Ready (with minor issue)
--------

Comment:
--------

This is a Last Call review despite the subject field.

Minor issue:
------------

   Req-10: The protocol MUST allow an End Device initiating a request to
   add, remove or update address(es) associated with a TSI instance on
   the external NVE. Addresses can be expressed in different formats,
   for example, MAC, IP or pair of IP and MAC.

Here and elsewhere, it seems necessary to specify that an IP address
can be in either IPv4 or IPv6 format. (This is implied in Table 1
and at the end of Appendix A, but that's quite well hidden.)
I suggest clarifying this early, in Section 1.2 "Target Scenarios".