IETF Logo Mail Archive

Re: [Gen-art] [Extra] Genart telechat review of draft-ietf-extra-imap-objectid-06

Bron Gondwana <brong@fastmailteam.com> Thu, 02 August 2018 13:11 UTC

Return-Path: <brong@fastmailteam.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AC65130E55; Thu, 2 Aug 2018 06:11:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmailteam.com header.b=Cn6zyk+u; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=CY/6r3Vy
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MCX6b3Jzk_zx; Thu, 2 Aug 2018 06:11:48 -0700 (PDT)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE6C7130E39; Thu, 2 Aug 2018 06:11:47 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3F19C2E4; Thu, 2 Aug 2018 09:11:47 -0400 (EDT)
Received: from web2 ([10.202.2.212]) by compute6.internal (MEProxy); Thu, 02 Aug 2018 09:11:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= fastmailteam.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=gaTUIH qZpAA5wz022TlInuVR5SEKALEDuKbvn3BDe18=; b=Cn6zyk+uHCawBdQGukZA2F e6u9L1QrAm9bejugjJ9ODmyDVw1RooH0hSzST9r6sc9cBdXB9fhP2BMOR6IK00su UtVrzhsUptDRhO1dUwY1aQYX0VRThyIiwH6/wJzHEM1XqYXKtc+aZOH5Q6gAPY8i lQbzLxcGRnfv3z7GIt/IAk1E0hmAT55L2ESt2ghPO9uHoTVKAD2YSnq+AIBh5bcF KDn9H3OADuSEn//+vNX39VdjFMrK2BUo7fN2/XkVzE5rzgkli5PIDIuRPhTHCozp hF6/BjeSbbyB9wxXl5kqziLg/gsPBQ+LjARzQdbbsJ/42TEghgEO0sRyEly7rwGw ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=gaTUIH qZpAA5wz022TlInuVR5SEKALEDuKbvn3BDe18=; b=CY/6r3Vy3GVuVLaWgG5prp cktq4vh4qtIUMpK0zY4d1nV8uc8N75voRcHbbwRDFGMYp3zuc3+VdBN4ZeLZ0YUD il1fIGS+wDYOq/6d8P3d6SBnn1+cLGvvseWY5lqWd4oxl3QR8GY0xIchtlepH2+3 nsNYoTl/wZuotVnTjy6W00XCv8aMmEjQ6JBOveXkwvIZf6pDSO3oZ4/3DAF2NMkM pjNAFItKxpDgdkfzRxee2SZUYD9m2jGsJcrDriyfzq1RHHJRsbBft/lZiao6Wyvj bcdHQ2WxBJbREw+3nSIjnO9qAJ/cutChvuLRchDoG+k5GMfIbPIkyB4a3qHShOxg ==
X-ME-Proxy: <xmx:EgNjWxaSbP6gEEFwaBnVMjjOCW-M2wdk8epa6bfbRk0MwtR_DKCA1Q> <xmx:EgNjW4ntCtTnZGMJVqkpXve7QWmhkdUAr1pGY8ts3ljJBh9SfX_8zQ> <xmx:EgNjW1yCNgpe5iiBZ0rssvlP0j0d-EwtrMNjLrrtyqwZLqDwQ7GlwQ> <xmx:EgNjW-Om6jABeA6UqBk9nwuCRiVCW7p2VnQxfKl2nc_cy5EBJs5OBA> <xmx:EgNjWxTstPaFoznPk_VMwRl_LFYdrPc5KFtbazIknx8hmv4lIoNmCg> <xmx:EgNjW9NEfRjTWBBSjoigZ8B-WeezDGKt7NPVWNrTi8LnfDdg0kqNLw>
X-ME-Sender: <xms:EgNjWyHrw5LPYgrnOFrdW5owTAnex9aODHlyd2pXmORdf0ytkY0dTg>
Received: by mailuser.nyi.internal (Postfix, from userid 99) id 66297621CB; Thu, 2 Aug 2018 09:11:46 -0400 (EDT)
Message-Id: <1533215506.3854543.1461163256.7570C1DE@webmail.messagingengine.com>
From: Bron Gondwana <brong@fastmailteam.com>
To: Pete Resnick <presnick@qti.qualcomm.com>, gen-art@ietf.org
Cc: extra@ietf.org, draft-ietf-extra-imap-objectid.all@ietf.org, ietf@ietf.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: multipart/alternative; boundary="_----------=_153321550638545432"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-2be8cd1b
Date: Thu, 02 Aug 2018 23:11:46 +1000
References: <153271422661.32667.3834516374113335159@ietfa.amsl.com>
In-Reply-To: <153271422661.32667.3834516374113335159@ietfa.amsl.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/73uB1JasrIRGYHeJPhgBGVyUe-Q>
Subject: Re: [Gen-art] [Extra] Genart telechat review of draft-ietf-extra-imap-objectid-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 13:11:49 -0000

On Sat, Jul 28, 2018, at 03:57, Pete Resnick wrote:
> Reviewer: Pete Resnick
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-extra-imap-objectid-06
> Reviewer: Pete Resnick
> Review Date: 2018-07-27
> IETF LC End Date: 2018-07-13
> IESG Telechat date: 2018-08-02
> 
> Summary: Ready with Nits
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> Thanks for the changes responding to my review. Good work.
> 
> §5.2, ¶6:
> 
> OLD
>   THREADID is optional, if the server doesn't support THREADID or is
> NEW
>   THREADID is OPTIONAL; if the server doesn't support THREADID or is

Yep, fixed.

> §5.2 ¶7:
> 
> Not clear to me why the THREADID and EMAILID can't be the same. I
> assume given> the MUST it's going to be some sort of interoperability problem,
> but it does> seem odd. But don't change it on my account.

This is basically a "developers will make assumptions about relatedness
which may not always hold".  We even XOR our THREADID against a constant
after calculating it from the EMAILID in our server now, so that
developers don't get lazy and make shortcuts.
> §8.2 ¶2:
> 
> s/backend object collide/backend object identifiers

Fixed this too.

Thanks again for great feedback,

Bron.

--
  Bron Gondwana, CEO, FastMail Pty Ltd
  brong@fastmailteam.com

v2.23.0 | Report a Bug | By Email