Re: [Gen-art] [Pals] Review of draft-ietf-pals-mpls-tp-dual-homing-coordination-05
"Weiqiang Cheng" <chengweiqiang@chinamobile.com> Tue, 14 February 2017 03:09 UTC
Return-Path: <chengweiqiang@chinamobile.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 004C6129409; Mon, 13 Feb 2017 19:09:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Level:
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KHblW8a4_PqV; Mon, 13 Feb 2017 19:09:41 -0800 (PST)
Received: from cmccmta3.chinamobile.com (cmccmta3.chinamobile.com [221.176.66.81]) by ietfa.amsl.com (Postfix) with ESMTP id 282EC129991; Mon, 13 Feb 2017 19:03:51 -0800 (PST)
Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app12-12012 (RichMail) with SMTP id 2eec58a27390d0a-8416f; Tue, 14 Feb 2017 11:03:45 +0800 (CST)
X-RM-TRANSID: 2eec58a27390d0a-8416f
X-RM-SPAM-FLAG: 00000000
Received: from cmcc (unknown[10.2.51.86]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee458a2738fe69-56c71; Tue, 14 Feb 2017 11:03:44 +0800 (CST)
X-RM-TRANSID: 2ee458a2738fe69-56c71
From: Weiqiang Cheng <chengweiqiang@chinamobile.com>
To: 'Jouni Korhonen' <jounikor@gmail.com>, gen-art@ietf.org
References: <148703306292.22169.5868946919175397612.idtracker@ietfa.amsl.com>
In-Reply-To: <148703306292.22169.5868946919175397612.idtracker@ietfa.amsl.com>
Date: Tue, 14 Feb 2017 11:03:52 +0800
Message-ID: <011201d2866e$f8f2ec40$ead8c4c0$@com>
MIME-Version: 1.0
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdKGW5D/ERp+i/EBTWC4nomVg8XnNgAExSNA
Content-Language: zh-cn
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/8jVDGpoC8kxSW8co16C8bdT5xyY>
Cc: pals@ietf.org, ietf@ietf.org, draft-ietf-pals-mpls-tp-dual-homing-coordination.all@ietf.org
Subject: Re: [Gen-art] [Pals] Review of draft-ietf-pals-mpls-tp-dual-homing-coordination-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2017 03:09:42 -0000
Hi Jouni, Thank you very much for your careful review and valuable comments. We authors will fix those issues late. B.R. Weiqiang Cheng -----邮件原件----- 发件人: Pals [mailto:pals-bounces@ietf.org] 代表 Jouni Korhonen 发送时间: 2017年2月14日 8:44 收件人: gen-art@ietf.org 抄送: draft-ietf-pals-mpls-tp-dual-homing-coordination.all@ietf.org; ietf@ietf.org; pals@ietf.org 主题: [Pals] Review of draft-ietf-pals-mpls-tp-dual-homing-coordination-05 Reviewer: Jouni Korhonen Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-pals-mpls-tp-dual-homing-coordination-?? Reviewer: Jouni Korhonen Review Date: 2017-02-13 IETF LC End Date: 2017-02-13 IESG Telechat date: 2017-03-02 Summary: The document is ready. I have few questions, though, that most likely are obvious to the document authors and to the WG. Major issues: None. Minor issues: Not really an issue, but more of thinking out loud. There is no text in Section 3.2. what happens, say, when PE1 sends DHC+Status TLV and PE2 sends DHC+Switching TLV both reporting a failure of PW1. I am not sure if this is a relevant case, but I could expect there can be a sequence of events that cause these DHC messages to cross between PE1 and PE2? Nits/editorial comments: * The document uses few acronyms without expanding them. Those should be checked. * In Section 3.2. s/table 1 ./Table 1. * There are multiple occurrences of "table 1" that should be "Table 1". There are multiple occurrences of "figure 5" that should be "Figure 5". There are multiple occurrences of "figure 1" that should be "Figure 1". * Section 3.2. says "..using the DHC message above." Since the message is quite a bit above I would rewrite this as "..using the DHC message defined in Section 3.1." * Section 3.2. protection procedures would greatly benefit clarity/readability having one or two signaling flow figures assisting the textual description how the PW failures are signaled between the PEs (using the DHCs and sometimes assisted with OAM messaging). _______________________________________________ Pals mailing list Pals@ietf.org https://www.ietf.org/mailman/listinfo/pals
- [Gen-art] Review of draft-ietf-pals-mpls-tp-dual-… Jouni Korhonen
- Re: [Gen-art] [Pals] Review of draft-ietf-pals-mp… Weiqiang Cheng
- Re: [Gen-art] Review of draft-ietf-pals-mpls-tp-d… Jari Arkko