[Gen-art] Genart last call review of draft-ietf-httpapi-linkset-06

Christer Holmberg via Datatracker <noreply@ietf.org> Mon, 10 January 2022 23:26 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 963EB3A1611; Mon, 10 Jan 2022 15:26:40 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-httpapi-linkset.all@ietf.org, httpapi@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.42.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164185720050.20061.12672441945763045384@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Mon, 10 Jan 2022 15:26:40 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/CNdklatSYc9n39gTau8BGlECMio>
Subject: [Gen-art] Genart last call review of draft-ietf-httpapi-linkset-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jan 2022 23:26:41 -0000

Reviewer: Christer Holmberg
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-httpapi-linkset-06
Reviewer: Christer Holmberg
Review Date: 2022-01-10
IETF LC End Date: 2022-01-19
IESG Telechat date: Not scheduled for a telechat

Summary: Technically I don't have any major issue.  However, I do have a minor
technical, one administrative, and some editorial, comments.

Major issues:

Q1: The draft is intended to be published as Informational RFC. That sounds a
little strange to me. Could you please explain what the reason is?

Minor issues:

Q2: The document defines the "application/linkset+json" format, and indicates
that it can also be used for JSON-LD. What is the reason for not defining a
separate format for JSON-LD? Separate formats ("application/json" and
"application/ld+json") have previously been defined.

Nits/editorial comments:

Q3: The document has long sentences like "One serializes links in the same
format as used in HTTP the Link header field". Couldn't one just say "based on
the syntax of the HTTP Link header field", or something like that?

Q4: The document talks about "document format". People familiar with HTTP are
probably familiar with that terminology, but I think it would be good to add a
reference on first occurrence.

Q5: In Section 1, you talk about serializing links as JSON objects. Should it
be JSON strings, or something? JSON object is not a serialization.