Re: [Gen-art] Review of draft-ietf-ccamp-flexible-grid-ospf-ext-07
Pete Resnick <presnick@qti.qualcomm.com> Mon, 06 February 2017 17:37 UTC
Return-Path: <presnick@qti.qualcomm.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72A27129418; Mon, 6 Feb 2017 09:37:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.021
X-Spam-Level:
X-Spam-Status: No, score=-7.021 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=qti.qualcomm.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0LvvZ10Mgjgt; Mon, 6 Feb 2017 09:37:52 -0800 (PST)
Received: from wolverine02.qualcomm.com (wolverine02.qualcomm.com [199.106.114.251]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0420E1293D8; Mon, 6 Feb 2017 09:37:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1486402672; x=1517938672; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8CUooSX7jNZmLb4sycMKsdyMVTjQUMs+U9S55/nlvxM=; b=rvUXdQEE8kNkTPeDOTwB6Q/FIArktiaci7Gn5XUZMLZ3aqCl8FLH47Dl /vFq7vyV9D7QTpI4iz4qLsouAlKZLFSidDO1zqdO3zFf7gH6s+ZT3L9ZH Bxz06nG3cPWWdczljRJg0Zxese+3jCmve72HFSDeAiihjdAbEm1ZSIuFD c=;
X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208,217";a="356023463"
Received: from unknown (HELO ironmsg02-L.qualcomm.com) ([10.53.140.109]) by wolverine02.qualcomm.com with ESMTP; 06 Feb 2017 09:37:51 -0800
X-IronPort-AV: E=McAfee;i="5800,7501,8431"; a="861405932"
Received: from nasanexm01f.na.qualcomm.com ([10.85.0.32]) by ironmsg02-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 06 Feb 2017 09:37:51 -0800
Received: from [10.64.115.82] (10.80.80.8) by NASANEXM01F.na.qualcomm.com (10.85.0.32) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Mon, 6 Feb 2017 09:37:50 -0800
From: Pete Resnick <presnick@qti.qualcomm.com>
To: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
Date: Mon, 06 Feb 2017 11:37:48 -0600
Message-ID: <98F6A1A1-2444-4782-99A6-3F5532FE1F63@qti.qualcomm.com>
In-Reply-To: <AM2PR07MB0994EB1B4B526A4D7A385E8EF0400@AM2PR07MB0994.eurprd07.prod.outlook.com>
References: <148616413998.4157.2652633501511666882.idtracker@ietfa.amsl.com> <2ACBB603-E990-4C86-BE83-4FCC741C254B@piuha.net> <AM2PR07MB0994EB1B4B526A4D7A385E8EF0400@AM2PR07MB0994.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_MailMate_E4255D2C-0F36-426B-BE18-AFE4318EFCAF_="
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (1.9.6r5319)
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: NASANEXM01B.na.qualcomm.com (10.85.0.82) To NASANEXM01F.na.qualcomm.com (10.85.0.32)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/CqPAWGTMlE5rbPF90kr1uwtFy00>
Cc: "draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org" <draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Subject: Re: [Gen-art] Review of draft-ietf-ccamp-flexible-grid-ospf-ext-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 17:37:53 -0000
On 6 Feb 2017, at 7:36, Daniele Ceccarelli wrote: > Hi Jari, Pete, > > First of all thanks for the accurate review. > > All the nits/editorial comments are correct and will be fixed. > > Regarding the minor issue: > >> 4.1.1: >> >> The figure is a bit confusing: There might not exist a "Max Slot >> Width at Priority >> 7" if bit 7 is clear in the Priority field, correct? >> Perhaps it would be better to just show that as "..." or "Max Slot >> Width at >> Priority n". The thing is, it might only be a single value, followed >> by the >> padding, so having the second value in there might be misleading. >> (Perhaps >> similar constructs are used in other MPLS docs and people will >> understand. But >> it took me a while to figure it out.) >> > > it was difficult to express in the figure the fact that only some of > the priorities are advertised. As you said it could be one, two or any > number up to 8. > What about a single field (with ~ on the borders to indicate that it > can have variable length) saying "Max Slot Width at Prio n" and then > say that 16 bits are used for each prio and when an odd number of > priorities is used the field is padded to line up with multiples of 32 > bits? Yes, I think that would make more sense to me. >> The discussion of Priority was very confusing for me. In the third >> sentence, do >> you mean, "A bit is set (1) corresponding to each priority >> represented in the >> sub-TLV, and clear (0) for each priority not represented in the >> sub-TLV"? I don't >> understand the MUST/MUST NOT as you had it. And I don't understand >> the >> last sentence at all. Are you trying to say, "The leftmost bit >> (priority level 0) >> MUST be set, and priority level 0 MUST be advertised in the >> sub-TLV."? >> Otherwise, I don't get it. > > It means that if the priority field is set to e.g. 10010010 in the > following you would find 4 fields indicating respectively: Max Slot > Width at Priority 0, Max Slot Width at Priority 3, Max Slot Width at > Priority 6 and since they are 3 a 16 bits padding to 32 bits. OK, then I think my sentence is clearer for that: "A bit is set (1) corresponding to each priority represented in the sub-TLV, and clear (0) for each priority not represented in the sub-TLV." > It also means that at least one priority must be advertised (i.e. > priority 00000000 is not allowed). I get that part ("At least one priority level MUST be advertised"). It's the end I don't understand: "that, unless overridden by local policy, SHALL be at priority level 0." What does that mean? >> I don't understand the MAY in the last sentence. Does that mean that >> I MAY >> also set it to the highest possible nominal central frequency >> supported by the >> link? I don't understand what that sentence is trying to tell me. >> > > An example is provided in section 4.1.2, where the available range > goes from -2 to +8 but the range supported by the link goes from -9 to > +11. The sentence means that even if not available it could be > possible to indicate also n=-9 to indicate the starting point of the > range supported by the link. > > " In this example, it is assumed that the lowest nominal central > frequency supported is n= -9 and the highest is n=11. Note they > cannot be used as a nominal central frequency for setting up a LSP, > but merely as the way to express the supported frequency range." > > I'm ok with dropping the sentence. I think dropping the sentence would make the most sense. > Thank you > Daniele Thanks for considering my suggested changes. pr >> -----Original Message----- >> From: Jari Arkko [mailto:jari.arkko@piuha.net] >> Sent: lunedì 6 febbraio 2017 12:32 >> To: Pete Resnick <presnick@qti.qualcomm.com> >> Cc: gen-art@ietf.org; >> draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org; >> ccamp@ietf.org; ietf@ietf.org >> Subject: Re: [Gen-art] Review of >> draft-ietf-ccamp-flexible-grid-ospf-ext-07 >> >> Thanks for your review, Pete. Authors, any comments? >> >> Jari -- Pete Resnick <http://www.qualcomm.com/~presnick/> Qualcomm Technologies, Inc. - +1 (858)651-4478
- [Gen-art] Review of draft-ietf-ccamp-flexible-gri… Pete Resnick
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Jari Arkko
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Daniele Ceccarelli
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Pete Resnick
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Daniele Ceccarelli
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Pete Resnick
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Daniele Ceccarelli
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Pete Resnick
- Re: [Gen-art] Review of draft-ietf-ccamp-flexible… Daniele Ceccarelli