Re: [Gen-art] Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06

Jari Arkko <jari.arkko@piuha.net> Thu, 21 November 2013 13:30 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A77021ADF64 for <gen-art@ietfa.amsl.com>; Thu, 21 Nov 2013 05:30:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.425
X-Spam-Level:
X-Spam-Status: No, score=-2.425 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.525] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y1A3CLRr0mXp for <gen-art@ietfa.amsl.com>; Thu, 21 Nov 2013 05:30:55 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 8867A1AE142 for <gen-art@ietf.org>; Thu, 21 Nov 2013 05:30:54 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id CC0BF2CC6C; Thu, 21 Nov 2013 15:30:46 +0200 (EET)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KS38u52KVtHo; Thu, 21 Nov 2013 15:30:45 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 5645C2CC48; Thu, 21 Nov 2013 15:30:43 +0200 (EET)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <F80BA530-12D2-42CD-9851-27B62D8DB68F@nostrum.com>
Date: Thu, 21 Nov 2013 10:30:40 -0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <8D78959F-8C52-4E2D-9B8E-F6239C584B3C@piuha.net>
References: <877E63A6-07D1-45C3-93EA-086871A8ADE7@nostrum.com> <52727FDE.6040108@cisco.com> <7CCBFD9D-71E4-42C4-A10B-B60ABCC5DDE7@nostrum.com> <52787129.5060907@cisco.com> <F80BA530-12D2-42CD-9851-27B62D8DB68F@nostrum.com>
To: Ben Campbell <ben@nostrum.com>
X-Mailer: Apple Mail (2.1510)
Cc: Benoit Claise <bclaise@cisco.com>, ipfix-ads@tools.ietf.org, draft-ietf-ipfix-data-link-layer-monitoring.all@tools.ietf.org, "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>, Paul Aitken <paitken@cisco.com>
Subject: Re: [Gen-art] Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Nov 2013 13:30:57 -0000

All - thank you for the review & the fixes!

Jari

On Nov 5, 2013, at 9:09 PM, Ben Campbell <ben@nostrum.com> wrote:

> Hi,
> 
> The revised version addresses all of my Gen-ART review comments.
> 
> Thanks!
> 
> Ben.
> 
> On Nov 4, 2013, at 8:16 PM, Benoit Claise <bclaise@cisco.com> wrote:
> 
>> Ben,
>> 
>> A new draft version has been posted
>> https://datatracker.ietf.org/doc/draft-ietf-ipfix-data-link-layer-monitoring/ 
>> 
>> Regards, Benoit
>>> Thanks for the response. Those changes would address all of my comments.
>>> 
>>> Thanks!
>>> 
>>> Ben.
>>> 
>>> On Oct 31, 2013, at 11:05 AM, Paul Aitken <paitken@cisco.com> wrote:
>>> 
>>>> Thanks for the review, Ben.
>>>> 
>>>> As you pointed out, the description in 3.2.18 wrongly specified a delta rather than a total; I've fixed it.
>>>> 
>>>> I also clarified the third paragraph of the Introduction to say that the existing models don't yet contain enough elements - which is the point of this draft.
>>>> 
>>>> Regarding section 4 / RFC 5477, the intention is that IANA's IPFIX registry is the ultimate reference. We want to avoid new drafts updating old RFCs.
>>>> The IPFIX AD is considering how to proceed with that.
>>>> 
>>>> I'll publish a -07 with the changes.
>>>> 
>>>> Thanks,
>>>> P.
>>>> 
>>>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>>>> Gen-ART, please see the FAQ at
>>>>> 
>>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>>> 
>>>>> Please resolve these comments along with any other Last Call comments
>>>>> you may receive.
>>>>> 
>>>>> Document: draft-ietf-ipfix-data-link-layer-monitoring-06
>>>>> Reviewer: Ben Campbell
>>>>> Review Date: 2013-22-10
>>>>> IETF LC End Date: 2013-23-10
>>>>> 
>>>>> Summary: Ready for publication as a proposed standard, with  one problem that should be easily fixed.
>>>>> 
>>>>> Major issues:
>>>>> 
>>>>> None
>>>>> 
>>>>> Minor issues:
>>>>> 
>>>>> 3.2.18:
>>>>> 
>>>>> Title of the data element suggests a total, but the description sounds like a delta (i.e change since last report.)
>>>>> 
>>>>> -- section 4 and subsections
>>>>> 
>>>>> It looks like this draft updates at least RFC5477. If so, this should be indicated in the header and in the abstract.
>>>>> 
>>>>> 
>>>>> 
>>>>> Nits/editorial comments:
>>>>> 
>>>>> -- section , 3rd paragraph:
>>>>> 
>>>>> Do you mean to say the existing data models do not contain the elements needed, or that the models do not provide the right foundation for the needed elements? The wording seems to indicate the latter but I think you mean the former.
>>>>> 
>>>>> -- General:
>>>>> Watch for missing articles.
>>> .
>>> 
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art