[Gen-art] Gen-ART review of draft-ietf-isis-te-metric-extensions-07

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 19 January 2016 13:54 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com []) by ietfa.amsl.com (Postfix) with ESMTP id 454FF1B2E99 for <gen-art@ietfa.amsl.com>; Tue, 19 Jan 2016 05:54:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id Q0E1RAZa-zpj for <gen-art@ietfa.amsl.com>; Tue, 19 Jan 2016 05:54:39 -0800 (PST)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net []) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27AC61B2ED6 for <gen-art@ietf.org>; Tue, 19 Jan 2016 05:54:39 -0800 (PST)
X-AuditID: c1b4fb30-f79a76d000000a93-a8-569e401df802
Received: from ESESSHC012.ericsson.se (Unknown_Domain []) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id C7.08.02707.D104E965; Tue, 19 Jan 2016 14:54:37 +0100 (CET)
Received: from ESESSMB209.ericsson.se ([]) by ESESSHC012.ericsson.se ([]) with mapi id 14.03.0248.002; Tue, 19 Jan 2016 14:54:36 +0100
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-isis-te-metric-extensions-07
Thread-Index: AdFSvY9HopzpNvjTQ9SXDq14MdUR+g==
Date: Tue, 19 Jan 2016 13:54:36 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B37D493C4@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
x-originating-ip: []
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B37D493C4ESESSMB209erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42KZGbHdTFfWYV6YwftlwhbtH2YyWVx99ZnF gcljyZKfTB5fLn9mC2CK4rJJSc3JLEst0rdL4Mo4MX0jY8HGvIrlZ3ezNTA+S+xi5OSQEDCR mPptGQuELSZx4d56ti5GLg4hgcOMEjsuX2MCSQgJLGGUWPk7t4uRg4NNwEKi+582SFhEQFNi 7oq3YCXMApUSp8+fBZsjLOAkcaDnChNEjbvE+a3T2CBsPYnJ0w6yg9gsAqoSL7+1M4PYvAK+ En8OvgWLMwLd8P3UGqiZ4hK3nsxngrhNQGLJnvPMELaoxMvH/1ghbEWJnWch5jAL5Evc/Hea CWKmoMTJmU9YJjAKz0IyahaSsllIyiDiOhILdn9ig7C1JZYtfM0MY5858JgJWXwBI/sqRtHi 1OKk3HQjI73Uoszk4uL8PL281JJNjMDoObjlt8EOxpfPHQ8xCnAwKvHwFuTNDRNiTSwrrsw9 xCjBwawkwvvQdF6YEG9KYmVValF+fFFpTmrxIUZpDhYlcd4kmcYwIYH0xJLU7NTUgtQimCwT B6dUA6PbtJP6m8/+3W2amn8xni+8S/fuDj+Zt+b3ImdWfdVs1Vn+ev+L+aacTPMKXyt8nixb PuN+oohb0WKn37e0Hjh++exj/y72rsIdh65t/HuC/Dvmzbu2YIcay57Xoac+Od9KVa08q3rl T9K/jtqPLL2zFh2rr//OwH07ztni+dpJxYFixTaTO1YqsRRnJBpqMRcVJwIA+9KLUJoCAAA=
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/DMBxEEkghiw9cvRcVCQt9ixnV_0>
Cc: "draft-ietf-isis-te-metric-extensions.all@tools.ietf.org" <draft-ietf-isis-te-metric-extensions.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-isis-te-metric-extensions-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2016 13:54:42 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                                                  draft-ietf-isis-te-metric-extensions-07.txt
Reviewer:                                                   Christer Holmberg
Review Date:                                               19 January 2016
IETF LC End Date:                                          30 December 2015
IETF Telechat Date:                                       21 January 2016
Summary:           The document is well written, and is almost ready for publication. However, there are some editorial issues that I ask the authors to address.
Major Issues: None
Minor Issues: None
Editorial Issues:



In section 1, you say that the extension is hereafter called "IS-IS TE Metric Extensions".

However, you then refer to it as e.g. "TE Metric Extensions" and "ISIS TE Metric Extensions".

Please use consistent terminology.


Sometimes the text says "sub-TLV", sometimes "SubTLV", and sometimes "Sub TLV". Please use consistent terminology.



I suggest to rewrite:

"This document describes extensions to IS-IS Extended Reachability TLV
defined in [RFC5305] (hereafter called "IS-IS TE Metric Extensions"),..."


"This document describes extensions (hereafter called "IS-IS TE Metric Extensions")
to IS-IS Extended Reachability TLV defined in [RFC5305],..."

... to make it more clear that "IS-IS TE Metric Extensions" refers to the extensions, and not to the TLV.



I have some difficulties to follow the A,B,C bullet list logic.

I think it would be more clear to structure it e.g. like:

"From an  MPLS perspective, the intent of the A bit is to permit LSP ingress
nodes to determine whether the link referenced in the sub-TLV affects any
of the LSPs for which it is ingress.

If any of the LSPs are affected, the receiving node shall determine whether
those LSPs still meet end-to-end performance objectives. If the objectives
are not met the receiving node could conceivably move affected traffic to a pre-
established protection LSP or establish a new LSP and place the traffic in it."